* [PATCH RESEND] serial: samsung: Fix serial config dependencies for exynos7
@ 2014-11-17 4:44 Abhilash Kesavan
2014-11-17 18:59 ` Greg KH
2014-11-19 7:56 ` [PATCH v2] " Abhilash Kesavan
0 siblings, 2 replies; 6+ messages in thread
From: Abhilash Kesavan @ 2014-11-17 4:44 UTC (permalink / raw)
To: linux-arm-kernel, gregkh; +Cc: linux-samsung-soc, linux-kernel, arnd, jslaby
From: Pankaj Dubey <pankaj.dubey@samsung.com>
Exynos7 has a similar serial controller to that present in older Samsung
SoCs. To re-use the existing serial driver on Exynos7 we need to have
SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS selected. This is not
possible because these symbols are dependent on PLAT_SAMSUNG which is
not present for the ARMv8 based exynos7.
Change the dependency of these symbols from PLAT_SAMSUNG to the serial
driver thus making it available on exynos7. As the existing platform
specific code making use of these symbols is related to uart driver this
change in dependency should not cause any issues.
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
Re-sending as the previous version did not reach Greg KH.
drivers/tty/serial/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index e71a28b..d0ce88c 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -249,14 +249,14 @@ config SERIAL_SAMSUNG
config SERIAL_SAMSUNG_UARTS_4
bool
- depends on PLAT_SAMSUNG
+ depends on SERIAL_SAMSUNG
default y if !(CPU_S3C2410 || CPU_S3C2412 || CPU_S3C2440 || CPU_S3C2442)
help
Internal node for the common case of 4 Samsung compatible UARTs
config SERIAL_SAMSUNG_UARTS
int
- depends on PLAT_SAMSUNG
+ depends on SERIAL_SAMSUNG
default 4 if SERIAL_SAMSUNG_UARTS_4 || CPU_S3C2416
default 3
help
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] serial: samsung: Fix serial config dependencies for exynos7
2014-11-17 4:44 [PATCH RESEND] serial: samsung: Fix serial config dependencies for exynos7 Abhilash Kesavan
@ 2014-11-17 18:59 ` Greg KH
2014-11-19 7:28 ` Kukjin Kim
2014-11-19 7:56 ` [PATCH v2] " Abhilash Kesavan
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2014-11-17 18:59 UTC (permalink / raw)
To: Abhilash Kesavan
Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel, arnd, jslaby
On Mon, Nov 17, 2014 at 10:14:51AM +0530, Abhilash Kesavan wrote:
> From: Pankaj Dubey <pankaj.dubey@samsung.com>
>
> Exynos7 has a similar serial controller to that present in older Samsung
> SoCs. To re-use the existing serial driver on Exynos7 we need to have
> SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS selected. This is not
> possible because these symbols are dependent on PLAT_SAMSUNG which is
> not present for the ARMv8 based exynos7.
>
> Change the dependency of these symbols from PLAT_SAMSUNG to the serial
> driver thus making it available on exynos7. As the existing platform
> specific code making use of these symbols is related to uart driver this
> change in dependency should not cause any issues.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] serial: samsung: Fix serial config dependencies for exynos7
2014-11-17 18:59 ` Greg KH
@ 2014-11-19 7:28 ` Kukjin Kim
2014-11-19 7:51 ` Abhilash Kesavan
0 siblings, 1 reply; 6+ messages in thread
From: Kukjin Kim @ 2014-11-19 7:28 UTC (permalink / raw)
To: Greg KH
Cc: Abhilash Kesavan, jslaby, linux-samsung-soc, arnd, linux-kernel,
linux-arm-kernel
On 11/18/14 03:59, Greg KH wrote:
> On Mon, Nov 17, 2014 at 10:14:51AM +0530, Abhilash Kesavan wrote:
>> From: Pankaj Dubey <pankaj.dubey@samsung.com>
>>
>> Exynos7 has a similar serial controller to that present in older Samsung
>> SoCs. To re-use the existing serial driver on Exynos7 we need to have
>> SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS selected. This is not
>> possible because these symbols are dependent on PLAT_SAMSUNG which is
>> not present for the ARMv8 based exynos7.
>>
>> Change the dependency of these symbols from PLAT_SAMSUNG to the serial
>> driver thus making it available on exynos7. As the existing platform
>> specific code making use of these symbols is related to uart driver this
>> change in dependency should not cause any issues.
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> ---
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
Greg, thanks for your ack on this.
Abhilash,
I can't find the original patch in my mailbox, can you please re-send to
me with adding Greg's ack?
Thanks,
Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] serial: samsung: Fix serial config dependencies for exynos7
2014-11-19 7:28 ` Kukjin Kim
@ 2014-11-19 7:51 ` Abhilash Kesavan
0 siblings, 0 replies; 6+ messages in thread
From: Abhilash Kesavan @ 2014-11-19 7:51 UTC (permalink / raw)
To: Kukjin Kim
Cc: Greg KH, jslaby, linux-samsung-soc, Arnd Bergmann, linux-kernel,
linux-arm-kernel
Hi Kukjin,
On Wed, Nov 19, 2014 at 12:58 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> On 11/18/14 03:59, Greg KH wrote:
>> On Mon, Nov 17, 2014 at 10:14:51AM +0530, Abhilash Kesavan wrote:
>>> From: Pankaj Dubey <pankaj.dubey@samsung.com>
>>>
>>> Exynos7 has a similar serial controller to that present in older Samsung
>>> SoCs. To re-use the existing serial driver on Exynos7 we need to have
>>> SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS selected. This is not
>>> possible because these symbols are dependent on PLAT_SAMSUNG which is
>>> not present for the ARMv8 based exynos7.
>>>
>>> Change the dependency of these symbols from PLAT_SAMSUNG to the serial
>>> driver thus making it available on exynos7. As the existing platform
>>> specific code making use of these symbols is related to uart driver this
>>> change in dependency should not cause any issues.
>>>
>>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>>> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
>>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>> ---
>> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>
> Greg, thanks for your ack on this.
>
> Abhilash,
>
> I can't find the original patch in my mailbox, can you please re-send to
> me with adding Greg's ack?
Will send it you with Greg's Ack.
Thanks,
Abhilash
>
> Thanks,
> Kukjin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] serial: samsung: Fix serial config dependencies for exynos7
2014-11-17 4:44 [PATCH RESEND] serial: samsung: Fix serial config dependencies for exynos7 Abhilash Kesavan
2014-11-17 18:59 ` Greg KH
@ 2014-11-19 7:56 ` Abhilash Kesavan
2014-11-21 15:11 ` Kukjin Kim
1 sibling, 1 reply; 6+ messages in thread
From: Abhilash Kesavan @ 2014-11-19 7:56 UTC (permalink / raw)
To: linux-arm-kernel, kgene.kim, kgene, kgene.kim
Cc: linux-samsung-soc, linux-kernel, arnd, gregkh, jslaby,
kesavan.abhilash, Pankaj Dubey
From: Pankaj Dubey <pankaj.dubey@samsung.com>
Exynos7 has a similar serial controller to that present in older Samsung
SoCs. To re-use the existing serial driver on Exynos7 we need to have
SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS selected. This is not
possible because these symbols are dependent on PLAT_SAMSUNG which is
not present for the ARMv8 based exynos7.
Change the dependency of these symbols from PLAT_SAMSUNG to the serial
driver thus making it available on exynos7. As the existing platform
specific code making use of these symbols is related to uart driver this
change in dependency should not cause any issues.
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
Changes in v2:
- Added Greg's ack and Kukjin Kim as a recepient
drivers/tty/serial/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index e71a28b..d0ce88c 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -249,14 +249,14 @@ config SERIAL_SAMSUNG
config SERIAL_SAMSUNG_UARTS_4
bool
- depends on PLAT_SAMSUNG
+ depends on SERIAL_SAMSUNG
default y if !(CPU_S3C2410 || CPU_S3C2412 || CPU_S3C2440 || CPU_S3C2442)
help
Internal node for the common case of 4 Samsung compatible UARTs
config SERIAL_SAMSUNG_UARTS
int
- depends on PLAT_SAMSUNG
+ depends on SERIAL_SAMSUNG
default 4 if SERIAL_SAMSUNG_UARTS_4 || CPU_S3C2416
default 3
help
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] serial: samsung: Fix serial config dependencies for exynos7
2014-11-19 7:56 ` [PATCH v2] " Abhilash Kesavan
@ 2014-11-21 15:11 ` Kukjin Kim
0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2014-11-21 15:11 UTC (permalink / raw)
To: Abhilash Kesavan
Cc: linux-arm-kernel, kgene.kim, kgene, linux-samsung-soc,
linux-kernel, arnd, gregkh, jslaby, kesavan.abhilash,
Pankaj Dubey
On 11/19/14 16:56, Abhilash Kesavan wrote:
> From: Pankaj Dubey <pankaj.dubey@samsung.com>
>
> Exynos7 has a similar serial controller to that present in older Samsung
> SoCs. To re-use the existing serial driver on Exynos7 we need to have
> SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS selected. This is not
> possible because these symbols are dependent on PLAT_SAMSUNG which is
> not present for the ARMv8 based exynos7.
>
> Change the dependency of these symbols from PLAT_SAMSUNG to the serial
> driver thus making it available on exynos7. As the existing platform
> specific code making use of these symbols is related to uart driver this
> change in dependency should not cause any issues.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> Changes in v2:
> - Added Greg's ack and Kukjin Kim as a recepient
Applied, thanks.
- Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-11-21 15:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-17 4:44 [PATCH RESEND] serial: samsung: Fix serial config dependencies for exynos7 Abhilash Kesavan
2014-11-17 18:59 ` Greg KH
2014-11-19 7:28 ` Kukjin Kim
2014-11-19 7:51 ` Abhilash Kesavan
2014-11-19 7:56 ` [PATCH v2] " Abhilash Kesavan
2014-11-21 15:11 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).