From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Jin Yao <yao.jin@linux.intel.com>,
John Garry <john.garry@huawei.com>, Paul Clarke <pc@us.ibm.com>,
kajoljain <kjain@linux.ibm.com>,
Stephane Eranian <eranian@google.com>,
Sandeep Dasgupta <sdasgup@google.com>
Subject: Re: [PATCH v5 1/5] perf metric: Restructure struct expr_parse_ctx.
Date: Mon, 7 Dec 2020 22:20:25 +0900 [thread overview]
Message-ID: <CAM9d7chQQK2DP_gEFdi-OG5X6wCoouH75Jsg-V=UEFpuB-5bFA@mail.gmail.com> (raw)
In-Reply-To: <20201202073953.3811709-2-irogers@google.com>
Hi Ian,
On Wed, Dec 2, 2020 at 4:40 PM Ian Rogers <irogers@google.com> wrote:
>
> A later change to parsing the ids out (in expr__find_other) will
> potentially drop hashmaps and so it is more convenient to move
> expr_parse_ctx to have a hashmap pointer rather than a struct value. As
> this pointer must be freed, rather than just going out of scope,
> add expr__ctx_new and expr__ctx_free to manage expr_parse_ctx memory.
> Adjust use of struct expr_parse_ctx accordingly.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
[SNIP]
> -void expr__ctx_init(struct expr_parse_ctx *ctx)
> +struct expr_parse_ctx *expr__ctx_new(void)
> {
> - hashmap__init(&ctx->ids, key_hash, key_equal, NULL);
> + struct expr_parse_ctx *ctx;
> +
> + ctx = malloc(sizeof(struct expr_parse_ctx));
> + if (!ctx)
> + return NULL;
> +
> + ctx->ids = hashmap__new(key_hash, key_equal, NULL);
> + ctx->parent = NULL;
> + return ctx;
> }
>
> void expr__ctx_clear(struct expr_parse_ctx *ctx)
> @@ -221,11 +229,23 @@ void expr__ctx_clear(struct expr_parse_ctx *ctx)
> struct hashmap_entry *cur;
> size_t bkt;
>
> - hashmap__for_each_entry((&ctx->ids), cur, bkt) {
> + hashmap__for_each_entry(ctx->ids, cur, bkt) {
> + free((char *)cur->key);
> + free(cur->value);
> + }
> + hashmap__clear(ctx->ids);
> +}
> +
> +void expr__ctx_free(struct expr_parse_ctx *ctx)
> +{
> + struct hashmap_entry *cur;
> + size_t bkt;
> +
> + hashmap__for_each_entry(ctx->ids, cur, bkt) {
> free((char *)cur->key);
> free(cur->value);
> }
> - hashmap__clear(&ctx->ids);
> + hashmap__free(ctx->ids);
> }
I think this function should free the ctx itself.
Thanks,
Namhyung
next prev parent reply other threads:[~2020-12-07 13:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 7:39 [PATCH v5 0/5] Don't compute events that won't be used in a metric Ian Rogers
2020-12-02 7:39 ` [PATCH v5 1/5] perf metric: Restructure struct expr_parse_ctx Ian Rogers
2020-12-07 13:20 ` Namhyung Kim [this message]
2020-12-02 7:39 ` [PATCH v5 2/5] perf metric: Use NAN for missing event IDs Ian Rogers
2020-12-02 7:39 ` [PATCH v5 3/5] perf metric: Rename expr__find_other Ian Rogers
2020-12-02 7:39 ` [PATCH v5 4/5] perf metric: Add utilities to work on ids map Ian Rogers
2020-12-07 13:23 ` Namhyung Kim
2020-12-02 7:39 ` [PATCH v5 5/5] perf metric: Don't compute unused events Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM9d7chQQK2DP_gEFdi-OG5X6wCoouH75Jsg-V=UEFpuB-5bFA@mail.gmail.com' \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=sdasgup@google.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).