From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Jin Yao <yao.jin@linux.intel.com>,
John Garry <john.garry@huawei.com>, Paul Clarke <pc@us.ibm.com>,
kajoljain <kjain@linux.ibm.com>,
Stephane Eranian <eranian@google.com>,
Sandeep Dasgupta <sdasgup@google.com>
Subject: Re: [PATCH v5 4/5] perf metric: Add utilities to work on ids map.
Date: Mon, 7 Dec 2020 22:23:59 +0900 [thread overview]
Message-ID: <CAM9d7ciWzaqP2i=Agx9JxGCw4C3gQ=UUW+cMwWvAPjecd6C2=Q@mail.gmail.com> (raw)
In-Reply-To: <20201202073953.3811709-5-irogers@google.com>
On Wed, Dec 2, 2020 at 4:40 PM Ian Rogers <irogers@google.com> wrote:
>
> Add utilities to new/free an ids hashmap, as well as to union. Add
> testing of the union. Unioning hashmaps will be used when parsing the
> metric, if a value is known then the hashmap is unnecessary, otherwise
> we need to union together all the event ids to compute their values for
> reporting.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
[SNIP]
What about adding a comment that it should not access ids1 and ids2
after this function since they can be released?
> +struct hashmap *ids__union(struct hashmap *ids1, struct hashmap *ids2)
> +{
> + size_t bkt;
> + struct hashmap_entry *cur;
> + int ret;
> + struct expr_id_data *old_data = NULL;
> + char *old_key = NULL;
> +
> + if (!ids1)
> + return ids2;
> +
> + if (!ids2)
> + return ids1;
> +
> + if (hashmap__size(ids1) < hashmap__size(ids2)) {
> + struct hashmap *tmp = ids1;
> +
> + ids1 = ids2;
> + ids2 = tmp;
> + }
> + hashmap__for_each_entry(ids2, cur, bkt) {
> + ret = hashmap__set(ids1, cur->key, cur->value,
> + (const void **)&old_key, (void **)&old_data);
> + free(old_key);
> + free(old_data);
> +
> + if (ret)
> + break;
> + }
> + hashmap__free(ids2);
> + return ids1;
> +}
next prev parent reply other threads:[~2020-12-07 13:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 7:39 [PATCH v5 0/5] Don't compute events that won't be used in a metric Ian Rogers
2020-12-02 7:39 ` [PATCH v5 1/5] perf metric: Restructure struct expr_parse_ctx Ian Rogers
2020-12-07 13:20 ` Namhyung Kim
2020-12-02 7:39 ` [PATCH v5 2/5] perf metric: Use NAN for missing event IDs Ian Rogers
2020-12-02 7:39 ` [PATCH v5 3/5] perf metric: Rename expr__find_other Ian Rogers
2020-12-02 7:39 ` [PATCH v5 4/5] perf metric: Add utilities to work on ids map Ian Rogers
2020-12-07 13:23 ` Namhyung Kim [this message]
2020-12-02 7:39 ` [PATCH v5 5/5] perf metric: Don't compute unused events Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM9d7ciWzaqP2i=Agx9JxGCw4C3gQ=UUW+cMwWvAPjecd6C2=Q@mail.gmail.com' \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=sdasgup@google.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).