linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] hsr: Fix a compilation error
@ 2020-01-20  3:26 xiaofeng.yan
  2020-01-20  4:44 ` Taehee Yoo
  0 siblings, 1 reply; 2+ messages in thread
From: xiaofeng.yan @ 2020-01-20  3:26 UTC (permalink / raw)
  To: arvid.brodin, davem, netdev, linux-kernel; +Cc: xiaofeng.yan2012, yanxiaofeng7

From: "xiaofeng.yan" <yanxiaofeng7@jd.com>

A compliation error happen when building branch 5.5-rc7

In file included from net/hsr/hsr_main.c:12:0:
net/hsr/hsr_main.h:194:20: error: two or more data types in declaration specifiers
 static inline void void hsr_debugfs_rename(struct net_device *dev)

So Removed one void.

Signed-off-by: xiaofeng.yan <yanxiaofeng7@jd.com>
---
 net/hsr/hsr_main.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/hsr/hsr_main.h b/net/hsr/hsr_main.h
index d40de84..754d84b 100644
--- a/net/hsr/hsr_main.h
+++ b/net/hsr/hsr_main.h
@@ -191,7 +191,7 @@ static inline u16 hsr_get_skb_sequence_nr(struct sk_buff *skb)
 void hsr_debugfs_create_root(void);
 void hsr_debugfs_remove_root(void);
 #else
-static inline void void hsr_debugfs_rename(struct net_device *dev)
+static inline void hsr_debugfs_rename(struct net_device *dev)
 {
 }
 static inline void hsr_debugfs_init(struct hsr_priv *priv,
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] hsr: Fix a compilation error
  2020-01-20  3:26 [PATCH] hsr: Fix a compilation error xiaofeng.yan
@ 2020-01-20  4:44 ` Taehee Yoo
  0 siblings, 0 replies; 2+ messages in thread
From: Taehee Yoo @ 2020-01-20  4:44 UTC (permalink / raw)
  To: xiaofeng.yan; +Cc: arvid.brodin, David Miller, Netdev, LKML, yanxiaofeng7

On Mon, 20 Jan 2020 at 12:26, xiaofeng.yan <xiaofeng.yan2012@gmail.com> wrote:
>
> From: "xiaofeng.yan" <yanxiaofeng7@jd.com>
>

Hi Xiaofeng,

> A compliation error happen when building branch 5.5-rc7
>
> In file included from net/hsr/hsr_main.c:12:0:
> net/hsr/hsr_main.h:194:20: error: two or more data types in declaration specifiers
>  static inline void void hsr_debugfs_rename(struct net_device *dev)
>
> So Removed one void.
>
> Signed-off-by: xiaofeng.yan <yanxiaofeng7@jd.com>

Acked-by: Taehee Yoo <ap420073@gmail.com>

I think the Fixes tag is needed.
You might have to send a v2 patch, which includes this Fixes tag.
Fixes: 4c2d5e33dcd3 ("hsr: rename debugfs file when interface name is changed")

Thank you!
Taehee Yoo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-01-20  4:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-20  3:26 [PATCH] hsr: Fix a compilation error xiaofeng.yan
2020-01-20  4:44 ` Taehee Yoo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).