* [PATCH] scsi: pm8001: Fix memleak in pm8001_exec_internal_task_abort
@ 2020-08-23 9:14 Dinghao Liu
2020-08-31 6:15 ` Jinpu Wang
2020-09-03 3:00 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Dinghao Liu @ 2020-08-23 9:14 UTC (permalink / raw)
To: dinghao.liu, kjlu
Cc: Jack Wang, James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel
When pm8001_tag_alloc() fails, task should be freed just
like what we've done in the subsequent error paths.
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
drivers/scsi/pm8001/pm8001_sas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
index 337e79d6837f..9889bab7d31c 100644
--- a/drivers/scsi/pm8001/pm8001_sas.c
+++ b/drivers/scsi/pm8001/pm8001_sas.c
@@ -818,7 +818,7 @@ pm8001_exec_internal_task_abort(struct pm8001_hba_info *pm8001_ha,
res = pm8001_tag_alloc(pm8001_ha, &ccb_tag);
if (res)
- return res;
+ goto ex_err;
ccb = &pm8001_ha->ccb_info[ccb_tag];
ccb->device = pm8001_dev;
ccb->ccb_tag = ccb_tag;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: pm8001: Fix memleak in pm8001_exec_internal_task_abort
2020-08-23 9:14 [PATCH] scsi: pm8001: Fix memleak in pm8001_exec_internal_task_abort Dinghao Liu
@ 2020-08-31 6:15 ` Jinpu Wang
2020-09-03 3:00 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Jinpu Wang @ 2020-08-31 6:15 UTC (permalink / raw)
To: Dinghao Liu
Cc: kjlu, James E.J. Bottomley, Martin K. Petersen,
Linux SCSI Mailinglist, linux-kernel
On Sun, Aug 23, 2020 at 11:15 AM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
>
> When pm8001_tag_alloc() fails, task should be freed just
> like what we've done in the subsequent error paths.
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Thanks!
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
> ---
> drivers/scsi/pm8001/pm8001_sas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
> index 337e79d6837f..9889bab7d31c 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.c
> +++ b/drivers/scsi/pm8001/pm8001_sas.c
> @@ -818,7 +818,7 @@ pm8001_exec_internal_task_abort(struct pm8001_hba_info *pm8001_ha,
>
> res = pm8001_tag_alloc(pm8001_ha, &ccb_tag);
> if (res)
> - return res;
> + goto ex_err;
> ccb = &pm8001_ha->ccb_info[ccb_tag];
> ccb->device = pm8001_dev;
> ccb->ccb_tag = ccb_tag;
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: pm8001: Fix memleak in pm8001_exec_internal_task_abort
2020-08-23 9:14 [PATCH] scsi: pm8001: Fix memleak in pm8001_exec_internal_task_abort Dinghao Liu
2020-08-31 6:15 ` Jinpu Wang
@ 2020-09-03 3:00 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-09-03 3:00 UTC (permalink / raw)
To: kjlu, Dinghao Liu
Cc: Martin K . Petersen, linux-kernel, Jack Wang,
James E.J. Bottomley, linux-scsi
On Sun, 23 Aug 2020 17:14:53 +0800, Dinghao Liu wrote:
> When pm8001_tag_alloc() fails, task should be freed just
> like what we've done in the subsequent error paths.
Applied to 5.9/scsi-fixes, thanks!
[1/1] scsi: pm8001: Fix memleak in pm8001_exec_internal_task_abort
https://git.kernel.org/mkp/scsi/c/ea403fde7552
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-03 3:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-23 9:14 [PATCH] scsi: pm8001: Fix memleak in pm8001_exec_internal_task_abort Dinghao Liu
2020-08-31 6:15 ` Jinpu Wang
2020-09-03 3:00 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).