linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] dt-bindings: gpio: uniphier: Add hogs parsing
@ 2022-03-30  5:17 Kunihiko Hayashi
  2022-03-30  7:04 ` Krzysztof Kozlowski
  2022-04-04 10:52 ` Bartosz Golaszewski
  0 siblings, 2 replies; 3+ messages in thread
From: Kunihiko Hayashi @ 2022-03-30  5:17 UTC (permalink / raw)
  To: Linus Walleij, Bartosz Golaszewski, Rob Herring, Krzysztof Kozlowski
  Cc: Masami Hiramatsu, linux-gpio, devicetree, linux-arm-kernel,
	linux-kernel, Kunihiko Hayashi

Allow parsing GPIO controller children nodes with GPIO hogs to fix the
following warning:

  uniphier-ld11-ref.dtb: gpio@55000000: 'xirq0-hog' does not match any of the regexes: 'pinctrl-[0-9]+'
      From schema: Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---

Changes since v1:
- Remove outer brackets from a pattern string
- Add valid properties to patternProperties
- Add gpios to "required:"

 .../bindings/gpio/socionext,uniphier-gpio.yaml  | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
index bcafa494ed7a..228fa27ffdc3 100644
--- a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
@@ -52,6 +52,23 @@ properties:
       <child-interrupt-base parent-interrupt-base length> triplets.
     $ref: /schemas/types.yaml#/definitions/uint32-matrix
 
+patternProperties:
+  "^.+-hog(-[0-9]+)?$":
+    type: object
+    properties:
+      gpio-hog: true
+      gpios: true
+      input: true
+      output-high: true
+      output-low: true
+      line-name: true
+
+    required:
+      - gpio-hog
+      - gpios
+
+    additionalProperties: false
+
 required:
   - compatible
   - reg
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] dt-bindings: gpio: uniphier: Add hogs parsing
  2022-03-30  5:17 [PATCH v2] dt-bindings: gpio: uniphier: Add hogs parsing Kunihiko Hayashi
@ 2022-03-30  7:04 ` Krzysztof Kozlowski
  2022-04-04 10:52 ` Bartosz Golaszewski
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-30  7:04 UTC (permalink / raw)
  To: Kunihiko Hayashi, Linus Walleij, Bartosz Golaszewski,
	Rob Herring, Krzysztof Kozlowski
  Cc: Masami Hiramatsu, linux-gpio, devicetree, linux-arm-kernel, linux-kernel

On 30/03/2022 07:17, Kunihiko Hayashi wrote:
> Allow parsing GPIO controller children nodes with GPIO hogs to fix the
> following warning:
> 
>   uniphier-ld11-ref.dtb: gpio@55000000: 'xirq0-hog' does not match any of the regexes: 'pinctrl-[0-9]+'
>       From schema: Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
> 
> Changes since v1:
> - Remove outer brackets from a pattern string
> - Add valid properties to patternProperties
> - Add gpios to "required:"
> 
>  .../bindings/gpio/socionext,uniphier-gpio.yaml  | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] dt-bindings: gpio: uniphier: Add hogs parsing
  2022-03-30  5:17 [PATCH v2] dt-bindings: gpio: uniphier: Add hogs parsing Kunihiko Hayashi
  2022-03-30  7:04 ` Krzysztof Kozlowski
@ 2022-04-04 10:52 ` Bartosz Golaszewski
  1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2022-04-04 10:52 UTC (permalink / raw)
  To: Kunihiko Hayashi
  Cc: Linus Walleij, Rob Herring, Krzysztof Kozlowski,
	Masami Hiramatsu, open list:GPIO SUBSYSTEM, devicetree,
	Linux ARM, Linux Kernel Mailing List

On Wed, Mar 30, 2022 at 7:17 AM Kunihiko Hayashi
<hayashi.kunihiko@socionext.com> wrote:
>
> Allow parsing GPIO controller children nodes with GPIO hogs to fix the
> following warning:
>
>   uniphier-ld11-ref.dtb: gpio@55000000: 'xirq0-hog' does not match any of the regexes: 'pinctrl-[0-9]+'
>       From schema: Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
>
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
>
> Changes since v1:
> - Remove outer brackets from a pattern string
> - Add valid properties to patternProperties
> - Add gpios to "required:"
>
>  .../bindings/gpio/socionext,uniphier-gpio.yaml  | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
> index bcafa494ed7a..228fa27ffdc3 100644
> --- a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
> @@ -52,6 +52,23 @@ properties:
>        <child-interrupt-base parent-interrupt-base length> triplets.
>      $ref: /schemas/types.yaml#/definitions/uint32-matrix
>
> +patternProperties:
> +  "^.+-hog(-[0-9]+)?$":
> +    type: object
> +    properties:
> +      gpio-hog: true
> +      gpios: true
> +      input: true
> +      output-high: true
> +      output-low: true
> +      line-name: true
> +
> +    required:
> +      - gpio-hog
> +      - gpios
> +
> +    additionalProperties: false
> +
>  required:
>    - compatible
>    - reg
> --
> 2.25.1
>

Applied, thanks!

Bart

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-04-04 10:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-30  5:17 [PATCH v2] dt-bindings: gpio: uniphier: Add hogs parsing Kunihiko Hayashi
2022-03-30  7:04 ` Krzysztof Kozlowski
2022-04-04 10:52 ` Bartosz Golaszewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).