From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH v2 12/15] arm64: dts: qcom: sa8775p: pmic: add thermal zones
Date: Wed, 22 Mar 2023 16:30:58 +0100 [thread overview]
Message-ID: <CAMRc=MeVaMaQMsLUPH0QDjuOBt3TjVofbj7SgA5zMg3sQGBh=w@mail.gmail.com> (raw)
In-Reply-To: <20230322025047.gvo252mh2flcbzuc@ripper>
On Wed, Mar 22, 2023 at 3:47 AM Bjorn Andersson <andersson@kernel.org> wrote:
>
> On Mon, Mar 20, 2023 at 06:28:20PM +0100, Konrad Dybcio wrote:
> >
> >
> > On 20.03.2023 16:48, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > Add the thermal zones and associated alarm nodes for the PMICs that have
> > > them hooked up on sa8775p-ride.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > ---
> > > arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi | 58 +++++++++++++++++++++
> > > 1 file changed, 58 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> > > index 8616ead3daf5..276070b62ccd 100644
> > > --- a/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sa8775p-pmics.dtsi
> > > @@ -6,6 +6,50 @@
> > > #include <dt-bindings/input/input.h>
> > > #include <dt-bindings/spmi/spmi.h>
> > >
> > > +/ {
> > > + thermal-zones {
> > > + pmm8654au_1_thermal: pm8775-1-thermal {
> > Please reindex this, downstream uses _1 for pmic@0, but this
> > makes little sense. Make it match the SID.
> >
>
> Please use the naming from the schematics for these things, rather than
> just an iterator (which might be what Bartosz is doing here).
>
Not sure how to approach that. All currently existing
"qcom,spmi-temp-alarm" nodes use the PMIC name for the label.
Otherwise it would have to go into the board file and be replicated
for each board using the same PMIC?
Bart
> Regards,
> Bjorn
>
> > > + polling-delay-passive = <100>;
> > > + polling-delay = <0>;
> > > + thermal-sensors = <&pmm8654au_1_temp_alarm>;
> > > +
> > > + trips {
> > > + trip0 {
> > > + temperature = <105000>;
> > > + hysteresis = <0>;
> > > + type = "passive";
> > > + };
> > > +
> > > + trip1 {
> > > + temperature = <125000>;
> > > + hysteresis = <0>;
> > > + type = "critical";
> > > + };
> > > + };
> > > + };
> > > +
> > What happened to the downstream _2 (pmic@2) one and _4 (pmic@6)?
> >
> > Konrad
> >
> > > + pmm8654au_3_thermal: pm8775-3-thermal {
> > > + polling-delay-passive = <100>;
> > > + polling-delay = <0>;
> > > + thermal-sensors = <&pmm8654au_3_temp_alarm>;
> > > +
> > > + trips {
> > > + trip0 {
> > > + temperature = <105000>;
> > > + hysteresis = <0>;
> > > + type = "passive";
> > > + };
> > > +
> > > + trip1 {
> > > + temperature = <125000>;
> > > + hysteresis = <0>;
> > > + type = "critical";
> > > + };
> > > + };
> > > + };
> > > + };
> > > +};
> > > +
> > > &spmi_bus {
> > > pmm8654au_0: pmic@0 {
> > > compatible = "qcom,pmm8654au", "qcom,spmi-pmic";
> > > @@ -41,6 +85,13 @@ pmm8654au_1: pmic@2 {
> > > reg = <0x2 SPMI_USID>;
> > > #address-cells = <1>;
> > > #size-cells = <0>;
> > > +
> > > + pmm8654au_1_temp_alarm: temp-alarm@a00 {
> > > + compatible = "qcom,spmi-temp-alarm";
> > > + reg = <0xa00>;
> > > + interrupts-extended = <&spmi_bus 0x2 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
> > > + #thermal-sensor-cells = <0>;
> > > + };
> > > };
> > >
> > > pmm8654au_2: pmic@4 {
> > > @@ -55,5 +106,12 @@ pmm8654au_3: pmic@6 {
> > > reg = <0x6 SPMI_USID>;
> > > #address-cells = <1>;
> > > #size-cells = <0>;
> > > +
> > > + pmm8654au_3_temp_alarm: temp-alarm@a00 {
> > > + compatible = "qcom,spmi-temp-alarm";
> > > + reg = <0xa00>;
> > > + interrupts-extended = <&spmi_bus 0x6 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
> > > + #thermal-sensor-cells = <0>;
> > > + };
> > > };
> > > };
next prev parent reply other threads:[~2023-03-22 15:31 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 15:48 [PATCH v2 00/15] arm64: dts: qcom: sa8775p: add basic PMIC support Bartosz Golaszewski
2023-03-20 15:48 ` [PATCH v2 01/15] arm64: dts: qcom: sa8775p: pad reg properties to 8 digits Bartosz Golaszewski
2023-03-20 17:18 ` Konrad Dybcio
2023-03-20 15:48 ` [PATCH v2 02/15] arm64: dts: qcom: sa8775p: sort soc nodes by reg property Bartosz Golaszewski
2023-03-21 19:24 ` Konrad Dybcio
2023-03-20 15:48 ` [PATCH v2 03/15] dt-bindings: interrupt-controller: qcom-pdc: add compatible for sa8775p Bartosz Golaszewski
2023-03-20 15:48 ` [PATCH v2 04/15] arm64: dts: qcom: sa8775p: add the pdc node Bartosz Golaszewski
2023-03-20 17:21 ` Konrad Dybcio
2023-03-20 15:48 ` [PATCH v2 05/15] arm64: dts: qcom: sa8775p: add the spmi node Bartosz Golaszewski
2023-03-20 17:22 ` Konrad Dybcio
2023-03-20 15:48 ` [PATCH v2 06/15] dt-bindings: mfd: qcom,spmi-pmic: add compatible for pmm8654au Bartosz Golaszewski
2023-03-20 15:48 ` [PATCH v2 07/15] arm64: dts: qcom: sa8775p: add support for the on-board PMICs Bartosz Golaszewski
2023-03-20 17:29 ` Konrad Dybcio
2023-03-20 15:48 ` [PATCH v2 08/15] arm64: dts: qcom: sa8775p-ride: enable PMIC support Bartosz Golaszewski
2023-03-20 17:22 ` Konrad Dybcio
2023-03-20 17:30 ` Konrad Dybcio
2023-03-20 15:48 ` [PATCH v2 09/15] arm64: dts: qcom: sa8775p: add the Power On device node Bartosz Golaszewski
2023-03-20 17:23 ` Konrad Dybcio
2023-03-20 17:24 ` Konrad Dybcio
2023-03-21 14:17 ` Bartosz Golaszewski
2023-03-20 15:48 ` [PATCH v2 10/15] arm64: dts: qcom: sa8775p: pmic: add the power key Bartosz Golaszewski
2023-03-20 17:25 ` Konrad Dybcio
2023-03-20 15:48 ` [PATCH v2 11/15] arm64: dts: qcom: sa8775p: pmic: add support for the pmm8654 RESIN input Bartosz Golaszewski
2023-03-20 17:25 ` Konrad Dybcio
2023-03-20 15:48 ` [PATCH v2 12/15] arm64: dts: qcom: sa8775p: pmic: add thermal zones Bartosz Golaszewski
2023-03-20 17:28 ` Konrad Dybcio
2023-03-22 2:50 ` Bjorn Andersson
2023-03-22 15:30 ` Bartosz Golaszewski [this message]
2023-03-20 15:48 ` [PATCH v2 13/15] dt-bindings: pinctrl: qcom,pmic-gpio: add compatible for pmm8654au-gpio Bartosz Golaszewski
2023-03-20 15:48 ` [PATCH v2 14/15] pinctrl: qcom: spmi-gpio: add support " Bartosz Golaszewski
2023-03-20 17:28 ` Konrad Dybcio
2023-03-20 15:48 ` [PATCH v2 15/15] arm64: dts: qcom: sa8775p: add PMIC GPIO controller nodes Bartosz Golaszewski
2023-03-20 17:29 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MeVaMaQMsLUPH0QDjuOBt3TjVofbj7SgA5zMg3sQGBh=w@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).