From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: Wren Turkal <wt@penguintechs.org>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Zijun Hu <quic_zijuhu@quicinc.com>,
Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get_optional()
Date: Wed, 24 Apr 2024 14:23:55 +0200 [thread overview]
Message-ID: <CAMRc=MeZh6YugXtDeF=nuwmpW5qvmHLt+g6S3Guoome7mz2xyA@mail.gmail.com> (raw)
In-Reply-To: <CACMJSeunUaj0cxLaN4MpFmX5vTOx_vnWjBN4Y2FavdQoQxFRkg@mail.gmail.com>
On Wed, Apr 24, 2024 at 2:20 PM Bartosz Golaszewski
<bartosz.golaszewski@linaro.org> wrote:
>
> On Wed, 24 Apr 2024 at 14:17, Wren Turkal <wt@penguintechs.org> wrote:
> >
> > On 4/24/24 4:56 AM, Bartosz Golaszewski wrote:
> > > On Wed, Apr 24, 2024 at 1:53 PM Wren Turkal <wt@penguintechs.org> wrote:
> > >>
> > >> On 4/24/24 4:16 AM, Wren Turkal wrote:
> > >>> On 4/24/24 2:04 AM, Bartosz Golaszewski wrote:
> > >>>> On Wed, 24 Apr 2024 07:07:05 +0200, Wren Turkal<wt@penguintechs.org>
> > >>>> said:
> > >>>>> On 4/22/24 6:00 AM, Bartosz Golaszewski wrote:
> > >>>>>> From: Bartosz Golaszewski<bartosz.golaszewski@linaro.org>
> > >>>>>>
> > >>>>>> Any return value from gpiod_get_optional() other than a pointer to a
> > >>>>>> GPIO descriptor or a NULL-pointer is an error and the driver should
> > >>>>>> abort probing. That being said: commit 56d074d26c58 ("Bluetooth:
> > >>>>>> hci_qca:
> > >>>>>> don't use IS_ERR_OR_NULL() with gpiod_get_optional()") no longer sets
> > >>>>>> power_ctrl_enabled on NULL-pointer returned by
> > >>>>>> devm_gpiod_get_optional(). Restore this behavior but bail-out on
> > >>>>>> errors.
> > >>>>> Nack. This patch does fixes neither the disable/re-enable problem nor
> > >>>>> the warm boot problem.
> > >>>>>
> > >>>>> Zijun replied to this patch also with what I think is the proper
> > >>>>> reasoning for why it doesn't fix my setup.
> > >>>>>
> > >>>> Indeed, I only addressed a single issue here and not the code under the
> > >>>> default: label of the switch case. Sorry.
> > >>>>
> > >>>> Could you give the following diff a try?
> > >>>
> > >>> I had a feeling that was what was going on. I'll give the patch a shot.
> > >>>
> > >>> wt
> > >>
> > >> Considering this patch is basically equivalent to patch 1/2 from Zijun,
> > >> I am not surprised that is works similarly. I.e. on a cold boot, I can
> > >> disable/re-enable bluetooth as many time as I want.
> > >>
> > >
> > > Zijun didn't bail out on errors which is the issue the original patch
> > > tried to address and this one preserves.
> > >
> > >> However, since this patch doesn't include the quirk fix from Zijun's
> > >> patchset (patch 2/2), bluetooth fails to work after a warm boot.
> > >>
> > >
> > > That's OK, we have the first part right. Let's now see if we can reuse
> > > patch 2/2 from Zijun.
> >
> > I'm compiling it right now. Be back soon.
> >
>
> Well I doubt it's correct as it removed Krzysztof's fix which looks
> right. If I were to guess I'd say we need some mix of both.
>
> Bart
>
Anyway, these are two separate issues. Let me send a v2 of this one to
address at least one of them. I think Krzysztof will be better at
fixing the other one as it's his patch that caused the second
regression.
Bart
next prev parent reply other threads:[~2024-04-24 12:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 13:00 [PATCH] Bluetooth: qca: set power_ctrl_enabled on NULL returned by gpiod_get_optional() Bartosz Golaszewski
2024-04-24 4:05 ` Krzysztof Kozlowski
2024-04-24 4:55 ` quic_zijuhu
2024-04-24 5:07 ` Wren Turkal
2024-04-24 9:04 ` Bartosz Golaszewski
2024-04-24 9:32 ` quic_zijuhu
2024-04-24 9:50 ` Krzysztof Kozlowski
2024-04-24 11:16 ` Wren Turkal
2024-04-24 11:53 ` Wren Turkal
2024-04-24 11:56 ` Bartosz Golaszewski
2024-04-24 12:09 ` Wren Turkal
2024-04-24 12:17 ` Wren Turkal
2024-04-24 12:20 ` Bartosz Golaszewski
2024-04-24 12:23 ` Bartosz Golaszewski [this message]
2024-04-24 12:24 ` Wren Turkal
2024-04-24 12:27 ` Bartosz Golaszewski
2024-04-24 12:30 ` Wren Turkal
2024-04-24 12:57 ` Bartosz Golaszewski
2024-04-24 12:57 ` Wren Turkal
2024-04-24 13:12 ` quic_zijuhu
2024-04-24 13:26 ` Wren Turkal
2024-04-24 13:30 ` quic_zijuhu
2024-04-24 22:09 ` Wren Turkal
2024-04-24 13:53 ` Bartosz Golaszewski
2024-04-24 22:17 ` Wren Turkal
2024-04-24 23:35 ` quic_zijuhu
2024-04-25 2:34 ` Wren Turkal
2024-04-24 11:25 ` Wren Turkal
2024-04-24 11:53 ` Bartosz Golaszewski
2024-04-24 11:59 ` Wren Turkal
2024-04-24 12:01 ` Bartosz Golaszewski
2024-04-24 12:05 ` Wren Turkal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MeZh6YugXtDeF=nuwmpW5qvmHLt+g6S3Guoome7mz2xyA@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=bartosz.golaszewski@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=quic_zijuhu@quicinc.com \
--cc=wt@penguintechs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).