From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Johan Hovold <johan@kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/2] gpiolib: check the 'ngpios' property in core gpiolib code
Date: Thu, 2 Dec 2021 16:48:20 +0100 [thread overview]
Message-ID: <CAMRc=MfYKscNMbGqwj6os_SmXhBBqUMWJCwu0K0xO+VZ0vvNfA@mail.gmail.com> (raw)
In-Reply-To: <YajoPEgfTvuvjqG/@smile.fi.intel.com>
On Thu, Dec 2, 2021 at 4:38 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Thu, Dec 02, 2021 at 02:40:34PM +0100, Bartosz Golaszewski wrote:
> > Several drivers read the 'ngpios' device property on their own, but
> > since it's defined as a standard GPIO property in the device tree bindings
> > anyway, it's a good candidate for generalization. If the driver didn't
> > set its gc->ngpio, try to read the 'ngpios' property from the GPIO
> > device's firmware node before bailing out.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> One nit-pick below (you may amend it when applying)
>
> > Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > v1 -> v2:
> > - use device_property_read_u32() instead of fwnode_property_read_u32()
> > - reverse the error check logic
> >
> > v2 -> v3:
> > - don't shadow errors other than -ENODATA in device_property_read_u32()
> >
> > v3 -> v4:
> > - also make sure we return -EINVAL when the device 'ngpios' property is
> > set to 0 (thanks Andy!)
> >
> > drivers/gpio/gpiolib.c | 21 +++++++++++++++++++++
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> > index ede8b8a7aa18..bd9b8cb53476 100644
> > --- a/drivers/gpio/gpiolib.c
> > +++ b/drivers/gpio/gpiolib.c
> > @@ -599,6 +599,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
> > int base = gc->base;
> > unsigned int i;
> > int ret = 0;
> > + u32 ngpios;
> >
> > /*
> > * First: allocate and populate the internal stat container, and
> > @@ -646,6 +647,26 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
> > goto err_free_dev_name;
> > }
> >
> > + /*
> > + * Try the device properties if the driver didn't supply the number
> > + * of GPIO lines.
> > + */
> > + if (gc->ngpio == 0) {
> > + ret = device_property_read_u32(&gdev->dev, "ngpios", &ngpios);
> > + if (ret == -ENODATA)
> > + /*
> > + * -ENODATA means that there is no property found and
> > + * we want to issue the error message to the user.
> > + * Besides that, we want to return different error code
> > + * to state that supplied value is not valid.
>
> > + * */
>
> First '* ' is not needed.
>
I'll fix it when applying.
Bart
next prev parent reply other threads:[~2021-12-02 15:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 13:40 [PATCH v4 1/2] gpiolib: improve coding style for local variables Bartosz Golaszewski
2021-12-02 13:40 ` [PATCH v4 2/2] gpiolib: check the 'ngpios' property in core gpiolib code Bartosz Golaszewski
2021-12-02 15:37 ` Andy Shevchenko
2021-12-02 15:48 ` Bartosz Golaszewski [this message]
2021-12-06 15:01 ` Bartosz Golaszewski
2021-12-06 15:01 ` [PATCH v4 1/2] gpiolib: improve coding style for local variables Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MfYKscNMbGqwj6os_SmXhBBqUMWJCwu0K0xO+VZ0vvNfA@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).