* [PATCH v2 1/1] gpiolib: Do not unexport GPIO on freeing
@ 2023-06-05 12:58 Andy Shevchenko
2023-06-09 7:23 ` Linus Walleij
2023-06-09 9:38 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2023-06-05 12:58 UTC (permalink / raw)
To: Bartosz Golaszewski, Andy Shevchenko, linux-gpio, linux-kernel
Cc: Linus Walleij, Bartosz Golaszewski
Since the legacy exporting is gone with 2f804aca4832 ("gpiolib:
Kill unused GPIOF_EXPORT and Co") there is no need to unexport
GPIO on freeing. Remove that call.
Note, the other users of this functionality do that explicitly,
except one SH and one OMAP boardfile which don't free GPIO anyways,
so it is safe to drop the call.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: mentioned OMAP boardfile as well
drivers/gpio/gpiolib.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index a8da38ee721a..7a9c9934365a 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -2117,8 +2117,6 @@ static bool gpiod_free_commit(struct gpio_desc *desc)
might_sleep();
- gpiod_unexport(desc);
-
spin_lock_irqsave(&gpio_lock, flags);
gc = desc->gdev->chip;
--
2.40.0.1.gaa8946217a0b
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] gpiolib: Do not unexport GPIO on freeing
2023-06-05 12:58 [PATCH v2 1/1] gpiolib: Do not unexport GPIO on freeing Andy Shevchenko
@ 2023-06-09 7:23 ` Linus Walleij
2023-06-09 9:38 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2023-06-09 7:23 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Bartosz Golaszewski, linux-gpio, linux-kernel, Bartosz Golaszewski
On Mon, Jun 5, 2023 at 2:58 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Since the legacy exporting is gone with 2f804aca4832 ("gpiolib:
> Kill unused GPIOF_EXPORT and Co") there is no need to unexport
> GPIO on freeing. Remove that call.
>
> Note, the other users of this functionality do that explicitly,
> except one SH and one OMAP boardfile which don't free GPIO anyways,
> so it is safe to drop the call.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Yeah let's kill this off it is just annoying.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] gpiolib: Do not unexport GPIO on freeing
2023-06-05 12:58 [PATCH v2 1/1] gpiolib: Do not unexport GPIO on freeing Andy Shevchenko
2023-06-09 7:23 ` Linus Walleij
@ 2023-06-09 9:38 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2023-06-09 9:38 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Bartosz Golaszewski, linux-gpio, linux-kernel, Linus Walleij
On Mon, Jun 5, 2023 at 2:58 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Since the legacy exporting is gone with 2f804aca4832 ("gpiolib:
> Kill unused GPIOF_EXPORT and Co") there is no need to unexport
> GPIO on freeing. Remove that call.
>
> Note, the other users of this functionality do that explicitly,
> except one SH and one OMAP boardfile which don't free GPIO anyways,
> so it is safe to drop the call.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: mentioned OMAP boardfile as well
> drivers/gpio/gpiolib.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index a8da38ee721a..7a9c9934365a 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -2117,8 +2117,6 @@ static bool gpiod_free_commit(struct gpio_desc *desc)
>
> might_sleep();
>
> - gpiod_unexport(desc);
> -
> spin_lock_irqsave(&gpio_lock, flags);
>
> gc = desc->gdev->chip;
> --
> 2.40.0.1.gaa8946217a0b
>
Ah, you already sent a v2. I applied this one.
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-09 9:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-05 12:58 [PATCH v2 1/1] gpiolib: Do not unexport GPIO on freeing Andy Shevchenko
2023-06-09 7:23 ` Linus Walleij
2023-06-09 9:38 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).