* [PATCH] hid: asus: ROG NKey: Ignore portion of 0x5a report
@ 2022-03-14 16:15 Josh Kilmer
2022-04-11 15:00 ` Jiri Kosina
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Josh Kilmer @ 2022-03-14 16:15 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-input, Jiri Kosina, Benjamin Tissoires, Josh Kilmer
On an Asus G513QY, of the 5 bytes in a 0x5a report, only the first byte
is a meaningful keycode. The other bytes are zeroed out or hold garbage
from the last packet sent to the keyboard.
This patch fixes up the report descriptor for this event so that the
general hid code will only process 1 byte for keycodes, avoiding
spurious key events and unmapped Asus vendor usagepage code warnings.
Signed-off-by: Josh Kilmer <srjek2@gmail.com>
---
drivers/hid/hid-asus.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 08c9a9a60ae4..73fb9fc0701c 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -1212,6 +1212,14 @@ static __u8 *asus_report_fixup(struct
hid_device *hdev, __u8 *rdesc,
rdesc = new_rdesc;
}
+ if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD &&
+ *rsize == 331 && rdesc[190] == 0x85 && rdesc[191] == 0x5a &&
+ rdesc[204] == 0x95 && rdesc[205] == 0x05) {
+ hid_info(hdev, "Fixing up Asus N-KEY keyb report descriptor\n");
+ // On the 0x5A input report, change count from 5 to 1
+ rdesc[205] = 0x01;
+ }
+
return rdesc;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] hid: asus: ROG NKey: Ignore portion of 0x5a report
2022-03-14 16:15 [PATCH] hid: asus: ROG NKey: Ignore portion of 0x5a report Josh Kilmer
@ 2022-04-11 15:00 ` Jiri Kosina
2022-04-15 22:29 ` [PATCH v2] " Josh Kilmer
2022-07-28 17:51 ` [PATCH v2 RESEND] " Josh Kilmer
2 siblings, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2022-04-11 15:00 UTC (permalink / raw)
To: Josh Kilmer; +Cc: linux-kernel, linux-input, Benjamin Tissoires
On Mon, 14 Mar 2022, Josh Kilmer wrote:
> On an Asus G513QY, of the 5 bytes in a 0x5a report, only the first byte
> is a meaningful keycode. The other bytes are zeroed out or hold garbage
> from the last packet sent to the keyboard.
>
> This patch fixes up the report descriptor for this event so that the
> general hid code will only process 1 byte for keycodes, avoiding
> spurious key events and unmapped Asus vendor usagepage code warnings.
>
> Signed-off-by: Josh Kilmer <srjek2@gmail.com>
Hi Josh,
thanks for the patch.
A couple remarks:
> ---
> drivers/hid/hid-asus.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> index 08c9a9a60ae4..73fb9fc0701c 100644
> --- a/drivers/hid/hid-asus.c
> +++ b/drivers/hid/hid-asus.c
> @@ -1212,6 +1212,14 @@ static __u8 *asus_report_fixup(struct
> hid_device *hdev, __u8 *rdesc,
> rdesc = new_rdesc;
> }
>
> + if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD &&
> + *rsize == 331 && rdesc[190] == 0x85 && rdesc[191] == 0x5a &&
> + rdesc[204] == 0x95 && rdesc[205] == 0x05) {
> + hid_info(hdev, "Fixing up Asus N-KEY keyb report descriptor\n");
> + // On the 0x5A input report, change count from 5 to 1
> + rdesc[205] = 0x01;
> + }
- your mail client whitespace-damaged the patch, so it can't be applied;
could you please fix that and resend?
- the comment above is (a) using non-standard kernel commenting style, and
quite honestly (b) seems a little bit superfluous
Could you please fix that up and resend?
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] hid: asus: ROG NKey: Ignore portion of 0x5a report
2022-03-14 16:15 [PATCH] hid: asus: ROG NKey: Ignore portion of 0x5a report Josh Kilmer
2022-04-11 15:00 ` Jiri Kosina
@ 2022-04-15 22:29 ` Josh Kilmer
2022-07-28 17:51 ` [PATCH v2 RESEND] " Josh Kilmer
2 siblings, 0 replies; 5+ messages in thread
From: Josh Kilmer @ 2022-04-15 22:29 UTC (permalink / raw)
To: Josh Kilmer; +Cc: linux-kernel, linux-input, Jiri Kosina, Benjamin Tissoires
On an Asus G513QY, of the 5 bytes in a 0x5a report, only the first byte
is a meaningful keycode. The other bytes are zeroed out or hold garbage
from the last packet sent to the keyboard.
This patch fixes up the report descriptor for this event so that the
general hid code will only process 1 byte for keycodes, avoiding
spurious key events and unmapped Asus vendor usagepage code warnings.
Signed-off-by: Josh Kilmer <srjek2@gmail.com>
---
drivers/hid/hid-asus.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 08c9a9a60ae4..b59c3dafa6a4 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -1212,6 +1212,13 @@ static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc,
rdesc = new_rdesc;
}
+ if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD &&
+ *rsize == 331 && rdesc[190] == 0x85 && rdesc[191] == 0x5a &&
+ rdesc[204] == 0x95 && rdesc[205] == 0x05) {
+ hid_info(hdev, "Fixing up Asus N-KEY keyb report descriptor\n");
+ rdesc[205] = 0x01;
+ }
+
return rdesc;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 RESEND] hid: asus: ROG NKey: Ignore portion of 0x5a report
2022-03-14 16:15 [PATCH] hid: asus: ROG NKey: Ignore portion of 0x5a report Josh Kilmer
2022-04-11 15:00 ` Jiri Kosina
2022-04-15 22:29 ` [PATCH v2] " Josh Kilmer
@ 2022-07-28 17:51 ` Josh Kilmer
2022-08-25 9:31 ` Jiri Kosina
2 siblings, 1 reply; 5+ messages in thread
From: Josh Kilmer @ 2022-07-28 17:51 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-input, Benjamin Tissoires, Jiri Kosina, Josh Kilmer
On an Asus G513QY, of the 5 bytes in a 0x5a report, only the first byte
is a meaningful keycode. The other bytes are zeroed out or hold garbage
from the last packet sent to the keyboard.
This patch fixes up the report descriptor for this event so that the
general hid code will only process 1 byte for keycodes, avoiding
spurious key events and unmapped Asus vendor usagepage code warnings.
Signed-off-by: Josh Kilmer <srjek2@gmail.com>
---
drivers/hid/hid-asus.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 08c9a9a60ae4..b59c3dafa6a4 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -1212,6 +1212,13 @@ static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc,
rdesc = new_rdesc;
}
+ if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD &&
+ *rsize == 331 && rdesc[190] == 0x85 && rdesc[191] == 0x5a &&
+ rdesc[204] == 0x95 && rdesc[205] == 0x05) {
+ hid_info(hdev, "Fixing up Asus N-KEY keyb report descriptor\n");
+ rdesc[205] = 0x01;
+ }
+
return rdesc;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 RESEND] hid: asus: ROG NKey: Ignore portion of 0x5a report
2022-07-28 17:51 ` [PATCH v2 RESEND] " Josh Kilmer
@ 2022-08-25 9:31 ` Jiri Kosina
0 siblings, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2022-08-25 9:31 UTC (permalink / raw)
To: Josh Kilmer; +Cc: linux-kernel, linux-input, Benjamin Tissoires
On Thu, 28 Jul 2022, Josh Kilmer wrote:
> On an Asus G513QY, of the 5 bytes in a 0x5a report, only the first byte
> is a meaningful keycode. The other bytes are zeroed out or hold garbage
> from the last packet sent to the keyboard.
>
> This patch fixes up the report descriptor for this event so that the
> general hid code will only process 1 byte for keycodes, avoiding
> spurious key events and unmapped Asus vendor usagepage code warnings.
>
> Signed-off-by: Josh Kilmer <srjek2@gmail.com>
> ---
> drivers/hid/hid-asus.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> index 08c9a9a60ae4..b59c3dafa6a4 100644
> --- a/drivers/hid/hid-asus.c
> +++ b/drivers/hid/hid-asus.c
> @@ -1212,6 +1212,13 @@ static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc,
> rdesc = new_rdesc;
> }
>
> + if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD &&
> + *rsize == 331 && rdesc[190] == 0x85 && rdesc[191] == 0x5a &&
> + rdesc[204] == 0x95 && rdesc[205] == 0x05) {
> + hid_info(hdev, "Fixing up Asus N-KEY keyb report descriptor\n");
> + rdesc[205] = 0x01;
> + }
> +
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-08-25 9:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-14 16:15 [PATCH] hid: asus: ROG NKey: Ignore portion of 0x5a report Josh Kilmer
2022-04-11 15:00 ` Jiri Kosina
2022-04-15 22:29 ` [PATCH v2] " Josh Kilmer
2022-07-28 17:51 ` [PATCH v2 RESEND] " Josh Kilmer
2022-08-25 9:31 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).