* [PATCH] mm/hmm.c: remove unneeded local variable ret
@ 2022-01-25 12:48 Miaohe Lin
2022-01-25 14:24 ` Muchun Song
0 siblings, 1 reply; 2+ messages in thread
From: Miaohe Lin @ 2022-01-25 12:48 UTC (permalink / raw)
To: akpm, jglisse; +Cc: linux-mm, linux-kernel, linmiaohe
The local variable ret is always 0. Remove it to make code more tight.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/hmm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/hmm.c b/mm/hmm.c
index bd56641c79d4..af71aac3140e 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -417,7 +417,6 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end,
struct hmm_range *range = hmm_vma_walk->range;
unsigned long addr = start;
pud_t pud;
- int ret = 0;
spinlock_t *ptl = pud_trans_huge_lock(pudp, walk->vma);
if (!ptl)
@@ -466,7 +465,7 @@ static int hmm_vma_walk_pud(pud_t *pudp, unsigned long start, unsigned long end,
out_unlock:
spin_unlock(ptl);
- return ret;
+ return 0;
}
#else
#define hmm_vma_walk_pud NULL
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/hmm.c: remove unneeded local variable ret
2022-01-25 12:48 [PATCH] mm/hmm.c: remove unneeded local variable ret Miaohe Lin
@ 2022-01-25 14:24 ` Muchun Song
0 siblings, 0 replies; 2+ messages in thread
From: Muchun Song @ 2022-01-25 14:24 UTC (permalink / raw)
To: Miaohe Lin; +Cc: Andrew Morton, jglisse, Linux Memory Management List, LKML
On Tue, Jan 25, 2022 at 8:52 PM Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> The local variable ret is always 0. Remove it to make code more tight.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-25 14:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25 12:48 [PATCH] mm/hmm.c: remove unneeded local variable ret Miaohe Lin
2022-01-25 14:24 ` Muchun Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).