* [PATCH net-next] net: sched: choke: Remove unused inline function choke_set_classid
@ 2020-05-05 8:47 YueHaibing
2020-05-05 18:22 ` Cong Wang
2020-05-05 19:46 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2020-05-05 8:47 UTC (permalink / raw)
To: jhs, xiyou.wangcong, jiri, davem, kuba; +Cc: netdev, linux-kernel, YueHaibing
There's no callers in-tree anymore since commit 5952fde10c35 ("net:
sched: choke: remove dead filter classify code")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/sched/sch_choke.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/net/sched/sch_choke.c b/net/sched/sch_choke.c
index a36974e9c601..2d350c734375 100644
--- a/net/sched/sch_choke.c
+++ b/net/sched/sch_choke.c
@@ -142,11 +142,6 @@ static inline struct choke_skb_cb *choke_skb_cb(const struct sk_buff *skb)
return (struct choke_skb_cb *)qdisc_skb_cb(skb)->data;
}
-static inline void choke_set_classid(struct sk_buff *skb, u16 classid)
-{
- choke_skb_cb(skb)->classid = classid;
-}
-
/*
* Compare flow of two packets
* Returns true only if source and destination address and port match.
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: sched: choke: Remove unused inline function choke_set_classid
2020-05-05 8:47 [PATCH net-next] net: sched: choke: Remove unused inline function choke_set_classid YueHaibing
@ 2020-05-05 18:22 ` Cong Wang
2020-05-05 19:46 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Cong Wang @ 2020-05-05 18:22 UTC (permalink / raw)
To: YueHaibing
Cc: Jamal Hadi Salim, Jiri Pirko, David Miller, Jakub Kicinski,
Linux Kernel Network Developers, LKML
On Tue, May 5, 2020 at 1:49 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> There's no callers in-tree anymore since commit 5952fde10c35 ("net:
> sched: choke: remove dead filter classify code")
While you are at this, please also remove classid from
struct choke_skb_cb.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: sched: choke: Remove unused inline function choke_set_classid
2020-05-05 8:47 [PATCH net-next] net: sched: choke: Remove unused inline function choke_set_classid YueHaibing
2020-05-05 18:22 ` Cong Wang
@ 2020-05-05 19:46 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-05-05 19:46 UTC (permalink / raw)
To: yuehaibing; +Cc: jhs, xiyou.wangcong, jiri, kuba, netdev, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 5 May 2020 16:47:36 +0800
> There's no callers in-tree anymore since commit 5952fde10c35 ("net:
> sched: choke: remove dead filter classify code")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-05 19:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-05 8:47 [PATCH net-next] net: sched: choke: Remove unused inline function choke_set_classid YueHaibing
2020-05-05 18:22 ` Cong Wang
2020-05-05 19:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).