From: Peter Geis <pgwipeout@gmail.com>
To: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/9] arm64: dts: rockchip: add rk3568 tsadc nodes
Date: Mon, 17 Jan 2022 08:49:50 -0500 [thread overview]
Message-ID: <CAMdYzYo2gkNvNYjU9_kc4cTwNBFU+kg3bRwaS3yCCAsMdo-Tow@mail.gmail.com> (raw)
In-Reply-To: <C3AE0A81-A829-4241-A65E-EB28825E3C33@gmail.com>
On Mon, Jan 17, 2022 at 3:43 AM Piotr Oniszczuk
<piotr.oniszczuk@gmail.com> wrote:
>
>
>
> > Wiadomość napisana przez Peter Geis <pgwipeout@gmail.com> w dniu 28.07.2021, o godz. 15:55:
> >
> > Add the thermal and tsadc nodes to the rk3568 device tree.
> > There are two sensors, one for the cpu, one for the gpu.
> >
> > Signed-off-by: Peter Geis <pgwipeout@gmail.com>
> > ---
> > .../boot/dts/rockchip/rk3568-pinctrl.dtsi | 6 ++
> > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 71 +++++++++++++++++++
> > 2 files changed, 77 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi b/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi
> > index a588ca95ace2..b464c7bda1f7 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3568-pinctrl.dtsi
> > @@ -2420,6 +2420,12 @@ spi3m1_cs1: spi3m1-cs1 {
> > };
> >
> > tsadc {
> > + /omit-if-no-ref/
> > + tsadc_gpio: tsadc-gpio {
> > + rockchip,pins =
> > + <0 RK_PA1 0 &pcfg_pull_none>;
> > + };
> > +
> > /omit-if-no-ref/
> > tsadcm0_shut: tsadcm0-shut {
> > rockchip,pins =
> > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> > index 77c679304916..0905fac0726a 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> > @@ -51,6 +51,7 @@ cpu0: cpu@0 {
> > compatible = "arm,cortex-a55";
> > reg = <0x0 0x0>;
> > clocks = <&scmi_clk 0>;
> > + #cooling-cells = <2>;
> > enable-method = "psci";
> > operating-points-v2 = <&cpu0_opp_table>;
> > };
> > @@ -59,6 +60,7 @@ cpu1: cpu@100 {
> > device_type = "cpu";
> > compatible = "arm,cortex-a55";
> > reg = <0x0 0x100>;
> > + #cooling-cells = <2>;
> > enable-method = "psci";
> > operating-points-v2 = <&cpu0_opp_table>;
> > };
> > @@ -67,6 +69,7 @@ cpu2: cpu@200 {
> > device_type = "cpu";
> > compatible = "arm,cortex-a55";
> > reg = <0x0 0x200>;
> > + #cooling-cells = <2>;
> > enable-method = "psci";
> > operating-points-v2 = <&cpu0_opp_table>;
> > };
> > @@ -75,6 +78,7 @@ cpu3: cpu@300 {
> > device_type = "cpu";
> > compatible = "arm,cortex-a55";
> > reg = <0x0 0x300>;
> > + #cooling-cells = <2>;
> > enable-method = "psci";
> > operating-points-v2 = <&cpu0_opp_table>;
> > };
> > @@ -774,6 +778,73 @@ uart9: serial@fe6d0000 {
> > status = "disabled";
> > };
> >
> > + thermal_zones: thermal-zones {
> > + cpu_thermal: cpu-thermal {
> > + polling-delay-passive = <100>;
> > + polling-delay = <1000>;
> > +
> > + thermal-sensors = <&tsadc 0>;
> > +
> > + trips {
> > + cpu_alert0: cpu_alert0 {
> > + temperature = <70000>;
> > + hysteresis = <2000>;
> > + type = "passive";
> > + };
> > + cpu_alert1: cpu_alert1 {
> > + temperature = <75000>;
> > + hysteresis = <2000>;
> > + type = "passive";
> > + };
> > + cpu_crit: cpu_crit {
> > + temperature = <95000>;
> > + hysteresis = <2000>;
> > + type = "critical";
> > + };
> > + };
> > +
> > + cooling-maps {
> > + map0 {
> > + trip = <&cpu_alert0>;
> > + cooling-device =
> > + <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > + };
> > + };
> > + };
> > +
> > + gpu_thermal: gpu-thermal {
> > + polling-delay-passive = <20>; /* milliseconds */
> > + polling-delay = <1000>; /* milliseconds */
> > +
> > + thermal-sensors = <&tsadc 1>;
> > + };
> > + };
> > +
> > + tsadc: tsadc@fe710000 {
> > + compatible = "rockchip,rk3568-tsadc";
> > + reg = <0x0 0xfe710000 0x0 0x100>;
> > + interrupts = <GIC_SPI 115 IRQ_TYPE_LEVEL_HIGH>;
> > + assigned-clocks = <&cru CLK_TSADC_TSEN>, <&cru CLK_TSADC>;
> > + assigned-clock-rates = <17000000>, <700000>;
> > + clocks = <&cru CLK_TSADC>, <&cru PCLK_TSADC>;
> > + clock-names = "tsadc", "apb_pclk";
> > + resets = <&cru SRST_TSADC>, <&cru SRST_P_TSADC>,
> > + <&cru SRST_TSADCPHY>;
> > + reset-names = "tsadc", "tsadc-apb", "tsadc-phy";
> > + rockchip,grf = <&grf>;
> > + rockchip,hw-tshut-temp = <95000>;
> > + rockchip,hw-tshut-mode = <1>; /* tshut mode 0:CRU 1:GPIO */
> > + rockchip,hw-tshut-polarity = <0>; /* tshut polarity 0:LOW 1:HIGH */
> > + pinctrl-names = "gpio", "otpout";
> > + pinctrl-0 = <&tsadc_gpio>;
> > + pinctrl-1 = <&tsadc_shutorg>;
> > + #thermal-sensor-cells = <1>;
> > + status = "disabled";
> > + };
> > +
> > saradc: saradc@fe720000 {
> > compatible = "rockchip,rk3568-saradc", "rockchip,rk3399-saradc";
> > reg = <0x0 0xfe720000 0x0 0x100>;
> > --
> > 2.25.1
> >
> >
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip
>
> Peter,
>
> I'm trying to use this series to get thermal on rk3566 based tvbox (x96-x6).
> Driver loads but i'm getting following error:
>
> [ 132.873979] rockchip-thermal fe710000.tsadc: failed to register sensor 0: -517
> [ 132.874650] rockchip-thermal fe710000.tsadc: failed to register sensor[0] : error = -517
>
> Maybe you have some hints here?
Error -517 means -EPROBE_DEFER, a device it relies on hasn't probed.
TSADC doesn't directly rely on anything that shouldn't already be
enabled. (Pinctrl, clocks, and grf all break a lot more than tsadc if
disabled)
Does your kernel config have all of the rockchip elements enabled?
>
>
next prev parent reply other threads:[~2022-01-17 13:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 13:55 [PATCH 0/9] fixes and enablement for rk356x Peter Geis
2021-07-28 13:55 ` [PATCH 1/9] dt-bindings: gpio: rockchip,gpio-bank: increase max clocks Peter Geis
2021-07-28 14:10 ` Heiko Stübner
2021-07-28 15:24 ` Peter Geis
2021-07-28 15:51 ` Rob Herring
2021-07-28 13:55 ` [PATCH 2/9] arm64: dts: rockchip: fix rk3568 mbi-alias Peter Geis
2021-07-28 13:55 ` [PATCH 3/9] arm64: dts: rockchip: add rk356x gpio debounce clocks Peter Geis
2021-07-28 13:55 ` [PATCH 4/9] arm64: dts: rockchip: add rk356x gmac1 node Peter Geis
2021-07-28 14:21 ` Heiko Stübner
2021-07-28 14:32 ` Peter Geis
2021-07-28 13:55 ` [PATCH 5/9] arm64: dts: rockchip: add rk3568 tsadc nodes Peter Geis
2021-07-28 14:46 ` Heiko Stübner
2021-07-28 15:14 ` Peter Geis
2021-07-28 15:31 ` Heiko Stübner
2021-07-28 15:33 ` Johan Jonker
2022-01-17 8:43 ` Piotr Oniszczuk
2022-01-17 13:49 ` Peter Geis [this message]
2022-01-17 14:13 ` Piotr Oniszczuk
2022-01-17 14:38 ` Peter Geis
2022-01-17 14:53 ` Piotr Oniszczuk
2021-07-28 13:55 ` [PATCH 6/9] arm64: dts: rockchip: add missing rk3568 cru phandles Peter Geis
2021-07-28 14:06 ` Heiko Stübner
2021-07-28 14:18 ` Peter Geis
2021-07-28 14:41 ` Heiko Stübner
2021-07-28 15:16 ` Peter Geis
2021-07-28 16:49 ` Peter Geis
2021-07-28 17:28 ` Heiko Stübner
2021-07-28 13:55 ` [PATCH 7/9] arm64: dts: rockchip: adjust rk3568 pll clocks Peter Geis
2021-07-28 14:08 ` Heiko Stübner
2021-07-28 14:24 ` Peter Geis
2021-07-28 13:55 ` [PATCH 8/9] arm64: dts: rockchip: enable gmac node on quartz64-a Peter Geis
2021-07-28 13:55 ` [PATCH 9/9] arm64: dts: rockchip: add thermal support to Quartz64 Model A Peter Geis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMdYzYo2gkNvNYjU9_kc4cTwNBFU+kg3bRwaS3yCCAsMdo-Tow@mail.gmail.com \
--to=pgwipeout@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=piotr.oniszczuk@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).