* [PATCH] arm64: dts: rockchip: Add missing rockchip,pipe-grf to rk3568 PCIe v3 PHY
@ 2022-09-26 18:35 Aurelien Jarno
2022-09-26 18:58 ` Peter Geis
0 siblings, 1 reply; 4+ messages in thread
From: Aurelien Jarno @ 2022-09-26 18:35 UTC (permalink / raw)
To: linux-kernel
Cc: Aurelien Jarno, Rob Herring, Krzysztof Kozlowski, Heiko Stuebner,
Frank Wunderlich, Peter Geis,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support
This commit fixes the error message
rockchip-snps-pcie3-phy fe8c0000.phy: failed to find rockchip,pipe_grf regmap
during boot by providing the missing rockchip,pipe-grf property.
Fixes: faedfa5b40f0 ("arm64: dts: rockchip: Add PCIe v3 nodes to rk3568")
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
arch/arm64/boot/dts/rockchip/rk3568.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
index ba67b58f05b7..8818b283ba11 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
@@ -56,6 +56,7 @@ pcie30phy: phy@fe8c0000 {
clock-names = "refclk_m", "refclk_n", "pclk";
resets = <&cru SRST_PCIE30PHY>;
reset-names = "phy";
+ rockchip,pipe-grf = <&pipegrf>;
rockchip,phy-grf = <&pcie30_phy_grf>;
status = "disabled";
};
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Add missing rockchip,pipe-grf to rk3568 PCIe v3 PHY
2022-09-26 18:35 [PATCH] arm64: dts: rockchip: Add missing rockchip,pipe-grf to rk3568 PCIe v3 PHY Aurelien Jarno
@ 2022-09-26 18:58 ` Peter Geis
2022-09-26 20:36 ` Aurelien Jarno
0 siblings, 1 reply; 4+ messages in thread
From: Peter Geis @ 2022-09-26 18:58 UTC (permalink / raw)
To: Aurelien Jarno
Cc: linux-kernel, Rob Herring, Krzysztof Kozlowski, Heiko Stuebner,
Frank Wunderlich,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support
On Mon, Sep 26, 2022 at 2:35 PM Aurelien Jarno <aurelien@aurel32.net> wrote:
>
> This commit fixes the error message
>
> rockchip-snps-pcie3-phy fe8c0000.phy: failed to find rockchip,pipe_grf regmap
The pipe grf only is used on the rk3588 device for this phy.
>
> during boot by providing the missing rockchip,pipe-grf property.
>
> Fixes: faedfa5b40f0 ("arm64: dts: rockchip: Add PCIe v3 nodes to rk3568")
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> arch/arm64/boot/dts/rockchip/rk3568.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> index ba67b58f05b7..8818b283ba11 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> @@ -56,6 +56,7 @@ pcie30phy: phy@fe8c0000 {
> clock-names = "refclk_m", "refclk_n", "pclk";
> resets = <&cru SRST_PCIE30PHY>;
> reset-names = "phy";
> + rockchip,pipe-grf = <&pipegrf>;
> rockchip,phy-grf = <&pcie30_phy_grf>;
> status = "disabled";
> };
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Add missing rockchip,pipe-grf to rk3568 PCIe v3 PHY
2022-09-26 18:58 ` Peter Geis
@ 2022-09-26 20:36 ` Aurelien Jarno
2022-09-26 22:34 ` Peter Geis
0 siblings, 1 reply; 4+ messages in thread
From: Aurelien Jarno @ 2022-09-26 20:36 UTC (permalink / raw)
To: Peter Geis
Cc: linux-kernel, Rob Herring, Krzysztof Kozlowski, Heiko Stuebner,
Frank Wunderlich,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support
On 2022-09-26 14:58, Peter Geis wrote:
> On Mon, Sep 26, 2022 at 2:35 PM Aurelien Jarno <aurelien@aurel32.net> wrote:
> >
> > This commit fixes the error message
> >
> > rockchip-snps-pcie3-phy fe8c0000.phy: failed to find rockchip,pipe_grf regmap
>
> The pipe grf only is used on the rk3588 device for this phy.
Ok, looking at the code in details, I confirm that. Does it mean the
change should be done at the phy driver level, to only look for
rockchip,pipe-grf on the rk3588 device?
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Add missing rockchip,pipe-grf to rk3568 PCIe v3 PHY
2022-09-26 20:36 ` Aurelien Jarno
@ 2022-09-26 22:34 ` Peter Geis
0 siblings, 0 replies; 4+ messages in thread
From: Peter Geis @ 2022-09-26 22:34 UTC (permalink / raw)
To: Peter Geis, linux-kernel, Rob Herring, Krzysztof Kozlowski,
Heiko Stuebner, Frank Wunderlich,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support
On Mon, Sep 26, 2022 at 4:36 PM Aurelien Jarno <aurelien@aurel32.net> wrote:
>
> On 2022-09-26 14:58, Peter Geis wrote:
> > On Mon, Sep 26, 2022 at 2:35 PM Aurelien Jarno <aurelien@aurel32.net> wrote:
> > >
> > > This commit fixes the error message
> > >
> > > rockchip-snps-pcie3-phy fe8c0000.phy: failed to find rockchip,pipe_grf regmap
> >
> > The pipe grf only is used on the rk3588 device for this phy.
>
> Ok, looking at the code in details, I confirm that. Does it mean the
> change should be done at the phy driver level, to only look for
> rockchip,pipe-grf on the rk3588 device?
That would be reasonable, yes.
>
> --
> Aurelien Jarno GPG: 4096R/1DDD8C9B
> aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-26 22:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 18:35 [PATCH] arm64: dts: rockchip: Add missing rockchip,pipe-grf to rk3568 PCIe v3 PHY Aurelien Jarno
2022-09-26 18:58 ` Peter Geis
2022-09-26 20:36 ` Aurelien Jarno
2022-09-26 22:34 ` Peter Geis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).