* [PATCH next] drm/gma500: remove set but not used variables 'hist_reg'
@ 2019-12-27 11:48 Chen Zhou
2020-01-08 9:12 ` Patrik Jakobsson
0 siblings, 1 reply; 2+ messages in thread
From: Chen Zhou @ 2019-12-27 11:48 UTC (permalink / raw)
To: patrik.r.jakobsson, airlied, daniel; +Cc: dri-devel, linux-kernel, chenzhou10
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/gma500/psb_irq.c: In function psb_irq_turn_off_dpst:
drivers/gpu/drm/gma500/psb_irq.c:473:6:
warning: variable hist_reg set but not used [-Wunused-but-set-variable]
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
drivers/gpu/drm/gma500/psb_irq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/psb_irq.c
index 40a37e4..91f9001 100644
--- a/drivers/gpu/drm/gma500/psb_irq.c
+++ b/drivers/gpu/drm/gma500/psb_irq.c
@@ -470,12 +470,11 @@ void psb_irq_turn_off_dpst(struct drm_device *dev)
{
struct drm_psb_private *dev_priv =
(struct drm_psb_private *) dev->dev_private;
- u32 hist_reg;
u32 pwm_reg;
if (gma_power_begin(dev, false)) {
PSB_WVDC32(0x00000000, HISTOGRAM_INT_CONTROL);
- hist_reg = PSB_RVDC32(HISTOGRAM_INT_CONTROL);
+ PSB_RVDC32(HISTOGRAM_INT_CONTROL);
psb_disable_pipestat(dev_priv, 0, PIPE_DPST_EVENT_ENABLE);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] drm/gma500: remove set but not used variables 'hist_reg'
2019-12-27 11:48 [PATCH next] drm/gma500: remove set but not used variables 'hist_reg' Chen Zhou
@ 2020-01-08 9:12 ` Patrik Jakobsson
0 siblings, 0 replies; 2+ messages in thread
From: Patrik Jakobsson @ 2020-01-08 9:12 UTC (permalink / raw)
To: Chen Zhou; +Cc: David Airlie, Daniel Vetter, dri-devel, linux-kernel
On Fri, Dec 27, 2019 at 12:52 PM Chen Zhou <chenzhou10@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/gma500/psb_irq.c: In function psb_irq_turn_off_dpst:
> drivers/gpu/drm/gma500/psb_irq.c:473:6:
> warning: variable hist_reg set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Applied to drm-misc-next
Thanks
Patrik
> ---
> drivers/gpu/drm/gma500/psb_irq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/psb_irq.c
> index 40a37e4..91f9001 100644
> --- a/drivers/gpu/drm/gma500/psb_irq.c
> +++ b/drivers/gpu/drm/gma500/psb_irq.c
> @@ -470,12 +470,11 @@ void psb_irq_turn_off_dpst(struct drm_device *dev)
> {
> struct drm_psb_private *dev_priv =
> (struct drm_psb_private *) dev->dev_private;
> - u32 hist_reg;
> u32 pwm_reg;
>
> if (gma_power_begin(dev, false)) {
> PSB_WVDC32(0x00000000, HISTOGRAM_INT_CONTROL);
> - hist_reg = PSB_RVDC32(HISTOGRAM_INT_CONTROL);
> + PSB_RVDC32(HISTOGRAM_INT_CONTROL);
>
> psb_disable_pipestat(dev_priv, 0, PIPE_DPST_EVENT_ENABLE);
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-08 9:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-27 11:48 [PATCH next] drm/gma500: remove set but not used variables 'hist_reg' Chen Zhou
2020-01-08 9:12 ` Patrik Jakobsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).