* [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type
@ 2020-11-17 3:20 Chen Baozi
2020-11-17 8:46 ` Ard Biesheuvel
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chen Baozi @ 2020-11-17 3:20 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: linux-kernel
From: Chen Baozi <chenbaozi@phytium.com.cn>
Since fwspec->param_count of ACPI node is two, the index of IRQ type
in fwspec->param[] should be 1 rather than 2.
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
---
drivers/irqchip/irq-sni-exiu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-sni-exiu.c b/drivers/irqchip/irq-sni-exiu.c
index 1d027623c776..abd011fcecf4 100644
--- a/drivers/irqchip/irq-sni-exiu.c
+++ b/drivers/irqchip/irq-sni-exiu.c
@@ -136,7 +136,7 @@ static int exiu_domain_translate(struct irq_domain *domain,
if (fwspec->param_count != 2)
return -EINVAL;
*hwirq = fwspec->param[0];
- *type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
+ *type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK;
}
return 0;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type
2020-11-17 3:20 [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type Chen Baozi
@ 2020-11-17 8:46 ` Ard Biesheuvel
2020-11-22 12:49 ` Marc Zyngier
2020-11-23 16:45 ` [irqchip: irq/irqchip-next] " irqchip-bot for Chen Baozi
2 siblings, 0 replies; 5+ messages in thread
From: Ard Biesheuvel @ 2020-11-17 8:46 UTC (permalink / raw)
To: Chen Baozi, Marc Zyngier, Linux ARM; +Cc: Linux Kernel Mailing List
(+ Marc)
On Tue, 17 Nov 2020 at 04:20, Chen Baozi <cbz@baozis.org> wrote:
>
> From: Chen Baozi <chenbaozi@phytium.com.cn>
>
> Since fwspec->param_count of ACPI node is two, the index of IRQ type
> in fwspec->param[] should be 1 rather than 2.
>
> Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
> ---
> drivers/irqchip/irq-sni-exiu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-sni-exiu.c b/drivers/irqchip/irq-sni-exiu.c
> index 1d027623c776..abd011fcecf4 100644
> --- a/drivers/irqchip/irq-sni-exiu.c
> +++ b/drivers/irqchip/irq-sni-exiu.c
> @@ -136,7 +136,7 @@ static int exiu_domain_translate(struct irq_domain *domain,
> if (fwspec->param_count != 2)
> return -EINVAL;
> *hwirq = fwspec->param[0];
> - *type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
> + *type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK;
> }
> return 0;
> }
> --
> 2.28.0
>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type
2020-11-17 3:20 [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type Chen Baozi
2020-11-17 8:46 ` Ard Biesheuvel
@ 2020-11-22 12:49 ` Marc Zyngier
2020-11-23 16:45 ` [irqchip: irq/irqchip-next] " irqchip-bot for Chen Baozi
2 siblings, 0 replies; 5+ messages in thread
From: Marc Zyngier @ 2020-11-22 12:49 UTC (permalink / raw)
To: Chen Baozi, Ard Biesheuvel; +Cc: linux-kernel
On Tue, 17 Nov 2020 11:20:15 +0800, Chen Baozi wrote:
> Since fwspec->param_count of ACPI node is two, the index of IRQ type
> in fwspec->param[] should be 1 rather than 2.
Applied to irq/irqchip-next, thanks!
[1/1] irqchip/exiu: Fix the index of fwspec for IRQ type
commit: d001e41e1b15716e9b759df5ef00510699f85282
I added Fixes: and Cc: stable tags for a good measure.
Cheers,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 5+ messages in thread* [irqchip: irq/irqchip-next] irqchip/exiu: Fix the index of fwspec for IRQ type
2020-11-17 3:20 [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type Chen Baozi
2020-11-17 8:46 ` Ard Biesheuvel
2020-11-22 12:49 ` Marc Zyngier
@ 2020-11-23 16:45 ` irqchip-bot for Chen Baozi
2 siblings, 0 replies; 5+ messages in thread
From: irqchip-bot for Chen Baozi @ 2020-11-23 16:45 UTC (permalink / raw)
To: linux-kernel; +Cc: Chen Baozi, Marc Zyngier, Ard Biesheuvel, stable, tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: d001e41e1b15716e9b759df5ef00510699f85282
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/d001e41e1b15716e9b759df5ef00510699f85282
Author: Chen Baozi <chenbaozi@phytium.com.cn>
AuthorDate: Tue, 17 Nov 2020 11:20:15 +08:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Sun, 22 Nov 2020 10:27:23
irqchip/exiu: Fix the index of fwspec for IRQ type
Since fwspec->param_count of ACPI node is two, the index of IRQ type
in fwspec->param[] should be 1 rather than 2.
Fixes: 3d090a36c8c8 ("irqchip/exiu: Implement ACPI support")
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20201117032015.11805-1-cbz@baozis.org
Cc: stable@vger.kernel.org
---
drivers/irqchip/irq-sni-exiu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-sni-exiu.c b/drivers/irqchip/irq-sni-exiu.c
index 1d02762..abd011f 100644
--- a/drivers/irqchip/irq-sni-exiu.c
+++ b/drivers/irqchip/irq-sni-exiu.c
@@ -136,7 +136,7 @@ static int exiu_domain_translate(struct irq_domain *domain,
if (fwspec->param_count != 2)
return -EINVAL;
*hwirq = fwspec->param[0];
- *type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
+ *type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK;
}
return 0;
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type
@ 2020-11-17 3:18 Chen Baozi
0 siblings, 0 replies; 5+ messages in thread
From: Chen Baozi @ 2020-11-17 3:18 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: linux-kernel
From: Chen Baozi <chenbaozi@phytium.com.cn>
Since fwspec->param_count of ACPI node is two, the index of IRQ type
in fwspec->param[] should be 1 rather than 2.
Signed-off-by: Chen Baozi <chenbaozi@phytium.com.cn>
---
drivers/irqchip/irq-sni-exiu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-sni-exiu.c b/drivers/irqchip/irq-sni-exiu.c
index 1d027623c776..abd011fcecf4 100644
--- a/drivers/irqchip/irq-sni-exiu.c
+++ b/drivers/irqchip/irq-sni-exiu.c
@@ -136,7 +136,7 @@ static int exiu_domain_translate(struct irq_domain *domain,
if (fwspec->param_count != 2)
return -EINVAL;
*hwirq = fwspec->param[0];
- *type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
+ *type = fwspec->param[1] & IRQ_TYPE_SENSE_MASK;
}
return 0;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-23 16:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-17 3:20 [PATCH] irqchip/exiu: Fix the index of fwspec for IRQ type Chen Baozi
2020-11-17 8:46 ` Ard Biesheuvel
2020-11-22 12:49 ` Marc Zyngier
2020-11-23 16:45 ` [irqchip: irq/irqchip-next] " irqchip-bot for Chen Baozi
-- strict thread matches above, loose matches on Subject: below --
2020-11-17 3:18 [PATCH] " Chen Baozi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).