* [PATCH v2] efi: EFI_DISABLE_RUNTIME should depend on EFI
@ 2022-05-24 7:37 Geert Uytterhoeven
2022-05-28 9:24 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2022-05-24 7:37 UTC (permalink / raw)
To: Ard Biesheuvel, Javier Martinez Canillas
Cc: linux-efi, linux-kernel, Geert Uytterhoeven
The EFI_DISABLE_RUNTIME config option controls the use of Extensible
Firmware Interface (EFI) runtime services, which matters only if EFI
support is enabled.
Hence add a dependency on EFI, to prevent asking the user about this
control knob when configuring a kernel without EFI support.
Fixes: a031651ff2144a3d ("efi: Allow to enable EFI runtime services by default on RT")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
---
v2:
- Add Acked-by,
- Fix typo s/with/without/.
---
drivers/firmware/efi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 4720ba98cec312e7..ff6e7bfa8355cfc2 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -299,6 +299,7 @@ config EFI_CUSTOM_SSDT_OVERLAYS
config EFI_DISABLE_RUNTIME
bool "Disable EFI runtime services support by default"
+ depends on EFI
default y if PREEMPT_RT
help
Allow to disable the EFI runtime services support by default. This can
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] efi: EFI_DISABLE_RUNTIME should depend on EFI
2022-05-24 7:37 [PATCH v2] efi: EFI_DISABLE_RUNTIME should depend on EFI Geert Uytterhoeven
@ 2022-05-28 9:24 ` Ard Biesheuvel
2022-05-28 9:39 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2022-05-28 9:24 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Javier Martinez Canillas, linux-efi, Linux Kernel Mailing List
On Tue, 24 May 2022 at 09:37, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> The EFI_DISABLE_RUNTIME config option controls the use of Extensible
> Firmware Interface (EFI) runtime services, which matters only if EFI
> support is enabled.
>
> Hence add a dependency on EFI, to prevent asking the user about this
> control knob when configuring a kernel without EFI support.
>
> Fixes: a031651ff2144a3d ("efi: Allow to enable EFI runtime services by default on RT")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
> v2:
> - Add Acked-by,
> - Fix typo s/with/without/.
> ---
> drivers/firmware/efi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Can we just move this option into the menu/endmenu scope that already
depends on EFI?
> diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
> index 4720ba98cec312e7..ff6e7bfa8355cfc2 100644
> --- a/drivers/firmware/efi/Kconfig
> +++ b/drivers/firmware/efi/Kconfig
> @@ -299,6 +299,7 @@ config EFI_CUSTOM_SSDT_OVERLAYS
>
> config EFI_DISABLE_RUNTIME
> bool "Disable EFI runtime services support by default"
> + depends on EFI
> default y if PREEMPT_RT
> help
> Allow to disable the EFI runtime services support by default. This can
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] efi: EFI_DISABLE_RUNTIME should depend on EFI
2022-05-28 9:24 ` Ard Biesheuvel
@ 2022-05-28 9:39 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2022-05-28 9:39 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Javier Martinez Canillas, linux-efi, Linux Kernel Mailing List
On Sat, 28 May 2022 at 11:24, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Tue, 24 May 2022 at 09:37, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > The EFI_DISABLE_RUNTIME config option controls the use of Extensible
> > Firmware Interface (EFI) runtime services, which matters only if EFI
> > support is enabled.
> >
> > Hence add a dependency on EFI, to prevent asking the user about this
> > control knob when configuring a kernel without EFI support.
> >
> > Fixes: a031651ff2144a3d ("efi: Allow to enable EFI runtime services by default on RT")
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Acked-by: Javier Martinez Canillas <javierm@redhat.com>
> > ---
> > v2:
> > - Add Acked-by,
> > - Fix typo s/with/without/.
> > ---
> > drivers/firmware/efi/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
> Can we just move this option into the menu/endmenu scope that already
> depends on EFI?
>
We can, and there are other candidates as well. So I'll drop this
patch, and send out another one that covers some other options too.
Thanks,
Ard.
> > diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
> > index 4720ba98cec312e7..ff6e7bfa8355cfc2 100644
> > --- a/drivers/firmware/efi/Kconfig
> > +++ b/drivers/firmware/efi/Kconfig
> > @@ -299,6 +299,7 @@ config EFI_CUSTOM_SSDT_OVERLAYS
> >
> > config EFI_DISABLE_RUNTIME
> > bool "Disable EFI runtime services support by default"
> > + depends on EFI
> > default y if PREEMPT_RT
> > help
> > Allow to disable the EFI runtime services support by default. This can
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-28 9:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-24 7:37 [PATCH v2] efi: EFI_DISABLE_RUNTIME should depend on EFI Geert Uytterhoeven
2022-05-28 9:24 ` Ard Biesheuvel
2022-05-28 9:39 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).