From: Ard Biesheuvel <ardb@kernel.org>
To: Hadar Gat <hadar.gat@arm.com>
Cc: Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Stefan Wahren <wahrenst@gmx.net>, Zaibo Xu <xuzaibo@huawei.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gilad Ben-Yossef <gilad@benyossef.com>,
Ofir Drang <ofir.drang@arm.com>
Subject: Re: [PATCH 2/3] hwrng: cctrng - change default to n
Date: Mon, 27 Apr 2020 08:59:13 +0200 [thread overview]
Message-ID: <CAMj1kXGwVZiGbsT2NwWTyka0FVZnQcmfMSeoBKD03PdC=fRZeA@mail.gmail.com> (raw)
In-Reply-To: <1587966099-28139-3-git-send-email-hadar.gat@arm.com>
On Mon, 27 Apr 2020 at 07:42, Hadar Gat <hadar.gat@arm.com> wrote:
>
> For many users, the Arm CryptoCell HW is not available, so the
> default for HW_RANDOM_CCTRNG changed to n.
>
> Signed-off-by: Hadar Gat <hadar.gat@arm.com>
> ---
> drivers/char/hw_random/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> index df2d001..0938d3d 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -476,8 +476,8 @@ config HW_RANDOM_KEYSTONE
>
> config HW_RANDOM_CCTRNG
> tristate "Arm CryptoCell True Random Number Generator support"
> - depends on HAS_IOMEM & OF
> - default HW_RANDOM
> + depends on HW_RANDOM & HAS_IOMEM & OF
The whole block is guarded by if HW_RANDOM, so I don't think you need
the dependency here.
> + default n
'default n' is the default so you can just remove the line
> help
> This driver provides support for the True Random Number
> Generator available in Arm TrustZone CryptoCell.
> --
> 2.7.4
>
next prev parent reply other threads:[~2020-04-27 6:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 5:41 [PATCH 0/3] hwrng: cctrng kconfig updates Hadar Gat
2020-04-27 5:41 ` [PATCH 1/3] hwrng: cctrng - Add dependency on OF Hadar Gat
2020-04-27 6:58 ` Ard Biesheuvel
2020-04-27 7:23 ` Hadar Gat
2020-04-27 7:24 ` Ard Biesheuvel
2020-04-27 21:48 ` kbuild test robot
2020-04-27 5:41 ` [PATCH 2/3] hwrng: cctrng - change default to n Hadar Gat
2020-04-27 6:59 ` Ard Biesheuvel [this message]
2020-04-27 7:26 ` Hadar Gat
2020-04-27 8:19 ` Arnd Bergmann
2020-04-27 8:56 ` Hadar Gat
2020-04-27 5:41 ` [PATCH 3/3] hwrng: cctrng - update help description Hadar Gat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXGwVZiGbsT2NwWTyka0FVZnQcmfMSeoBKD03PdC=fRZeA@mail.gmail.com' \
--to=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=gilad@benyossef.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadar.gat@arm.com \
--cc=herbert@gondor.apana.org.au \
--cc=krzk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=ofir.drang@arm.com \
--cc=rdunlap@infradead.org \
--cc=tmaimon77@gmail.com \
--cc=wahrenst@gmx.net \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).