From: Hadar Gat <Hadar.Gat@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ard Biesheuvel <ardb@kernel.org>, Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Stefan Wahren <wahrenst@gmx.net>, Zaibo Xu <xuzaibo@huawei.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gilad Ben-Yossef <gilad@benyossef.com>,
Ofir Drang <Ofir.Drang@arm.com>, nd <nd@arm.com>
Subject: RE: [PATCH 2/3] hwrng: cctrng - change default to n
Date: Mon, 27 Apr 2020 08:56:38 +0000 [thread overview]
Message-ID: <DB6PR0802MB253351027A5B3236E31D1E9AE9AF0@DB6PR0802MB2533.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAK8P3a1LYAESnePbwbn7x7x=2MCTWUNZVmmoiuv+_-J2ntFGmA@mail.gmail.com>
> -----Original Message-----
> From: Arnd Bergmann <arnd@arndb.de>
>
> On Mon, Apr 27, 2020 at 9:26 AM Hadar Gat <Hadar.Gat@arm.com> wrote:
> > > -----Original Message-----
> > > From: Ard Biesheuvel <ardb@kernel.org>
> > > > + default n
> > >
> > > 'default n' is the default so you can just remove the line
> >
> > Is this a guideline or just optional?
> > Personally I like things to be explicit and if allowed I prefer to keep this line.
>
> It's a common convention, and we have had patches in the past that mass-
> removed those lines. I'd also just leave it out. It is generally well understood
> that all options default to 'n' unless specified otherwise.
Ok, I'll remove it.
Thanks for the explanation.
>
> Arnd
next prev parent reply other threads:[~2020-04-27 8:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 5:41 [PATCH 0/3] hwrng: cctrng kconfig updates Hadar Gat
2020-04-27 5:41 ` [PATCH 1/3] hwrng: cctrng - Add dependency on OF Hadar Gat
2020-04-27 6:58 ` Ard Biesheuvel
2020-04-27 7:23 ` Hadar Gat
2020-04-27 7:24 ` Ard Biesheuvel
2020-04-27 21:48 ` kbuild test robot
2020-04-27 5:41 ` [PATCH 2/3] hwrng: cctrng - change default to n Hadar Gat
2020-04-27 6:59 ` Ard Biesheuvel
2020-04-27 7:26 ` Hadar Gat
2020-04-27 8:19 ` Arnd Bergmann
2020-04-27 8:56 ` Hadar Gat [this message]
2020-04-27 5:41 ` [PATCH 3/3] hwrng: cctrng - update help description Hadar Gat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0802MB253351027A5B3236E31D1E9AE9AF0@DB6PR0802MB2533.eurprd08.prod.outlook.com \
--to=hadar.gat@arm.com \
--cc=Ofir.Drang@arm.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=gilad@benyossef.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=nd@arm.com \
--cc=rdunlap@infradead.org \
--cc=tmaimon77@gmail.com \
--cc=wahrenst@gmx.net \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).