From: Ard Biesheuvel <ardb@kernel.org>
To: Alexander Graf <graf@amazon.com>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v5 2/3] ACPI: allow longer device IDs
Date: Sun, 27 Feb 2022 12:59:15 +0100 [thread overview]
Message-ID: <CAMj1kXH=qohu1Wnn4dQfFqVOszD0HLasJJANSBYYBhYKrgxTKw@mail.gmail.com> (raw)
In-Reply-To: <fdd0abc8-8ce7-e183-721e-d2e4f45540f5@amazon.com>
On Sun, 27 Feb 2022 at 12:48, Alexander Graf <graf@amazon.com> wrote:
>
>
> On 27.02.22 12:43, Ard Biesheuvel wrote:
> > On Sun, 27 Feb 2022 at 12:39, Alexander Graf <graf@amazon.com> wrote:
> >>
> >> On 27.02.22 11:47, Ard Biesheuvel wrote:
> >>> On Sun, 27 Feb 2022 at 11:30, Ard Biesheuvel <ardb@kernel.org> wrote:
> >>>> On Sun, 27 Feb 2022 at 11:03, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> >>>>> On 2/27/22, Ard Biesheuvel <ardb@kernel.org> wrote:
> >>>>>> On Sat, 26 Feb 2022 at 23:07, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> >>>>>>> From: Alexander Graf <graf@amazon.com>
> >>>>>>>
> >>>>>> Please don't invent patch authors like that. Alex's patch that started
> >>>>>> this discussion was completely different.
> >>>>> Considering the investigative side ("why won't the _CID match?") and
> >>>>> most the commit message were Alex's, and that those things comprise
> >>>>> 95% of what this patch is, and that the code change itself isn't even
> >>>>> part of anything Turing complete, I most certainly did not feel
> >>>>> comfortable stripping Alex's authorship. Instead I added myself as a
> >>>>> co-author at the bottom. When in doubt, err on the side of crediting
> >>>>> others. Alex also took a look at this patch, I am under the impression
> >>>>> of at least, before it went out. Let's minimize the paperwork
> >>>>> policing, okay? I think it'd make for a much more pleasant space here.
> >>> ...
> >>>> Please stop with the ad hominems in response to criticism on factual
> >>>> aspects of your code. Putting someone else's authorship on code they
> >>>> did not write is not cool, and pointing that out is *not* what is
> >>>> making this space unpleasant.
> >>>> And 'paperwork policing' is sadly an important aspect of a high
> >>>> profile open source project such as Linux.
> >>>>
> >>> I typed this before reading your message on IRC, which reads:
> >>>
> >>> "Alex looked at that patch before i sent it out and did not object to
> >>> me keeping his authorship. I wouldn't have sent it out otherwise."
> >>>
> >>> and so I stand corrected if this is true. But please, next time,
> >>> please be more clear about these things.
> >>
> >> Yes, he did reach out to me on a separate channel and I told him to go
> >> for it :). Sorry if I created some confusion with that.
> >>
> > No, my bad. But in my defence, everyone on the original thread knows
> > that this single oneline change was suggested by Jason, not you, and
> > so seeing him posting it as your patch did confuse me a little.
>
>
> The idea came up 1y ago in conversations with Adrian when we tried to
> make _CID matching work. Unfortunately I did not file a patent for the
> mechanism to increase the array size until data fits :). It's such a
> revolutionary invention!
>
> Back to seriousness, I'm pretty indifferent on the attribution for it.
> What I'm more interested in is a solution that allows us to match the
> correct identifier :). My take is that Jason just wanted to be nice and
> was trying to give credit.
>
Giving credit is nice, but I do think that obfuscating authorship like
this is generally not preferred.
But in this particular case, it hardly matters, so let's not debate
this any further.
next prev parent reply other threads:[~2022-02-27 11:59 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 22:06 [PATCH v5 0/3] ACPI: VM fork detection for RNG Jason A. Donenfeld
2022-02-26 22:06 ` [PATCH v5 1/3] random: add mechanism for VM forks to reinitialize crng Jason A. Donenfeld
2022-02-26 22:06 ` [PATCH v5 2/3] ACPI: allow longer device IDs Jason A. Donenfeld
2022-02-27 7:31 ` Ard Biesheuvel
2022-02-27 7:37 ` Ard Biesheuvel
2022-02-27 10:03 ` Jason A. Donenfeld
2022-02-27 10:30 ` Ard Biesheuvel
2022-02-27 10:47 ` Ard Biesheuvel
2022-02-27 11:38 ` Alexander Graf
2022-02-27 11:43 ` Ard Biesheuvel
2022-02-27 11:48 ` Alexander Graf
2022-02-27 11:59 ` Ard Biesheuvel [this message]
2022-02-27 11:42 ` Alexander Graf
2022-02-27 12:43 ` Jason A. Donenfeld
2022-02-27 23:27 ` Jason A. Donenfeld
2022-02-28 18:19 ` Rafael J. Wysocki
2022-02-28 18:21 ` Jason A. Donenfeld
2022-02-28 18:33 ` [PATCH 2/3 v6] " Jason A. Donenfeld
2022-02-28 20:46 ` Andy Shevchenko
2022-02-28 20:58 ` Jason A. Donenfeld
2022-02-28 21:02 ` Ard Biesheuvel
2022-02-28 21:27 ` Andy Shevchenko
2022-02-28 21:54 ` Jason A. Donenfeld
2022-02-28 22:14 ` Michael Kelley (LINUX)
2022-02-28 22:17 ` Jason A. Donenfeld
2022-02-28 22:21 ` Ard Biesheuvel
2022-02-28 22:38 ` Michael Kelley (LINUX)
2022-02-28 22:46 ` Ard Biesheuvel
2022-03-22 19:58 ` Michael Kelley (LINUX)
2022-03-22 20:11 ` Jason A. Donenfeld
2022-03-24 19:25 ` Michael Kelley (LINUX)
2022-03-22 22:06 ` Ard Biesheuvel
2022-03-24 19:24 ` Michael Kelley (LINUX)
2022-03-24 19:45 ` Jason A. Donenfeld
2022-03-24 20:14 ` Michael Kelley (LINUX)
2022-03-01 13:12 ` Andy Shevchenko
2022-02-28 22:00 ` Alexander Graf
2022-02-28 22:17 ` Ard Biesheuvel
2022-03-01 10:35 ` Hans de Goede
2022-03-01 10:38 ` Jason A. Donenfeld
2022-03-01 10:49 ` Hans de Goede
2022-03-01 14:25 ` Andy Shevchenko
2022-03-01 14:48 ` Jason A. Donenfeld
2022-03-01 12:29 ` Rafael J. Wysocki
2022-03-01 10:31 ` [PATCH v5 2/3] " Hans de Goede
2022-02-26 22:06 ` [PATCH v5 3/3] virt: vmgenid: introduce driver for reinitializing RNG on VM fork Jason A. Donenfeld
2022-03-06 16:02 ` Michael Kelley (LINUX)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXH=qohu1Wnn4dQfFqVOszD0HLasJJANSBYYBhYKrgxTKw@mail.gmail.com' \
--to=ardb@kernel.org \
--cc=Jason@zx2c4.com \
--cc=graf@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).