From: Ard Biesheuvel <ardb@kernel.org>
To: Simo Sorce <simo@redhat.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Dexuan Cui <decui@microsoft.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"crecklin@redhat.com" <crecklin@redhat.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Fix hibernation in FIPS mode?
Date: Tue, 30 Mar 2021 21:45:18 +0200 [thread overview]
Message-ID: <CAMj1kXHg2RDgwmOhJkaAPoWeHpxnd6tixp94Kha1-bzNvCaQUg@mail.gmail.com> (raw)
In-Reply-To: <4e95307db43e2f7cc8516e645b81db7db0dd8ad4.camel@redhat.com>
On Tue, 30 Mar 2021 at 20:05, Simo Sorce <simo@redhat.com> wrote:
>
> On Tue, 2021-03-30 at 16:46 +0200, Rafael J. Wysocki wrote:
> > On Tue, Mar 30, 2021 at 12:14 AM Dexuan Cui <decui@microsoft.com> wrote:
> > > Hi,
> > > MD5 was marked incompliant with FIPS in 2009:
> > > a3bef3a31a19 ("crypto: testmgr - Skip algs not flagged fips_allowed in fips mode")
> > > a1915d51e8e7 ("crypto: testmgr - Mark algs allowed in fips mode")
> > >
> > > But hibernation_e820_save() is still using MD5, and fails in FIPS mode
> > > due to the 2018 patch:
> > > 749fa17093ff ("PM / hibernate: Check the success of generating md5 digest before hibernation")
> > >
> > > As a result, hibernation doesn't work when FIPS is on.
> > >
> > > Do you think if hibernation_e820_save() should be changed to use a
> > > FIPS-compliant algorithm like SHA-1?
> >
> > I would say yes, it should.
> >
> > > PS, currently it looks like FIPS mode is broken in the mainline:
> > > https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg49414.html
>
>
> FYI, SHA-1 is not a good choice, it is only permitted in HMAC
> constructions and only for specified uses. If you need to change
> algorithm you should go straight to SHA-2 or SHA-3 based hashes.
>
What is the reason for using a [broken] cryptographic hash here? if
this is just an integrity check, better use CRC32
next prev parent reply other threads:[~2021-03-30 19:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 22:13 Fix hibernation in FIPS mode? Dexuan Cui
2021-03-30 14:46 ` Rafael J. Wysocki
2021-03-30 14:51 ` Chris von Recklinghausen
2021-03-30 18:04 ` Simo Sorce
2021-03-30 19:45 ` Ard Biesheuvel [this message]
2021-03-30 19:55 ` Simo Sorce
2021-04-01 8:46 ` Ard Biesheuvel
2021-04-01 13:38 ` Rafael J. Wysocki
2021-04-01 13:54 ` Chris von Recklinghausen
2021-04-01 13:56 ` Ard Biesheuvel
2021-04-01 18:26 ` Eric Biggers
2021-04-01 13:54 ` Ard Biesheuvel
2021-04-01 16:02 ` Rafael J. Wysocki
2021-04-01 16:22 ` Simo Sorce
2021-04-01 16:31 ` Rafael J. Wysocki
2021-04-01 17:53 ` Simo Sorce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXHg2RDgwmOhJkaAPoWeHpxnd6tixp94Kha1-bzNvCaQUg@mail.gmail.com \
--to=ardb@kernel.org \
--cc=crecklin@redhat.com \
--cc=decui@microsoft.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=simo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).