linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dexuan Cui <decui@microsoft.com>
To: "'linux-pm@vger.kernel.org'" <linux-pm@vger.kernel.org>
Cc: "crecklin@redhat.com" <crecklin@redhat.com>,
	"'linux-crypto@vger.kernel.org'" <linux-crypto@vger.kernel.org>,
	"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
Subject: Fix hibernation in FIPS mode?
Date: Mon, 29 Mar 2021 22:13:05 +0000	[thread overview]
Message-ID: <MW2PR2101MB08924CD74C6EB773C4D5FAFDBF7E9@MW2PR2101MB0892.namprd21.prod.outlook.com> (raw)

Hi,
MD5 was marked incompliant with FIPS in 2009:
a3bef3a31a19 ("crypto: testmgr - Skip algs not flagged fips_allowed in fips mode")
a1915d51e8e7 ("crypto: testmgr - Mark algs allowed in fips mode")

But hibernation_e820_save() is still using MD5, and fails in FIPS mode
due to the 2018 patch:
749fa17093ff ("PM / hibernate: Check the success of generating md5 digest before hibernation")

As a result, hibernation doesn't work when FIPS is on.

Do you think if hibernation_e820_save() should be changed to use a
FIPS-compliant algorithm like SHA-1?

PS, currently it looks like FIPS mode is broken in the mainline:
https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg49414.html

Thanks,
-- Dexuan


             reply	other threads:[~2021-03-29 22:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29 22:13 Dexuan Cui [this message]
2021-03-30 14:46 ` Fix hibernation in FIPS mode? Rafael J. Wysocki
2021-03-30 14:51   ` Chris von Recklinghausen
2021-03-30 18:04   ` Simo Sorce
2021-03-30 19:45     ` Ard Biesheuvel
2021-03-30 19:55       ` Simo Sorce
2021-04-01  8:46         ` Ard Biesheuvel
2021-04-01 13:38           ` Rafael J. Wysocki
2021-04-01 13:54             ` Chris von Recklinghausen
2021-04-01 13:56               ` Ard Biesheuvel
2021-04-01 18:26               ` Eric Biggers
2021-04-01 13:54             ` Ard Biesheuvel
2021-04-01 16:02               ` Rafael J. Wysocki
2021-04-01 16:22                 ` Simo Sorce
2021-04-01 16:31                   ` Rafael J. Wysocki
2021-04-01 17:53                     ` Simo Sorce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW2PR2101MB08924CD74C6EB773C4D5FAFDBF7E9@MW2PR2101MB0892.namprd21.prod.outlook.com \
    --to=decui@microsoft.com \
    --cc=crecklin@redhat.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).