linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [ardb:for-kernelci 25/25] arch/arm/kernel/traps.c:865:17: warning: no previous prototype for function 'handle_bad_stack'
@ 2021-11-25  1:34 kernel test robot
  2021-11-30 13:12 ` Ard Biesheuvel
  0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2021-11-25  1:34 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: llvm, kbuild-all, linux-kernel

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git for-kernelci
head:   5da04a8b7050432b72f6551b6c95e4b5b5fd68d1
commit: 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1 [25/25] ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems
config: arm-randconfig-r024-20211124 (https://download.01.org/0day-ci/archive/20211125/202111250918.ErFZktQF-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 67a1c45def8a75061203461ab0060c75c864df1c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/commit/?id=5da04a8b7050432b72f6551b6c95e4b5b5fd68d1
        git remote add ardb git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git
        git fetch --no-tags ardb for-kernelci
        git checkout 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1
        # save the config file to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   arch/arm/kernel/traps.c:95:6: warning: no previous prototype for function 'dump_backtrace_stm' [-Wmissing-prototypes]
   void dump_backtrace_stm(u32 *stack, u32 instruction, const char *loglvl)
        ^
   arch/arm/kernel/traps.c:95:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void dump_backtrace_stm(u32 *stack, u32 instruction, const char *loglvl)
   ^
   static 
   arch/arm/kernel/traps.c:446:17: warning: no previous prototype for function 'do_undefinstr' [-Wmissing-prototypes]
   asmlinkage void do_undefinstr(struct pt_regs *regs)
                   ^
   arch/arm/kernel/traps.c:446:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
   asmlinkage void do_undefinstr(struct pt_regs *regs)
              ^
              static 
   arch/arm/kernel/traps.c:511:39: warning: no previous prototype for function 'handle_fiq_as_nmi' [-Wmissing-prototypes]
   asmlinkage void __exception_irq_entry handle_fiq_as_nmi(struct pt_regs *regs)
                                         ^
   arch/arm/kernel/traps.c:511:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
   asmlinkage void __exception_irq_entry handle_fiq_as_nmi(struct pt_regs *regs)
              ^
              static 
   arch/arm/kernel/traps.c:530:17: warning: no previous prototype for function 'bad_mode' [-Wmissing-prototypes]
   asmlinkage void bad_mode(struct pt_regs *regs, int reason)
                   ^
   arch/arm/kernel/traps.c:530:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
   asmlinkage void bad_mode(struct pt_regs *regs, int reason)
              ^
              static 
   arch/arm/kernel/traps.c:603:16: warning: no previous prototype for function 'arm_syscall' [-Wmissing-prototypes]
   asmlinkage int arm_syscall(int no, struct pt_regs *regs)
                  ^
   arch/arm/kernel/traps.c:603:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
   asmlinkage int arm_syscall(int no, struct pt_regs *regs)
              ^
              static 
   arch/arm/kernel/traps.c:729:1: warning: no previous prototype for function 'baddataabort' [-Wmissing-prototypes]
   baddataabort(int code, unsigned long instr, struct pt_regs *regs)
   ^
   arch/arm/kernel/traps.c:728:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
   asmlinkage void
              ^
              static 
   arch/arm/kernel/traps.c:769:17: warning: no previous prototype for function '__div0' [-Wmissing-prototypes]
   asmlinkage void __div0(void)
                   ^
   arch/arm/kernel/traps.c:769:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
   asmlinkage void __div0(void)
              ^
              static 
>> arch/arm/kernel/traps.c:865:17: warning: no previous prototype for function 'handle_bad_stack' [-Wmissing-prototypes]
   asmlinkage void handle_bad_stack(struct pt_regs *regs)
                   ^
   arch/arm/kernel/traps.c:865:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
   asmlinkage void handle_bad_stack(struct pt_regs *regs)
              ^
              static 
   8 warnings generated.


vim +/handle_bad_stack +865 arch/arm/kernel/traps.c

adc7d753de62f2 Ard Biesheuvel 2021-09-23  864  
adc7d753de62f2 Ard Biesheuvel 2021-09-23 @865  asmlinkage void handle_bad_stack(struct pt_regs *regs)
adc7d753de62f2 Ard Biesheuvel 2021-09-23  866  {
adc7d753de62f2 Ard Biesheuvel 2021-09-23  867  	unsigned long tsk_stk = (unsigned long)current->stack;
5da04a8b705043 Ard Biesheuvel 2021-11-24  868  #ifdef CONFIG_IRQSTACKS
adc7d753de62f2 Ard Biesheuvel 2021-09-23  869  	unsigned long irq_stk = (unsigned long)this_cpu_read(irq_stack_ptr);
5da04a8b705043 Ard Biesheuvel 2021-11-24  870  #endif
adc7d753de62f2 Ard Biesheuvel 2021-09-23  871  	unsigned long ovf_stk = (unsigned long)this_cpu_read(overflow_stack_ptr);
adc7d753de62f2 Ard Biesheuvel 2021-09-23  872  
adc7d753de62f2 Ard Biesheuvel 2021-09-23  873  	console_verbose();
adc7d753de62f2 Ard Biesheuvel 2021-09-23  874  	pr_emerg("Insufficient stack space to handle exception!");
adc7d753de62f2 Ard Biesheuvel 2021-09-23  875  
adc7d753de62f2 Ard Biesheuvel 2021-09-23  876  	pr_emerg("Task stack:     [0x%08lx..0x%08lx]\n",
adc7d753de62f2 Ard Biesheuvel 2021-09-23  877  		 tsk_stk, tsk_stk + THREAD_SIZE);
5da04a8b705043 Ard Biesheuvel 2021-11-24  878  #ifdef CONFIG_IRQSTACKS
adc7d753de62f2 Ard Biesheuvel 2021-09-23  879  	pr_emerg("IRQ stack:      [0x%08lx..0x%08lx]\n",
adc7d753de62f2 Ard Biesheuvel 2021-09-23  880  		 irq_stk - THREAD_SIZE, irq_stk);
5da04a8b705043 Ard Biesheuvel 2021-11-24  881  #endif
adc7d753de62f2 Ard Biesheuvel 2021-09-23  882  	pr_emerg("Overflow stack: [0x%08lx..0x%08lx]\n",
adc7d753de62f2 Ard Biesheuvel 2021-09-23  883  		 ovf_stk - OVERFLOW_STACK_SIZE, ovf_stk);
adc7d753de62f2 Ard Biesheuvel 2021-09-23  884  
adc7d753de62f2 Ard Biesheuvel 2021-09-23  885  	die("kernel stack overflow", regs, 0);
adc7d753de62f2 Ard Biesheuvel 2021-09-23  886  }
adc7d753de62f2 Ard Biesheuvel 2021-09-23  887  

:::::: The code at line 865 was first introduced by commit
:::::: adc7d753de62f220505f528106a6d618104302c5 ARM: implement support for vmap'ed stacks

:::::: TO: Ard Biesheuvel <ardb@kernel.org>
:::::: CC: Ard Biesheuvel <ardb@kernel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [ardb:for-kernelci 25/25] arch/arm/kernel/traps.c:865:17: warning: no previous prototype for function 'handle_bad_stack'
  2021-11-25  1:34 [ardb:for-kernelci 25/25] arch/arm/kernel/traps.c:865:17: warning: no previous prototype for function 'handle_bad_stack' kernel test robot
@ 2021-11-30 13:12 ` Ard Biesheuvel
  2021-12-02  7:34   ` [kbuild-all] " Rong Chen
  0 siblings, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2021-11-30 13:12 UTC (permalink / raw)
  To: kernel test robot; +Cc: llvm, kbuild-all, Linux Kernel Mailing List

On Thu, 25 Nov 2021 at 02:35, kernel test robot <lkp@intel.com> wrote:
>
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git for-kernelci
> head:   5da04a8b7050432b72f6551b6c95e4b5b5fd68d1
> commit: 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1 [25/25] ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems
> config: arm-randconfig-r024-20211124 (https://download.01.org/0day-ci/archive/20211125/202111250918.ErFZktQF-lkp@intel.com/config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 67a1c45def8a75061203461ab0060c75c864df1c)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install arm cross compiling tool for clang build
>         # apt-get install binutils-arm-linux-gnueabi
>         # https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/commit/?id=5da04a8b7050432b72f6551b6c95e4b5b5fd68d1
>         git remote add ardb git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git
>         git fetch --no-tags ardb for-kernelci
>         git checkout 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1
>         # save the config file to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>

This is yet another false positive. asmlinkage routines don't need a
prototype because they are called from assembler. This is not going to
get fixed, so please don't report this error anymore.



>    arch/arm/kernel/traps.c:95:6: warning: no previous prototype for function 'dump_backtrace_stm' [-Wmissing-prototypes]
>    void dump_backtrace_stm(u32 *stack, u32 instruction, const char *loglvl)
>         ^
>    arch/arm/kernel/traps.c:95:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    void dump_backtrace_stm(u32 *stack, u32 instruction, const char *loglvl)
>    ^
>    static
>    arch/arm/kernel/traps.c:446:17: warning: no previous prototype for function 'do_undefinstr' [-Wmissing-prototypes]
>    asmlinkage void do_undefinstr(struct pt_regs *regs)
>                    ^
>    arch/arm/kernel/traps.c:446:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    asmlinkage void do_undefinstr(struct pt_regs *regs)
>               ^
>               static
>    arch/arm/kernel/traps.c:511:39: warning: no previous prototype for function 'handle_fiq_as_nmi' [-Wmissing-prototypes]
>    asmlinkage void __exception_irq_entry handle_fiq_as_nmi(struct pt_regs *regs)
>                                          ^
>    arch/arm/kernel/traps.c:511:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    asmlinkage void __exception_irq_entry handle_fiq_as_nmi(struct pt_regs *regs)
>               ^
>               static
>    arch/arm/kernel/traps.c:530:17: warning: no previous prototype for function 'bad_mode' [-Wmissing-prototypes]
>    asmlinkage void bad_mode(struct pt_regs *regs, int reason)
>                    ^
>    arch/arm/kernel/traps.c:530:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    asmlinkage void bad_mode(struct pt_regs *regs, int reason)
>               ^
>               static
>    arch/arm/kernel/traps.c:603:16: warning: no previous prototype for function 'arm_syscall' [-Wmissing-prototypes]
>    asmlinkage int arm_syscall(int no, struct pt_regs *regs)
>                   ^
>    arch/arm/kernel/traps.c:603:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    asmlinkage int arm_syscall(int no, struct pt_regs *regs)
>               ^
>               static
>    arch/arm/kernel/traps.c:729:1: warning: no previous prototype for function 'baddataabort' [-Wmissing-prototypes]
>    baddataabort(int code, unsigned long instr, struct pt_regs *regs)
>    ^
>    arch/arm/kernel/traps.c:728:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    asmlinkage void
>               ^
>               static
>    arch/arm/kernel/traps.c:769:17: warning: no previous prototype for function '__div0' [-Wmissing-prototypes]
>    asmlinkage void __div0(void)
>                    ^
>    arch/arm/kernel/traps.c:769:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    asmlinkage void __div0(void)
>               ^
>               static
> >> arch/arm/kernel/traps.c:865:17: warning: no previous prototype for function 'handle_bad_stack' [-Wmissing-prototypes]
>    asmlinkage void handle_bad_stack(struct pt_regs *regs)
>                    ^
>    arch/arm/kernel/traps.c:865:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    asmlinkage void handle_bad_stack(struct pt_regs *regs)
>               ^
>               static
>    8 warnings generated.
>
>
> vim +/handle_bad_stack +865 arch/arm/kernel/traps.c
>
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  864
> adc7d753de62f2 Ard Biesheuvel 2021-09-23 @865  asmlinkage void handle_bad_stack(struct pt_regs *regs)
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  866  {
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  867   unsigned long tsk_stk = (unsigned long)current->stack;
> 5da04a8b705043 Ard Biesheuvel 2021-11-24  868  #ifdef CONFIG_IRQSTACKS
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  869   unsigned long irq_stk = (unsigned long)this_cpu_read(irq_stack_ptr);
> 5da04a8b705043 Ard Biesheuvel 2021-11-24  870  #endif
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  871   unsigned long ovf_stk = (unsigned long)this_cpu_read(overflow_stack_ptr);
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  872
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  873   console_verbose();
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  874   pr_emerg("Insufficient stack space to handle exception!");
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  875
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  876   pr_emerg("Task stack:     [0x%08lx..0x%08lx]\n",
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  877            tsk_stk, tsk_stk + THREAD_SIZE);
> 5da04a8b705043 Ard Biesheuvel 2021-11-24  878  #ifdef CONFIG_IRQSTACKS
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  879   pr_emerg("IRQ stack:      [0x%08lx..0x%08lx]\n",
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  880            irq_stk - THREAD_SIZE, irq_stk);
> 5da04a8b705043 Ard Biesheuvel 2021-11-24  881  #endif
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  882   pr_emerg("Overflow stack: [0x%08lx..0x%08lx]\n",
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  883            ovf_stk - OVERFLOW_STACK_SIZE, ovf_stk);
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  884
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  885   die("kernel stack overflow", regs, 0);
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  886  }
> adc7d753de62f2 Ard Biesheuvel 2021-09-23  887
>
> :::::: The code at line 865 was first introduced by commit
> :::::: adc7d753de62f220505f528106a6d618104302c5 ARM: implement support for vmap'ed stacks
>
> :::::: TO: Ard Biesheuvel <ardb@kernel.org>
> :::::: CC: Ard Biesheuvel <ardb@kernel.org>
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [kbuild-all] Re: [ardb:for-kernelci 25/25] arch/arm/kernel/traps.c:865:17: warning: no previous prototype for function 'handle_bad_stack'
  2021-11-30 13:12 ` Ard Biesheuvel
@ 2021-12-02  7:34   ` Rong Chen
  2021-12-02  7:53     ` Ard Biesheuvel
  0 siblings, 1 reply; 5+ messages in thread
From: Rong Chen @ 2021-12-02  7:34 UTC (permalink / raw)
  To: Ard Biesheuvel, kernel test robot
  Cc: llvm, kbuild-all, Linux Kernel Mailing List



On 11/30/21 21:12, Ard Biesheuvel wrote:
> On Thu, 25 Nov 2021 at 02:35, kernel test robot <lkp@intel.com> wrote:
>> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git for-kernelci
>> head:   5da04a8b7050432b72f6551b6c95e4b5b5fd68d1
>> commit: 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1 [25/25] ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems
>> config: arm-randconfig-r024-20211124 (https://download.01.org/0day-ci/archive/20211125/202111250918.ErFZktQF-lkp@intel.com/config)
>> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 67a1c45def8a75061203461ab0060c75c864df1c)
>> reproduce (this is a W=1 build):
>>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>          chmod +x ~/bin/make.cross
>>          # install arm cross compiling tool for clang build
>>          # apt-get install binutils-arm-linux-gnueabi
>>          # https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/commit/?id=5da04a8b7050432b72f6551b6c95e4b5b5fd68d1
>>          git remote add ardb git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git
>>          git fetch --no-tags ardb for-kernelci
>>          git checkout 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1
>>          # save the config file to linux build tree
>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All warnings (new ones prefixed by >>):
>>
> This is yet another false positive. asmlinkage routines don't need a
> prototype because they are called from assembler. This is not going to
> get fixed, so please don't report this error anymore.

Hi Ard,

Sorry for the noise, we'll ignore the warnings in the future.

Best Regards,
Rong Chen

>
>
>>     arch/arm/kernel/traps.c:95:6: warning: no previous prototype for function 'dump_backtrace_stm' [-Wmissing-prototypes]
>>     void dump_backtrace_stm(u32 *stack, u32 instruction, const char *loglvl)
>>          ^
>>     arch/arm/kernel/traps.c:95:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>>     void dump_backtrace_stm(u32 *stack, u32 instruction, const char *loglvl)
>>     ^
>>     static
>>     arch/arm/kernel/traps.c:446:17: warning: no previous prototype for function 'do_undefinstr' [-Wmissing-prototypes]
>>     asmlinkage void do_undefinstr(struct pt_regs *regs)
>>                     ^
>>     arch/arm/kernel/traps.c:446:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
>>     asmlinkage void do_undefinstr(struct pt_regs *regs)
>>                ^
>>                static
>>     arch/arm/kernel/traps.c:511:39: warning: no previous prototype for function 'handle_fiq_as_nmi' [-Wmissing-prototypes]
>>     asmlinkage void __exception_irq_entry handle_fiq_as_nmi(struct pt_regs *regs)
>>                                           ^
>>     arch/arm/kernel/traps.c:511:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
>>     asmlinkage void __exception_irq_entry handle_fiq_as_nmi(struct pt_regs *regs)
>>                ^
>>                static
>>     arch/arm/kernel/traps.c:530:17: warning: no previous prototype for function 'bad_mode' [-Wmissing-prototypes]
>>     asmlinkage void bad_mode(struct pt_regs *regs, int reason)
>>                     ^
>>     arch/arm/kernel/traps.c:530:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
>>     asmlinkage void bad_mode(struct pt_regs *regs, int reason)
>>                ^
>>                static
>>     arch/arm/kernel/traps.c:603:16: warning: no previous prototype for function 'arm_syscall' [-Wmissing-prototypes]
>>     asmlinkage int arm_syscall(int no, struct pt_regs *regs)
>>                    ^
>>     arch/arm/kernel/traps.c:603:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
>>     asmlinkage int arm_syscall(int no, struct pt_regs *regs)
>>                ^
>>                static
>>     arch/arm/kernel/traps.c:729:1: warning: no previous prototype for function 'baddataabort' [-Wmissing-prototypes]
>>     baddataabort(int code, unsigned long instr, struct pt_regs *regs)
>>     ^
>>     arch/arm/kernel/traps.c:728:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
>>     asmlinkage void
>>                ^
>>                static
>>     arch/arm/kernel/traps.c:769:17: warning: no previous prototype for function '__div0' [-Wmissing-prototypes]
>>     asmlinkage void __div0(void)
>>                     ^
>>     arch/arm/kernel/traps.c:769:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
>>     asmlinkage void __div0(void)
>>                ^
>>                static
>>>> arch/arm/kernel/traps.c:865:17: warning: no previous prototype for function 'handle_bad_stack' [-Wmissing-prototypes]
>>     asmlinkage void handle_bad_stack(struct pt_regs *regs)
>>                     ^
>>     arch/arm/kernel/traps.c:865:12: note: declare 'static' if the function is not intended to be used outside of this translation unit
>>     asmlinkage void handle_bad_stack(struct pt_regs *regs)
>>                ^
>>                static
>>     8 warnings generated.
>>
>>
>> vim +/handle_bad_stack +865 arch/arm/kernel/traps.c
>>
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  864
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23 @865  asmlinkage void handle_bad_stack(struct pt_regs *regs)
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  866  {
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  867   unsigned long tsk_stk = (unsigned long)current->stack;
>> 5da04a8b705043 Ard Biesheuvel 2021-11-24  868  #ifdef CONFIG_IRQSTACKS
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  869   unsigned long irq_stk = (unsigned long)this_cpu_read(irq_stack_ptr);
>> 5da04a8b705043 Ard Biesheuvel 2021-11-24  870  #endif
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  871   unsigned long ovf_stk = (unsigned long)this_cpu_read(overflow_stack_ptr);
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  872
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  873   console_verbose();
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  874   pr_emerg("Insufficient stack space to handle exception!");
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  875
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  876   pr_emerg("Task stack:     [0x%08lx..0x%08lx]\n",
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  877            tsk_stk, tsk_stk + THREAD_SIZE);
>> 5da04a8b705043 Ard Biesheuvel 2021-11-24  878  #ifdef CONFIG_IRQSTACKS
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  879   pr_emerg("IRQ stack:      [0x%08lx..0x%08lx]\n",
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  880            irq_stk - THREAD_SIZE, irq_stk);
>> 5da04a8b705043 Ard Biesheuvel 2021-11-24  881  #endif
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  882   pr_emerg("Overflow stack: [0x%08lx..0x%08lx]\n",
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  883            ovf_stk - OVERFLOW_STACK_SIZE, ovf_stk);
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  884
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  885   die("kernel stack overflow", regs, 0);
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  886  }
>> adc7d753de62f2 Ard Biesheuvel 2021-09-23  887
>>
>> :::::: The code at line 865 was first introduced by commit
>> :::::: adc7d753de62f220505f528106a6d618104302c5 ARM: implement support for vmap'ed stacks
>>
>> :::::: TO: Ard Biesheuvel <ardb@kernel.org>
>> :::::: CC: Ard Biesheuvel <ardb@kernel.org>
>>
>> ---
>> 0-DAY CI Kernel Test Service, Intel Corporation
>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@lists.01.org
> To unsubscribe send an email to kbuild-all-leave@lists.01.org


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [kbuild-all] Re: [ardb:for-kernelci 25/25] arch/arm/kernel/traps.c:865:17: warning: no previous prototype for function 'handle_bad_stack'
  2021-12-02  7:34   ` [kbuild-all] " Rong Chen
@ 2021-12-02  7:53     ` Ard Biesheuvel
  2021-12-02  8:03       ` Rong Chen
  0 siblings, 1 reply; 5+ messages in thread
From: Ard Biesheuvel @ 2021-12-02  7:53 UTC (permalink / raw)
  To: Rong Chen; +Cc: kernel test robot, llvm, kbuild-all, Linux Kernel Mailing List

On Thu, 2 Dec 2021 at 08:34, Rong Chen <rong.a.chen@intel.com> wrote:
>
>
>
> On 11/30/21 21:12, Ard Biesheuvel wrote:
> > On Thu, 25 Nov 2021 at 02:35, kernel test robot <lkp@intel.com> wrote:
> >> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git for-kernelci
> >> head:   5da04a8b7050432b72f6551b6c95e4b5b5fd68d1
> >> commit: 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1 [25/25] ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems
> >> config: arm-randconfig-r024-20211124 (https://download.01.org/0day-ci/archive/20211125/202111250918.ErFZktQF-lkp@intel.com/config)
> >> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 67a1c45def8a75061203461ab0060c75c864df1c)
> >> reproduce (this is a W=1 build):
> >>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >>          chmod +x ~/bin/make.cross
> >>          # install arm cross compiling tool for clang build
> >>          # apt-get install binutils-arm-linux-gnueabi
> >>          # https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/commit/?id=5da04a8b7050432b72f6551b6c95e4b5b5fd68d1
> >>          git remote add ardb git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git
> >>          git fetch --no-tags ardb for-kernelci
> >>          git checkout 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1
> >>          # save the config file to linux build tree
> >>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm
> >>
> >> If you fix the issue, kindly add following tag as appropriate
> >> Reported-by: kernel test robot <lkp@intel.com>
> >>
> >> All warnings (new ones prefixed by >>):
> >>
> > This is yet another false positive. asmlinkage routines don't need a
> > prototype because they are called from assembler. This is not going to
> > get fixed, so please don't report this error anymore.
>
> Hi Ard,
>
> Sorry for the noise, we'll ignore the warnings in the future.
>

Thanks! And if at all possible, please extend this to all routines
marked as asmlinkage?

-- 
Ard.

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [kbuild-all] Re: [ardb:for-kernelci 25/25] arch/arm/kernel/traps.c:865:17: warning: no previous prototype for function 'handle_bad_stack'
  2021-12-02  7:53     ` Ard Biesheuvel
@ 2021-12-02  8:03       ` Rong Chen
  0 siblings, 0 replies; 5+ messages in thread
From: Rong Chen @ 2021-12-02  8:03 UTC (permalink / raw)
  To: Ard Biesheuvel
  Cc: kernel test robot, llvm, kbuild-all, Linux Kernel Mailing List



On 12/2/21 15:53, Ard Biesheuvel wrote:
> On Thu, 2 Dec 2021 at 08:34, Rong Chen <rong.a.chen@intel.com> wrote:
>>
>>
>> On 11/30/21 21:12, Ard Biesheuvel wrote:
>>> On Thu, 25 Nov 2021 at 02:35, kernel test robot <lkp@intel.com> wrote:
>>>> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git for-kernelci
>>>> head:   5da04a8b7050432b72f6551b6c95e4b5b5fd68d1
>>>> commit: 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1 [25/25] ARM: implement THREAD_INFO_IN_TASK for uniprocessor systems
>>>> config: arm-randconfig-r024-20211124 (https://download.01.org/0day-ci/archive/20211125/202111250918.ErFZktQF-lkp@intel.com/config)
>>>> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 67a1c45def8a75061203461ab0060c75c864df1c)
>>>> reproduce (this is a W=1 build):
>>>>           wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>>>           chmod +x ~/bin/make.cross
>>>>           # install arm cross compiling tool for clang build
>>>>           # apt-get install binutils-arm-linux-gnueabi
>>>>           # https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/commit/?id=5da04a8b7050432b72f6551b6c95e4b5b5fd68d1
>>>>           git remote add ardb git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git
>>>>           git fetch --no-tags ardb for-kernelci
>>>>           git checkout 5da04a8b7050432b72f6551b6c95e4b5b5fd68d1
>>>>           # save the config file to linux build tree
>>>>           COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm
>>>>
>>>> If you fix the issue, kindly add following tag as appropriate
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>>
>>>> All warnings (new ones prefixed by >>):
>>>>
>>> This is yet another false positive. asmlinkage routines don't need a
>>> prototype because they are called from assembler. This is not going to
>>> get fixed, so please don't report this error anymore.
>> Hi Ard,
>>
>> Sorry for the noise, we'll ignore the warnings in the future.
>>
> Thanks! And if at all possible, please extend this to all routines
> marked as asmlinkage?
>

got it, thanks for your reminding.

Best Regards,
Rong Chen

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-02  8:03 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-25  1:34 [ardb:for-kernelci 25/25] arch/arm/kernel/traps.c:865:17: warning: no previous prototype for function 'handle_bad_stack' kernel test robot
2021-11-30 13:12 ` Ard Biesheuvel
2021-12-02  7:34   ` [kbuild-all] " Rong Chen
2021-12-02  7:53     ` Ard Biesheuvel
2021-12-02  8:03       ` Rong Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).