* [PATCH] xtensa: Use seq_puts() in c_show()
@ 2017-05-07 19:33 SF Markus Elfring
2017-05-08 20:19 ` Max Filippov
0 siblings, 1 reply; 2+ messages in thread
From: SF Markus Elfring @ 2017-05-07 19:33 UTC (permalink / raw)
To: Chris Zankel, Günter Röck, Kefeng Wang, Max Filippov,
Rob Herring
Cc: LKML, kernel-janitors
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 7 May 2017 21:24:51 +0200
A string which did not contain a data format specification should be put
into a sequence. Thus use the corresponding function "seq_puts".
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/xtensa/kernel/setup.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/xtensa/kernel/setup.c b/arch/xtensa/kernel/setup.c
index 23ac2a205e97..44632a20f3d9 100644
--- a/arch/xtensa/kernel/setup.c
+++ b/arch/xtensa/kernel/setup.c
@@ -593,8 +593,7 @@ c_show(struct seq_file *f, void *slot)
(ccount_freq/10000) % 100,
loops_per_jiffy/(500000/HZ),
(loops_per_jiffy/(5000/HZ)) % 100);
-
- seq_printf(f,"flags\t\t: "
+ seq_puts(f, "flags\t\t: "
#if XCHAL_HAVE_NMI
"nmi "
#endif
--
2.12.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xtensa: Use seq_puts() in c_show()
2017-05-07 19:33 [PATCH] xtensa: Use seq_puts() in c_show() SF Markus Elfring
@ 2017-05-08 20:19 ` Max Filippov
0 siblings, 0 replies; 2+ messages in thread
From: Max Filippov @ 2017-05-08 20:19 UTC (permalink / raw)
To: SF Markus Elfring
Cc: Chris Zankel, Günter Röck, Kefeng Wang, Rob Herring,
LKML, kernel-janitors
On Sun, May 7, 2017 at 12:33 PM, SF Markus Elfring
<elfring@users.sourceforge.net> wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 7 May 2017 21:24:51 +0200
>
> A string which did not contain a data format specification should be put
> into a sequence. Thus use the corresponding function "seq_puts".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> arch/xtensa/kernel/setup.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Thanks, applied to my xtensa-fixes branch.
-- Max
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-08 20:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-07 19:33 [PATCH] xtensa: Use seq_puts() in c_show() SF Markus Elfring
2017-05-08 20:19 ` Max Filippov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).