* [PATCH] gpio: mvebu: avoid error message for optional IRQ
@ 2020-03-13 3:42 Chris Packham
2020-03-13 6:45 ` Uwe Kleine-König
2020-03-13 15:07 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Chris Packham @ 2020-03-13 3:42 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, linus.walleij, bgolaszewski
Cc: linux-pwm, linux-gpio, linux-kernel, Chris Packham
platform_get_irq() will generate an error message if the requested irq
is not present
mvebu-gpio f1010140.gpio: IRQ index 3 not found
use platform_get_irq_optional() to avoid the error message being
generated.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
drivers/gpio/gpio-mvebu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
index d2b999c7987f..3c9f4fb3d5a2 100644
--- a/drivers/gpio/gpio-mvebu.c
+++ b/drivers/gpio/gpio-mvebu.c
@@ -1247,7 +1247,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
* pins.
*/
for (i = 0; i < 4; i++) {
- int irq = platform_get_irq(pdev, i);
+ int irq = platform_get_irq_optional(pdev, i);
if (irq < 0)
continue;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: mvebu: avoid error message for optional IRQ
2020-03-13 3:42 [PATCH] gpio: mvebu: avoid error message for optional IRQ Chris Packham
@ 2020-03-13 6:45 ` Uwe Kleine-König
2020-03-13 15:07 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2020-03-13 6:45 UTC (permalink / raw)
To: Chris Packham
Cc: thierry.reding, linus.walleij, bgolaszewski, linux-pwm,
linux-gpio, linux-kernel
Hello,
On Fri, Mar 13, 2020 at 04:42:44PM +1300, Chris Packham wrote:
> platform_get_irq() will generate an error message if the requested irq
> is not present
>
> mvebu-gpio f1010140.gpio: IRQ index 3 not found
>
> use platform_get_irq_optional() to avoid the error message being
> generated.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
LGTM
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: mvebu: avoid error message for optional IRQ
2020-03-13 3:42 [PATCH] gpio: mvebu: avoid error message for optional IRQ Chris Packham
2020-03-13 6:45 ` Uwe Kleine-König
@ 2020-03-13 15:07 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2020-03-13 15:07 UTC (permalink / raw)
To: Chris Packham
Cc: Thierry Reding, Uwe Kleine-König, Linus Walleij, linux-pwm,
linux-gpio, LKML
pt., 13 mar 2020 o 04:42 Chris Packham
<chris.packham@alliedtelesis.co.nz> napisał(a):
>
> platform_get_irq() will generate an error message if the requested irq
> is not present
>
> mvebu-gpio f1010140.gpio: IRQ index 3 not found
>
> use platform_get_irq_optional() to avoid the error message being
> generated.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> drivers/gpio/gpio-mvebu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> index d2b999c7987f..3c9f4fb3d5a2 100644
> --- a/drivers/gpio/gpio-mvebu.c
> +++ b/drivers/gpio/gpio-mvebu.c
> @@ -1247,7 +1247,7 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
> * pins.
> */
> for (i = 0; i < 4; i++) {
> - int irq = platform_get_irq(pdev, i);
> + int irq = platform_get_irq_optional(pdev, i);
>
> if (irq < 0)
> continue;
> --
> 2.25.1
>
Patch applied, thanks!
Bartosz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-13 15:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-13 3:42 [PATCH] gpio: mvebu: avoid error message for optional IRQ Chris Packham
2020-03-13 6:45 ` Uwe Kleine-König
2020-03-13 15:07 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).