* [PATCH v3 0/2] ARM: dts: da850: tilcdc related DT changes @ 2016-11-29 11:57 Bartosz Golaszewski 2016-11-29 11:57 ` [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node Bartosz Golaszewski 2016-11-29 11:57 ` [PATCH v3 2/2] ARM: dts: da850: specify the maximum pixel clock rate for tilcdc Bartosz Golaszewski 0 siblings, 2 replies; 8+ messages in thread From: Bartosz Golaszewski @ 2016-11-29 11:57 UTC (permalink / raw) To: Kevin Hilman, Michael Turquette, Sekhar Nori, Rob Herring, Frank Rowand, Mark Rutland, Peter Ujfalusi, Russell King Cc: LKML, arm-soc, linux-drm, linux-devicetree, Jyri Sarha, Tomi Valkeinen, David Airlie, Laurent Pinchart, Bartosz Golaszewski his series contains the last DT changes required for LCDC support on da850-lcdk. The first one adds the dumb-vga-dac nodes, the second limits the maximum pixel clock rate. v1 -> v2: - drop patch 3/3 (already merged) - use max-pixelclock instead of max-bandwidth for display mode limiting v2 -> v3: - make the commit message in patch [2/2] more detailed - move the max-pixelclock property to da850.dtsi as the limit affects all da850-based boards Bartosz Golaszewski (2): ARM: dts: da850-lcdk: add the dumb-vga-dac node ARM: dts: da850: specify the maximum pixel clock rate for tilcdc arch/arm/boot/dts/da850-lcdk.dts | 58 ++++++++++++++++++++++++++++++++++++++++ arch/arm/boot/dts/da850.dtsi | 18 +++++++++++++ 2 files changed, 76 insertions(+) -- 2.9.3 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node 2016-11-29 11:57 [PATCH v3 0/2] ARM: dts: da850: tilcdc related DT changes Bartosz Golaszewski @ 2016-11-29 11:57 ` Bartosz Golaszewski 2016-12-05 12:49 ` Tomi Valkeinen 2016-12-05 14:32 ` Rob Herring 2016-11-29 11:57 ` [PATCH v3 2/2] ARM: dts: da850: specify the maximum pixel clock rate for tilcdc Bartosz Golaszewski 1 sibling, 2 replies; 8+ messages in thread From: Bartosz Golaszewski @ 2016-11-29 11:57 UTC (permalink / raw) To: Kevin Hilman, Michael Turquette, Sekhar Nori, Rob Herring, Frank Rowand, Mark Rutland, Peter Ujfalusi, Russell King Cc: LKML, arm-soc, linux-drm, linux-devicetree, Jyri Sarha, Tomi Valkeinen, David Airlie, Laurent Pinchart, Bartosz Golaszewski Add the dumb-vga-dac node to the board DT together with corresponding ports and vga connector. This allows to retrieve the edid info from the display automatically. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> --- arch/arm/boot/dts/da850-lcdk.dts | 58 ++++++++++++++++++++++++++++++++++++++++ arch/arm/boot/dts/da850.dtsi | 17 ++++++++++++ 2 files changed, 75 insertions(+) diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts index 711b9ad..d864f11 100644 --- a/arch/arm/boot/dts/da850-lcdk.dts +++ b/arch/arm/boot/dts/da850-lcdk.dts @@ -50,6 +50,53 @@ system-clock-frequency = <24576000>; }; }; + + vga_bridge { + compatible = "dumb-vga-dac"; + pinctrl-names = "default"; + pinctrl-0 = <&lcd_pins>; + #address-cells = <1>; + #size-cells = <0>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + vga_bridge_in: endpoint@0 { + reg = <0>; + remote-endpoint = <&display_out_vga>; + }; + }; + + port@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + + vga_bridge_out: endpoint@0 { + reg = <0>; + remote-endpoint = <&vga_con_in>; + }; + }; + }; + }; + + vga { + compatible = "vga-connector"; + + ddc-i2c-bus = <&i2c0>; + + port { + vga_con_in: endpoint { + remote-endpoint = <&vga_bridge_out>; + }; + }; + }; }; &pmx_core { @@ -235,3 +282,14 @@ &memctrl { status = "okay"; }; + +&display { + status = "okay"; +}; + +&display_out { + display_out_vga: endpoint@0 { + reg = <0>; + remote-endpoint = <&vga_bridge_in>; + }; +}; diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index 4070619..5f4ba2e 100644 --- a/arch/arm/boot/dts/da850.dtsi +++ b/arch/arm/boot/dts/da850.dtsi @@ -454,6 +454,23 @@ reg = <0x213000 0x1000>; interrupts = <52>; status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + display_in: port@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + }; + + display_out: port@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + }; + }; }; }; aemif: aemif@68000000 { -- 2.9.3 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node 2016-11-29 11:57 ` [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node Bartosz Golaszewski @ 2016-12-05 12:49 ` Tomi Valkeinen 2016-12-06 13:02 ` Bartosz Golaszewski 2016-12-05 14:32 ` Rob Herring 1 sibling, 1 reply; 8+ messages in thread From: Tomi Valkeinen @ 2016-12-05 12:49 UTC (permalink / raw) To: Bartosz Golaszewski, Kevin Hilman, Michael Turquette, Sekhar Nori, Rob Herring, Frank Rowand, Mark Rutland, Peter Ujfalusi, Russell King Cc: LKML, arm-soc, linux-drm, linux-devicetree, Jyri Sarha, David Airlie, Laurent Pinchart [-- Attachment #1.1: Type: text/plain, Size: 3213 bytes --] On 29/11/16 13:57, Bartosz Golaszewski wrote: > Add the dumb-vga-dac node to the board DT together with corresponding > ports and vga connector. This allows to retrieve the edid info from > the display automatically. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > arch/arm/boot/dts/da850-lcdk.dts | 58 ++++++++++++++++++++++++++++++++++++++++ > arch/arm/boot/dts/da850.dtsi | 17 ++++++++++++ > 2 files changed, 75 insertions(+) > > diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts > index 711b9ad..d864f11 100644 > --- a/arch/arm/boot/dts/da850-lcdk.dts > +++ b/arch/arm/boot/dts/da850-lcdk.dts > @@ -50,6 +50,53 @@ > system-clock-frequency = <24576000>; > }; > }; > + > + vga_bridge { > + compatible = "dumb-vga-dac"; > + pinctrl-names = "default"; > + pinctrl-0 = <&lcd_pins>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; > + > + vga_bridge_in: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&display_out_vga>; > + }; > + }; > + > + port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + vga_bridge_out: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&vga_con_in>; > + }; > + }; > + }; > + }; > + > + vga { > + compatible = "vga-connector"; > + > + ddc-i2c-bus = <&i2c0>; > + > + port { > + vga_con_in: endpoint { > + remote-endpoint = <&vga_bridge_out>; > + }; > + }; > + }; > }; > > &pmx_core { > @@ -235,3 +282,14 @@ > &memctrl { > status = "okay"; > }; > + > +&display { > + status = "okay"; > +}; > + > +&display_out { > + display_out_vga: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&vga_bridge_in>; > + }; > +}; > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > index 4070619..5f4ba2e 100644 > --- a/arch/arm/boot/dts/da850.dtsi > +++ b/arch/arm/boot/dts/da850.dtsi > @@ -454,6 +454,23 @@ > reg = <0x213000 0x1000>; > interrupts = <52>; > status = "disabled"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + display_in: port@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; > + }; > + > + display_out: port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + }; > + }; > }; It's a bit difficult to follow this as there's been so many patches going around. But I take the above is the LCDC node in the base da850 dtsi file? In that case, what is the display_in supposed to present? It's the first node in the "display chain", so it has no input. Also, don't touch da850.dtsi here, just add the "ports" node in the da850-lcdk.dts file. If the da850.dtsi has not been merged yet, I'd change the name of the lcdc node to something else than "display". It's rather vague. If it's named "lcdc", reading da850-lcdk.dts becomes much easier, as you'll refer to "lcdc". Tomi [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node 2016-12-05 12:49 ` Tomi Valkeinen @ 2016-12-06 13:02 ` Bartosz Golaszewski 2016-12-06 15:03 ` Sekhar Nori 0 siblings, 1 reply; 8+ messages in thread From: Bartosz Golaszewski @ 2016-12-06 13:02 UTC (permalink / raw) To: Tomi Valkeinen Cc: Kevin Hilman, Michael Turquette, Sekhar Nori, Rob Herring, Frank Rowand, Mark Rutland, Peter Ujfalusi, Russell King, LKML, arm-soc, linux-drm, linux-devicetree, Jyri Sarha, David Airlie, Laurent Pinchart 2016-12-05 13:49 GMT+01:00 Tomi Valkeinen <tomi.valkeinen@ti.com>: > On 29/11/16 13:57, Bartosz Golaszewski wrote: >> Add the dumb-vga-dac node to the board DT together with corresponding >> ports and vga connector. This allows to retrieve the edid info from >> the display automatically. >> > > It's a bit difficult to follow this as there's been so many patches > going around. But I take the above is the LCDC node in the base da850 > dtsi file? In that case, what is the display_in supposed to present? > It's the first node in the "display chain", so it has no input. > > Also, don't touch da850.dtsi here, just add the "ports" node in the > da850-lcdk.dts file. > > If the da850.dtsi has not been merged yet, I'd change the name of the > lcdc node to something else than "display". It's rather vague. If it's > named "lcdc", reading da850-lcdk.dts becomes much easier, as you'll > refer to "lcdc". > The node is already in Sekhar's branch. Thanks, Bartosz ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node 2016-12-06 13:02 ` Bartosz Golaszewski @ 2016-12-06 15:03 ` Sekhar Nori 2016-12-06 15:06 ` Bartosz Golaszewski 0 siblings, 1 reply; 8+ messages in thread From: Sekhar Nori @ 2016-12-06 15:03 UTC (permalink / raw) To: Bartosz Golaszewski, Tomi Valkeinen Cc: Kevin Hilman, Michael Turquette, Rob Herring, Frank Rowand, Mark Rutland, Peter Ujfalusi, Russell King, LKML, arm-soc, linux-drm, linux-devicetree, Jyri Sarha, David Airlie, Laurent Pinchart On Tuesday 06 December 2016 06:32 PM, Bartosz Golaszewski wrote: > 2016-12-05 13:49 GMT+01:00 Tomi Valkeinen <tomi.valkeinen@ti.com>: >> On 29/11/16 13:57, Bartosz Golaszewski wrote: >>> Add the dumb-vga-dac node to the board DT together with corresponding >>> ports and vga connector. This allows to retrieve the edid info from >>> the display automatically. >>> >> >> It's a bit difficult to follow this as there's been so many patches >> going around. But I take the above is the LCDC node in the base da850 >> dtsi file? In that case, what is the display_in supposed to present? >> It's the first node in the "display chain", so it has no input. >> >> Also, don't touch da850.dtsi here, just add the "ports" node in the >> da850-lcdk.dts file. >> >> If the da850.dtsi has not been merged yet, I'd change the name of the >> lcdc node to something else than "display". It's rather vague. If it's >> named "lcdc", reading da850-lcdk.dts becomes much easier, as you'll >> refer to "lcdc". >> > > The node is already in Sekhar's branch. The node name should be 'display' as thats the ePAPR 1.1 generic name recommendation. The label is also set to 'display' though and that can be changed to lcdc. A pre-patch to fix that before we modify the node further is welcome. Thanks, Sekhar ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node 2016-12-06 15:03 ` Sekhar Nori @ 2016-12-06 15:06 ` Bartosz Golaszewski 0 siblings, 0 replies; 8+ messages in thread From: Bartosz Golaszewski @ 2016-12-06 15:06 UTC (permalink / raw) To: Sekhar Nori Cc: Tomi Valkeinen, Kevin Hilman, Michael Turquette, Rob Herring, Frank Rowand, Mark Rutland, Peter Ujfalusi, Russell King, LKML, arm-soc, linux-drm, linux-devicetree, Jyri Sarha, David Airlie, Laurent Pinchart 2016-12-06 16:03 GMT+01:00 Sekhar Nori <nsekhar@ti.com>: > On Tuesday 06 December 2016 06:32 PM, Bartosz Golaszewski wrote: >> 2016-12-05 13:49 GMT+01:00 Tomi Valkeinen <tomi.valkeinen@ti.com>: >>> On 29/11/16 13:57, Bartosz Golaszewski wrote: >>>> Add the dumb-vga-dac node to the board DT together with corresponding >>>> ports and vga connector. This allows to retrieve the edid info from >>>> the display automatically. >>>> >>> >>> It's a bit difficult to follow this as there's been so many patches >>> going around. But I take the above is the LCDC node in the base da850 >>> dtsi file? In that case, what is the display_in supposed to present? >>> It's the first node in the "display chain", so it has no input. >>> >>> Also, don't touch da850.dtsi here, just add the "ports" node in the >>> da850-lcdk.dts file. >>> >>> If the da850.dtsi has not been merged yet, I'd change the name of the >>> lcdc node to something else than "display". It's rather vague. If it's >>> named "lcdc", reading da850-lcdk.dts becomes much easier, as you'll >>> refer to "lcdc". >>> >> >> The node is already in Sekhar's branch. > > The node name should be 'display' as thats the ePAPR 1.1 generic name > recommendation. The label is also set to 'display' though and that can > be changed to lcdc. > > A pre-patch to fix that before we modify the node further is welcome. > > Thanks, > Sekhar I'll include this in v5 together with the change requested by Laurent. Thanks, Bartosz ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node 2016-11-29 11:57 ` [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node Bartosz Golaszewski 2016-12-05 12:49 ` Tomi Valkeinen @ 2016-12-05 14:32 ` Rob Herring 1 sibling, 0 replies; 8+ messages in thread From: Rob Herring @ 2016-12-05 14:32 UTC (permalink / raw) To: Bartosz Golaszewski Cc: Kevin Hilman, Michael Turquette, Sekhar Nori, Frank Rowand, Mark Rutland, Peter Ujfalusi, Russell King, LKML, arm-soc, linux-drm, linux-devicetree, Jyri Sarha, Tomi Valkeinen, David Airlie, Laurent Pinchart On Tue, Nov 29, 2016 at 5:57 AM, Bartosz Golaszewski <bgolaszewski@baylibre.com> wrote: > Add the dumb-vga-dac node to the board DT together with corresponding > ports and vga connector. This allows to retrieve the edid info from > the display automatically. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > arch/arm/boot/dts/da850-lcdk.dts | 58 ++++++++++++++++++++++++++++++++++++++++ > arch/arm/boot/dts/da850.dtsi | 17 ++++++++++++ > 2 files changed, 75 insertions(+) > > diff --git a/arch/arm/boot/dts/da850-lcdk.dts b/arch/arm/boot/dts/da850-lcdk.dts > index 711b9ad..d864f11 100644 > --- a/arch/arm/boot/dts/da850-lcdk.dts > +++ b/arch/arm/boot/dts/da850-lcdk.dts > @@ -50,6 +50,53 @@ > system-clock-frequency = <24576000>; > }; > }; > + > + vga_bridge { s/_/-/ > + compatible = "dumb-vga-dac"; > + pinctrl-names = "default"; > + pinctrl-0 = <&lcd_pins>; Are these pins from the LCD controller? They should be part of the LCD controller node. Rob ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 2/2] ARM: dts: da850: specify the maximum pixel clock rate for tilcdc 2016-11-29 11:57 [PATCH v3 0/2] ARM: dts: da850: tilcdc related DT changes Bartosz Golaszewski 2016-11-29 11:57 ` [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node Bartosz Golaszewski @ 2016-11-29 11:57 ` Bartosz Golaszewski 1 sibling, 0 replies; 8+ messages in thread From: Bartosz Golaszewski @ 2016-11-29 11:57 UTC (permalink / raw) To: Kevin Hilman, Michael Turquette, Sekhar Nori, Rob Herring, Frank Rowand, Mark Rutland, Peter Ujfalusi, Russell King Cc: LKML, arm-soc, linux-drm, linux-devicetree, Jyri Sarha, Tomi Valkeinen, David Airlie, Laurent Pinchart, Bartosz Golaszewski At maximum CPU frequency of 300 MHz the maximum pixel clock frequency is 37.5 MHz[1]. We must filter out any mode for which the calculated pixel clock rate would exceed this value. Specify the max-pixelclock property for the display node for da850-lcdk. [1] http://processors.wiki.ti.com/index.php/OMAP-L1x/C674x/AM1x_LCD_Controller_(LCDC)_Throughput_and_Optimization_Techniques Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> --- arch/arm/boot/dts/da850.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi index 5f4ba2e..00692d3 100644 --- a/arch/arm/boot/dts/da850.dtsi +++ b/arch/arm/boot/dts/da850.dtsi @@ -453,6 +453,7 @@ compatible = "ti,da850-tilcdc"; reg = <0x213000 0x1000>; interrupts = <52>; + max-pixelclock = <37500>; status = "disabled"; ports { -- 2.9.3 ^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-12-06 15:15 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-11-29 11:57 [PATCH v3 0/2] ARM: dts: da850: tilcdc related DT changes Bartosz Golaszewski 2016-11-29 11:57 ` [PATCH v3 1/2] ARM: dts: da850-lcdk: add the dumb-vga-dac node Bartosz Golaszewski 2016-12-05 12:49 ` Tomi Valkeinen 2016-12-06 13:02 ` Bartosz Golaszewski 2016-12-06 15:03 ` Sekhar Nori 2016-12-06 15:06 ` Bartosz Golaszewski 2016-12-05 14:32 ` Rob Herring 2016-11-29 11:57 ` [PATCH v3 2/2] ARM: dts: da850: specify the maximum pixel clock rate for tilcdc Bartosz Golaszewski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).