From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Zou Wei <zou_wei@huawei.com>
Cc: Sekhar Nori <nsekhar@ti.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] bus: da8xx-mstpri: add missing MODULE_DEVICE_TABLE
Date: Wed, 12 May 2021 13:40:21 +0200 [thread overview]
Message-ID: <CAMpxmJWukRCivVE6pVhQm=ob98gDt1dn2hB_7GrisrSQ0Kc+8Q@mail.gmail.com> (raw)
In-Reply-To: <1620714150-106682-1-git-send-email-zou_wei@huawei.com>
On Tue, May 11, 2021 at 8:06 AM Zou Wei <zou_wei@huawei.com> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/bus/da8xx-mstpri.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/da8xx-mstpri.c b/drivers/bus/da8xx-mstpri.c
> index ee4c023..ff158a1 100644
> --- a/drivers/bus/da8xx-mstpri.c
> +++ b/drivers/bus/da8xx-mstpri.c
> @@ -249,6 +249,7 @@ static const struct of_device_id da8xx_mstpri_of_match[] = {
> { .compatible = "ti,da850-mstpri", },
> { },
> };
> +MODULE_DEVICE_TABLE(of, da8xx_mstpri_of_match);
>
> static struct platform_driver da8xx_mstpri_driver = {
> .probe = da8xx_mstpri_probe,
> --
> 2.6.2
>
This module is always built-in. I don't think we require the module
device table for non-dynamic modules.
Bartosz
prev parent reply other threads:[~2021-05-12 11:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 6:22 [PATCH -next] bus: da8xx-mstpri: add missing MODULE_DEVICE_TABLE Zou Wei
2021-05-12 11:40 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMpxmJWukRCivVE6pVhQm=ob98gDt1dn2hB_7GrisrSQ0Kc+8Q@mail.gmail.com' \
--to=bgolaszewski@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).