linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] bus: da8xx-mstpri: add missing MODULE_DEVICE_TABLE
@ 2021-05-11  6:22 Zou Wei
  2021-05-12 11:40 ` Bartosz Golaszewski
  0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2021-05-11  6:22 UTC (permalink / raw)
  To: bgolaszewski, nsekhar; +Cc: linux-kernel, Zou Wei

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
 drivers/bus/da8xx-mstpri.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bus/da8xx-mstpri.c b/drivers/bus/da8xx-mstpri.c
index ee4c023..ff158a1 100644
--- a/drivers/bus/da8xx-mstpri.c
+++ b/drivers/bus/da8xx-mstpri.c
@@ -249,6 +249,7 @@ static const struct of_device_id da8xx_mstpri_of_match[] = {
 	{ .compatible = "ti,da850-mstpri", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, da8xx_mstpri_of_match);
 
 static struct platform_driver da8xx_mstpri_driver = {
 	.probe = da8xx_mstpri_probe,
-- 
2.6.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] bus: da8xx-mstpri: add missing MODULE_DEVICE_TABLE
  2021-05-11  6:22 [PATCH -next] bus: da8xx-mstpri: add missing MODULE_DEVICE_TABLE Zou Wei
@ 2021-05-12 11:40 ` Bartosz Golaszewski
  0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2021-05-12 11:40 UTC (permalink / raw)
  To: Zou Wei; +Cc: Sekhar Nori, LKML

On Tue, May 11, 2021 at 8:06 AM Zou Wei <zou_wei@huawei.com> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/bus/da8xx-mstpri.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bus/da8xx-mstpri.c b/drivers/bus/da8xx-mstpri.c
> index ee4c023..ff158a1 100644
> --- a/drivers/bus/da8xx-mstpri.c
> +++ b/drivers/bus/da8xx-mstpri.c
> @@ -249,6 +249,7 @@ static const struct of_device_id da8xx_mstpri_of_match[] = {
>         { .compatible = "ti,da850-mstpri", },
>         { },
>  };
> +MODULE_DEVICE_TABLE(of, da8xx_mstpri_of_match);
>
>  static struct platform_driver da8xx_mstpri_driver = {
>         .probe = da8xx_mstpri_probe,
> --
> 2.6.2
>

This module is always built-in. I don't think we require the module
device table for non-dynamic modules.

Bartosz

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-12 11:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11  6:22 [PATCH -next] bus: da8xx-mstpri: add missing MODULE_DEVICE_TABLE Zou Wei
2021-05-12 11:40 ` Bartosz Golaszewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).