* [PATCH] gpio: gpio-tps65910: remove platform_set_drvdata() + cleanup probe
@ 2021-05-21 18:17 Alexandru Ardelean
2021-05-25 14:34 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Alexandru Ardelean @ 2021-05-21 18:17 UTC (permalink / raw)
To: linux-gpio, linux-kernel; +Cc: linus.walleij, bgolaszewski, Alexandru Ardelean
The platform_set_drvdata() call is only useful if we need to retrieve back
the private information.
Since the driver doesn't do that, it's not useful to have it.
If this is removed, we can also just do a direct return on
devm_gpiochip_add_data(). We don't need to print that this call failed as
there are other ways to log/see this during probe.
Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
---
drivers/gpio/gpio-tps65910.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio-tps65910.c b/drivers/gpio/gpio-tps65910.c
index 0c0b445c75c0..7fa8c841081f 100644
--- a/drivers/gpio/gpio-tps65910.c
+++ b/drivers/gpio/gpio-tps65910.c
@@ -165,16 +165,8 @@ static int tps65910_gpio_probe(struct platform_device *pdev)
}
skip_init:
- ret = devm_gpiochip_add_data(&pdev->dev, &tps65910_gpio->gpio_chip,
- tps65910_gpio);
- if (ret < 0) {
- dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
- return ret;
- }
-
- platform_set_drvdata(pdev, tps65910_gpio);
-
- return ret;
+ return devm_gpiochip_add_data(&pdev->dev, &tps65910_gpio->gpio_chip,
+ tps65910_gpio);
}
static struct platform_driver tps65910_gpio_driver = {
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: gpio-tps65910: remove platform_set_drvdata() + cleanup probe
2021-05-21 18:17 [PATCH] gpio: gpio-tps65910: remove platform_set_drvdata() + cleanup probe Alexandru Ardelean
@ 2021-05-25 14:34 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2021-05-25 14:34 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: linux-gpio, LKML, Linus Walleij
On Fri, May 21, 2021 at 8:17 PM Alexandru Ardelean
<aardelean@deviqon.com> wrote:
>
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
> drivers/gpio/gpio-tps65910.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tps65910.c b/drivers/gpio/gpio-tps65910.c
> index 0c0b445c75c0..7fa8c841081f 100644
> --- a/drivers/gpio/gpio-tps65910.c
> +++ b/drivers/gpio/gpio-tps65910.c
> @@ -165,16 +165,8 @@ static int tps65910_gpio_probe(struct platform_device *pdev)
> }
>
> skip_init:
> - ret = devm_gpiochip_add_data(&pdev->dev, &tps65910_gpio->gpio_chip,
> - tps65910_gpio);
> - if (ret < 0) {
> - dev_err(&pdev->dev, "Could not register gpiochip, %d\n", ret);
> - return ret;
> - }
> -
> - platform_set_drvdata(pdev, tps65910_gpio);
> -
> - return ret;
> + return devm_gpiochip_add_data(&pdev->dev, &tps65910_gpio->gpio_chip,
> + tps65910_gpio);
> }
>
> static struct platform_driver tps65910_gpio_driver = {
> --
> 2.31.1
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-25 14:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 18:17 [PATCH] gpio: gpio-tps65910: remove platform_set_drvdata() + cleanup probe Alexandru Ardelean
2021-05-25 14:34 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).