* [PATCH v2] gpio: pch: Use dev_get_drvdata
@ 2019-07-23 8:39 Chuhong Yuan
2019-07-23 9:49 ` Bartosz Golaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Chuhong Yuan @ 2019-07-23 8:39 UTC (permalink / raw)
Cc: Andy Shevchenko, Linus Walleij, Bartosz Golaszewski, linux-gpio,
linux-kernel, Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata,
use dev_get_drvdata to make code simpler.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
Changes in v2:
- Change the subject line to gpio: pch: ...
drivers/gpio/gpio-pch.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index 1d99293096f2..3f3d9a94b709 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -409,8 +409,7 @@ static int pch_gpio_probe(struct pci_dev *pdev,
static int __maybe_unused pch_gpio_suspend(struct device *dev)
{
- struct pci_dev *pdev = to_pci_dev(dev);
- struct pch_gpio *chip = pci_get_drvdata(pdev);
+ struct pch_gpio *chip = dev_get_drvdata(dev);
unsigned long flags;
spin_lock_irqsave(&chip->spinlock, flags);
@@ -422,8 +421,7 @@ static int __maybe_unused pch_gpio_suspend(struct device *dev)
static int __maybe_unused pch_gpio_resume(struct device *dev)
{
- struct pci_dev *pdev = to_pci_dev(dev);
- struct pch_gpio *chip = pci_get_drvdata(pdev);
+ struct pch_gpio *chip = dev_get_drvdata(dev);
unsigned long flags;
spin_lock_irqsave(&chip->spinlock, flags);
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] gpio: pch: Use dev_get_drvdata
2019-07-23 8:39 [PATCH v2] gpio: pch: Use dev_get_drvdata Chuhong Yuan
@ 2019-07-23 9:49 ` Bartosz Golaszewski
2019-07-23 15:59 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Bartosz Golaszewski @ 2019-07-23 9:49 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: Andy Shevchenko, Linus Walleij, linux-gpio, LKML
wt., 23 lip 2019 o 10:39 Chuhong Yuan <hslester96@gmail.com> napisał(a):
>
> Instead of using to_pci_dev + pci_get_drvdata,
> use dev_get_drvdata to make code simpler.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> Changes in v2:
> - Change the subject line to gpio: pch: ...
>
> drivers/gpio/gpio-pch.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
> index 1d99293096f2..3f3d9a94b709 100644
> --- a/drivers/gpio/gpio-pch.c
> +++ b/drivers/gpio/gpio-pch.c
> @@ -409,8 +409,7 @@ static int pch_gpio_probe(struct pci_dev *pdev,
>
> static int __maybe_unused pch_gpio_suspend(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct pch_gpio *chip = pci_get_drvdata(pdev);
> + struct pch_gpio *chip = dev_get_drvdata(dev);
> unsigned long flags;
>
> spin_lock_irqsave(&chip->spinlock, flags);
> @@ -422,8 +421,7 @@ static int __maybe_unused pch_gpio_suspend(struct device *dev)
>
> static int __maybe_unused pch_gpio_resume(struct device *dev)
> {
> - struct pci_dev *pdev = to_pci_dev(dev);
> - struct pch_gpio *chip = pci_get_drvdata(pdev);
> + struct pch_gpio *chip = dev_get_drvdata(dev);
> unsigned long flags;
>
> spin_lock_irqsave(&chip->spinlock, flags);
> --
> 2.20.1
>
Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] gpio: pch: Use dev_get_drvdata
2019-07-23 9:49 ` Bartosz Golaszewski
@ 2019-07-23 15:59 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2019-07-23 15:59 UTC (permalink / raw)
To: Bartosz Golaszewski; +Cc: Chuhong Yuan, Linus Walleij, linux-gpio, LKML
On Tue, Jul 23, 2019 at 11:49:46AM +0200, Bartosz Golaszewski wrote:
> wt., 23 lip 2019 o 10:39 Chuhong Yuan <hslester96@gmail.com> napisał(a):
> >
> > Instead of using to_pci_dev + pci_get_drvdata,
> > use dev_get_drvdata to make code simpler.
> >
> > Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> > ---
> > Changes in v2:
> > - Change the subject line to gpio: pch: ...
> >
> > drivers/gpio/gpio-pch.c | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
> > index 1d99293096f2..3f3d9a94b709 100644
> > --- a/drivers/gpio/gpio-pch.c
> > +++ b/drivers/gpio/gpio-pch.c
> > @@ -409,8 +409,7 @@ static int pch_gpio_probe(struct pci_dev *pdev,
> >
> > static int __maybe_unused pch_gpio_suspend(struct device *dev)
> > {
> > - struct pci_dev *pdev = to_pci_dev(dev);
> > - struct pch_gpio *chip = pci_get_drvdata(pdev);
> > + struct pch_gpio *chip = dev_get_drvdata(dev);
> > unsigned long flags;
> >
> > spin_lock_irqsave(&chip->spinlock, flags);
> > @@ -422,8 +421,7 @@ static int __maybe_unused pch_gpio_suspend(struct device *dev)
> >
> > static int __maybe_unused pch_gpio_resume(struct device *dev)
> > {
> > - struct pci_dev *pdev = to_pci_dev(dev);
> > - struct pch_gpio *chip = pci_get_drvdata(pdev);
> > + struct pch_gpio *chip = dev_get_drvdata(dev);
> > unsigned long flags;
> >
> > spin_lock_irqsave(&chip->spinlock, flags);
> > --
> > 2.20.1
> >
>
> Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-23 15:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 8:39 [PATCH v2] gpio: pch: Use dev_get_drvdata Chuhong Yuan
2019-07-23 9:49 ` Bartosz Golaszewski
2019-07-23 15:59 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).