* [PATCH] hid-debug: Show application usage for each collection.
@ 2011-08-15 23:39 jeffbrown
2011-08-16 7:32 ` Benjamin Tissoires
0 siblings, 1 reply; 6+ messages in thread
From: jeffbrown @ 2011-08-15 23:39 UTC (permalink / raw)
To: linux-input; +Cc: linux-kernel, jkosina, rydberg, Jeff Brown
From: Jeff Brown <jeffbrown@android.com>
Signed-off-by: jeffbrown@android.com
---
drivers/hid/hid-debug.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
index bae4874..9a243ca 100644
--- a/drivers/hid/hid-debug.c
+++ b/drivers/hid/hid-debug.c
@@ -450,6 +450,11 @@ void hid_dump_field(struct hid_field *field, int n, struct seq_file *f) {
seq_printf(f, "Logical(");
hid_resolv_usage(field->logical, f); seq_printf(f, ")\n");
}
+ if (field->application) {
+ tab(n, f);
+ seq_printf(f, "Application(");
+ hid_resolv_usage(field->application, f); seq_printf(f, ")\n");
+ }
tab(n, f); seq_printf(f, "Usage(%d)\n", field->maxusage);
for (j = 0; j < field->maxusage; j++) {
tab(n+2, f); hid_resolv_usage(field->usage[j].hid, f); seq_printf(f, "\n");
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] hid-debug: Show application usage for each collection.
2011-08-15 23:39 [PATCH] hid-debug: Show application usage for each collection jeffbrown
@ 2011-08-16 7:32 ` Benjamin Tissoires
2011-08-16 9:37 ` Jiri Kosina
2011-08-24 18:58 ` Jeffrey Brown
0 siblings, 2 replies; 6+ messages in thread
From: Benjamin Tissoires @ 2011-08-16 7:32 UTC (permalink / raw)
To: jeffbrown; +Cc: linux-input, linux-kernel, jkosina, rydberg
On Tue, Aug 16, 2011 at 01:39, <jeffbrown@android.com> wrote:
> From: Jeff Brown <jeffbrown@android.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@logitech.com>
>
> Signed-off-by: jeffbrown@android.com
> ---
> drivers/hid/hid-debug.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
> index bae4874..9a243ca 100644
> --- a/drivers/hid/hid-debug.c
> +++ b/drivers/hid/hid-debug.c
> @@ -450,6 +450,11 @@ void hid_dump_field(struct hid_field *field, int n, struct seq_file *f) {
> seq_printf(f, "Logical(");
> hid_resolv_usage(field->logical, f); seq_printf(f, ")\n");
> }
> + if (field->application) {
> + tab(n, f);
> + seq_printf(f, "Application(");
> + hid_resolv_usage(field->application, f); seq_printf(f, ")\n");
> + }
> tab(n, f); seq_printf(f, "Usage(%d)\n", field->maxusage);
> for (j = 0; j < field->maxusage; j++) {
> tab(n+2, f); hid_resolv_usage(field->usage[j].hid, f); seq_printf(f, "\n");
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hid-debug: Show application usage for each collection.
2011-08-16 7:32 ` Benjamin Tissoires
@ 2011-08-16 9:37 ` Jiri Kosina
2011-08-24 18:58 ` Jeffrey Brown
1 sibling, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2011-08-16 9:37 UTC (permalink / raw)
To: Benjamin Tissoires; +Cc: jeffbrown, linux-input, linux-kernel, rydberg
On Tue, 16 Aug 2011, Benjamin Tissoires wrote:
> > From: Jeff Brown <jeffbrown@android.com>
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@logitech.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hid-debug: Show application usage for each collection.
2011-08-16 7:32 ` Benjamin Tissoires
2011-08-16 9:37 ` Jiri Kosina
@ 2011-08-24 18:58 ` Jeffrey Brown
2011-08-24 19:04 ` Jiri Kosina
1 sibling, 1 reply; 6+ messages in thread
From: Jeffrey Brown @ 2011-08-24 18:58 UTC (permalink / raw)
To: Benjamin Tissoires, jkosina; +Cc: linux-input, linux-kernel, rydberg
On Tue, Aug 16, 2011 at 12:32 AM, Benjamin Tissoires
<benjamin.tissoires@gmail.com> wrote:
> On Tue, Aug 16, 2011 at 01:39, <jeffbrown@android.com> wrote:
>> From: Jeff Brown <jeffbrown@android.com>
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@logitech.com>
Just a friendly ping.
Do I need to do anything more on this, or on the other patch to hid-multitouch?
>> Signed-off-by: jeffbrown@android.com
>> ---
>> drivers/hid/hid-debug.c | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
>> index bae4874..9a243ca 100644
>> --- a/drivers/hid/hid-debug.c
>> +++ b/drivers/hid/hid-debug.c
>> @@ -450,6 +450,11 @@ void hid_dump_field(struct hid_field *field, int n, struct seq_file *f) {
>> seq_printf(f, "Logical(");
>> hid_resolv_usage(field->logical, f); seq_printf(f, ")\n");
>> }
>> + if (field->application) {
>> + tab(n, f);
>> + seq_printf(f, "Application(");
>> + hid_resolv_usage(field->application, f); seq_printf(f, ")\n");
>> + }
>> tab(n, f); seq_printf(f, "Usage(%d)\n", field->maxusage);
>> for (j = 0; j < field->maxusage; j++) {
>> tab(n+2, f); hid_resolv_usage(field->usage[j].hid, f); seq_printf(f, "\n");
>> --
>> 1.7.0.4
>>
>> --
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hid-debug: Show application usage for each collection.
2011-08-24 18:58 ` Jeffrey Brown
@ 2011-08-24 19:04 ` Jiri Kosina
2011-08-24 19:05 ` Jeffrey Brown
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Kosina @ 2011-08-24 19:04 UTC (permalink / raw)
To: Jeffrey Brown; +Cc: Benjamin Tissoires, linux-input, linux-kernel, rydberg
On Wed, 24 Aug 2011, Jeffrey Brown wrote:
> >> From: Jeff Brown <jeffbrown@android.com>
> >
> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@logitech.com>
>
> Just a friendly ping.
>
> Do I need to do anything more on this, or on the other patch to
> hid-multitouch?
Hi Jeffrey,
it's queued in my tree, 'upstream' branch.
[1] http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=summary
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] hid-debug: Show application usage for each collection.
2011-08-24 19:04 ` Jiri Kosina
@ 2011-08-24 19:05 ` Jeffrey Brown
0 siblings, 0 replies; 6+ messages in thread
From: Jeffrey Brown @ 2011-08-24 19:05 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Benjamin Tissoires, linux-input, linux-kernel, rydberg
On Wed, Aug 24, 2011 at 12:04 PM, Jiri Kosina <jkosina@suse.cz> wrote:
> Hi Jeffrey,
>
> it's queued in my tree, 'upstream' branch.
>
> [1] http://git.kernel.org/?p=linux/kernel/git/jikos/hid.git;a=summary
Great! Thanks.
Jeff.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-08-24 19:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-15 23:39 [PATCH] hid-debug: Show application usage for each collection jeffbrown
2011-08-16 7:32 ` Benjamin Tissoires
2011-08-16 9:37 ` Jiri Kosina
2011-08-24 18:58 ` Jeffrey Brown
2011-08-24 19:04 ` Jiri Kosina
2011-08-24 19:05 ` Jeffrey Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).