* [PATCH] of: of_reserved_mem: Increase limit on number of reserved regions
@ 2020-02-24 18:02 Isaac J. Manjarres
2020-02-25 21:08 ` Rob Herring
2020-02-26 9:01 ` Geert Uytterhoeven
0 siblings, 2 replies; 3+ messages in thread
From: Isaac J. Manjarres @ 2020-02-24 18:02 UTC (permalink / raw)
To: robh+dt, frowand.list
Cc: Patrick Daly, devicetree, linux-kernel, lmark, pratikp,
kernel-team, Isaac J. Manjarres
From: Patrick Daly <pdaly@codeaurora.org>
Certain SoCs need to support a large amount of reserved memory
regions. For example, Qualcomm's SM8150 SoC requires that 20
regions of memory be reserved for a variety of reasons (e.g.
loading a peripheral subsystem's firmware image into a
particular space).
When adding more reserved memory regions to cater to different
usecases, the remaining number of reserved memory regions--12
to be exact--becomes too small. Thus, double the existing
limit of reserved memory regions.
Signed-off-by: Patrick Daly <pdaly@codeaurora.org>
Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
---
drivers/of/of_reserved_mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
index 6bd610e..1a84bc0 100644
--- a/drivers/of/of_reserved_mem.c
+++ b/drivers/of/of_reserved_mem.c
@@ -22,7 +22,7 @@
#include <linux/slab.h>
#include <linux/memblock.h>
-#define MAX_RESERVED_REGIONS 32
+#define MAX_RESERVED_REGIONS 64
static struct reserved_mem reserved_mem[MAX_RESERVED_REGIONS];
static int reserved_mem_count;
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] of: of_reserved_mem: Increase limit on number of reserved regions
2020-02-24 18:02 [PATCH] of: of_reserved_mem: Increase limit on number of reserved regions Isaac J. Manjarres
@ 2020-02-25 21:08 ` Rob Herring
2020-02-26 9:01 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2020-02-25 21:08 UTC (permalink / raw)
To: Isaac J. Manjarres
Cc: robh+dt, frowand.list, Patrick Daly, devicetree, linux-kernel,
lmark, pratikp, kernel-team, Isaac J. Manjarres
On Mon, 24 Feb 2020 10:02:32 -0800, "Isaac J. Manjarres" wrote:
> From: Patrick Daly <pdaly@codeaurora.org>
>
> Certain SoCs need to support a large amount of reserved memory
> regions. For example, Qualcomm's SM8150 SoC requires that 20
> regions of memory be reserved for a variety of reasons (e.g.
> loading a peripheral subsystem's firmware image into a
> particular space).
>
> When adding more reserved memory regions to cater to different
> usecases, the remaining number of reserved memory regions--12
> to be exact--becomes too small. Thus, double the existing
> limit of reserved memory regions.
>
> Signed-off-by: Patrick Daly <pdaly@codeaurora.org>
> Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
> ---
> drivers/of/of_reserved_mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] of: of_reserved_mem: Increase limit on number of reserved regions
2020-02-24 18:02 [PATCH] of: of_reserved_mem: Increase limit on number of reserved regions Isaac J. Manjarres
2020-02-25 21:08 ` Rob Herring
@ 2020-02-26 9:01 ` Geert Uytterhoeven
1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-02-26 9:01 UTC (permalink / raw)
To: Isaac J. Manjarres
Cc: Rob Herring, Frank Rowand, Patrick Daly,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, lmark, Pratik Patel,
Android Kernel Team
Hi Isaac,
On Mon, Feb 24, 2020 at 7:03 PM Isaac J. Manjarres
<isaacm@codeaurora.org> wrote:
> From: Patrick Daly <pdaly@codeaurora.org>
>
> Certain SoCs need to support a large amount of reserved memory
> regions. For example, Qualcomm's SM8150 SoC requires that 20
> regions of memory be reserved for a variety of reasons (e.g.
> loading a peripheral subsystem's firmware image into a
> particular space).
>
> When adding more reserved memory regions to cater to different
> usecases, the remaining number of reserved memory regions--12
> to be exact--becomes too small. Thus, double the existing
> limit of reserved memory regions.
>
> Signed-off-by: Patrick Daly <pdaly@codeaurora.org>
> Signed-off-by: Isaac J. Manjarres <isaacm@codeaurora.org>
Thanks for your patch!
> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> @@ -22,7 +22,7 @@
> #include <linux/slab.h>
> #include <linux/memblock.h>
>
> -#define MAX_RESERVED_REGIONS 32
> +#define MAX_RESERVED_REGIONS 64
> static struct reserved_mem reserved_mem[MAX_RESERVED_REGIONS];
> static int reserved_mem_count;
This increases the size of reserved_mem[] by 896 (32-bit), 1280 (32-bit LPAE),
or 1792 (64-bit) bytes. While some systems don't need reserved memory
regions at all, and may be RAM-limited.
Perhaps this array can be replaced by some dynamically increasing
structure?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-26 9:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-24 18:02 [PATCH] of: of_reserved_mem: Increase limit on number of reserved regions Isaac J. Manjarres
2020-02-25 21:08 ` Rob Herring
2020-02-26 9:01 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).