* [PATCH] sh: add missing DECLARE_EXPORT() for __ashiftrt_r4_2x
@ 2019-12-12 2:38 Kuninori Morimoto
2019-12-12 7:49 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Kuninori Morimoto @ 2019-12-12 2:38 UTC (permalink / raw)
To: Yoshinori Sato, Rich Felker, Andrew Morton; +Cc: linux-sh, linux-kernel
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
__ashiftrt_r4_2x is used from kernel module.
We need DECLARE_EXPORT(), otherwise we will get compile error.
ERROR: "__ashiftrt_r4_25" [drivers/iio/pressure/bmp280.ko] undefined!
ERROR: "__ashiftrt_r4_26" [drivers/iio/dac/ad5764.ko] undefined!
ERROR: "__ashiftrt_r4_26" [drivers/iio/accel/mma7660.ko] undefined!
ERROR: "__ashiftrt_r4_25" [drivers/iio/accel/dmard06.ko] undefined!
ERROR: "__ashiftrt_r4_26" [drivers/iio/accel/bma220_spi.ko] undefined!
ERROR: "__ashiftrt_r4_25" [drivers/crypto/hisilicon/sec/hisi_sec.ko] undefined!
ERROR: "__ashiftrt_r4_26" [drivers/rtc/rtc-x1205.ko] undefined!
ERROR: "__ashiftrt_r4_25" [drivers/rtc/rtc-pcf85063.ko] undefined!
ERROR: "__ashiftrt_r4_25" [drivers/rtc/rtc-pcf2123.ko] undefined!
ERROR: "__ashiftrt_r4_25" [drivers/input/tablet/gtco.ko] undefined!
ERROR: "__ashiftrt_r4_26" [drivers/input/mouse/psmouse.ko] undefined!
ERROR: "__ashiftrt_r4_28" [drivers/input/mouse/psmouse.ko] undefined!
ERROR: "__ashiftrt_r4_28" [drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.ko] undefined!
ERROR: "__ashiftrt_r4_28" [fs/udf/udf.ko] undefined!
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/sh/kernel/sh_ksyms_32.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/sh/kernel/sh_ksyms_32.c b/arch/sh/kernel/sh_ksyms_32.c
index 2827744..5818f98 100644
--- a/arch/sh/kernel/sh_ksyms_32.c
+++ b/arch/sh/kernel/sh_ksyms_32.c
@@ -53,8 +53,14 @@ DECLARE_EXPORT(__ashiftrt_r4_21);
DECLARE_EXPORT(__ashiftrt_r4_22);
DECLARE_EXPORT(__ashiftrt_r4_23);
DECLARE_EXPORT(__ashiftrt_r4_24);
+DECLARE_EXPORT(__ashiftrt_r4_25);
+DECLARE_EXPORT(__ashiftrt_r4_26);
DECLARE_EXPORT(__ashiftrt_r4_27);
+DECLARE_EXPORT(__ashiftrt_r4_28);
+DECLARE_EXPORT(__ashiftrt_r4_29);
DECLARE_EXPORT(__ashiftrt_r4_30);
+DECLARE_EXPORT(__ashiftrt_r4_31);
+DECLARE_EXPORT(__ashiftrt_r4_32);
DECLARE_EXPORT(__movstr);
DECLARE_EXPORT(__movstrSI8);
DECLARE_EXPORT(__movstrSI12);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sh: add missing DECLARE_EXPORT() for __ashiftrt_r4_2x
2019-12-12 2:38 [PATCH] sh: add missing DECLARE_EXPORT() for __ashiftrt_r4_2x Kuninori Morimoto
@ 2019-12-12 7:49 ` Geert Uytterhoeven
2019-12-13 0:02 ` Kuninori Morimoto
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-12-12 7:49 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Yoshinori Sato, Rich Felker, Andrew Morton, Linux-sh list,
Linux Kernel Mailing List
Hi Morimoto-san,
On Thu, Dec 12, 2019 at 3:39 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> __ashiftrt_r4_2x is used from kernel module.
> We need DECLARE_EXPORT(), otherwise we will get compile error.
>
> ERROR: "__ashiftrt_r4_25" [drivers/iio/pressure/bmp280.ko] undefined!
> ERROR: "__ashiftrt_r4_26" [drivers/iio/dac/ad5764.ko] undefined!
> ERROR: "__ashiftrt_r4_26" [drivers/iio/accel/mma7660.ko] undefined!
> ERROR: "__ashiftrt_r4_25" [drivers/iio/accel/dmard06.ko] undefined!
> ERROR: "__ashiftrt_r4_26" [drivers/iio/accel/bma220_spi.ko] undefined!
> ERROR: "__ashiftrt_r4_25" [drivers/crypto/hisilicon/sec/hisi_sec.ko] undefined!
> ERROR: "__ashiftrt_r4_26" [drivers/rtc/rtc-x1205.ko] undefined!
> ERROR: "__ashiftrt_r4_25" [drivers/rtc/rtc-pcf85063.ko] undefined!
> ERROR: "__ashiftrt_r4_25" [drivers/rtc/rtc-pcf2123.ko] undefined!
> ERROR: "__ashiftrt_r4_25" [drivers/input/tablet/gtco.ko] undefined!
> ERROR: "__ashiftrt_r4_26" [drivers/input/mouse/psmouse.ko] undefined!
> ERROR: "__ashiftrt_r4_28" [drivers/input/mouse/psmouse.ko] undefined!
> ERROR: "__ashiftrt_r4_28" [drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.ko] undefined!
> ERROR: "__ashiftrt_r4_28" [fs/udf/udf.ko] undefined!
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thanks for your patch!
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- a/arch/sh/kernel/sh_ksyms_32.c
> +++ b/arch/sh/kernel/sh_ksyms_32.c
> @@ -53,8 +53,14 @@ DECLARE_EXPORT(__ashiftrt_r4_21);
> DECLARE_EXPORT(__ashiftrt_r4_22);
> DECLARE_EXPORT(__ashiftrt_r4_23);
> DECLARE_EXPORT(__ashiftrt_r4_24);
> +DECLARE_EXPORT(__ashiftrt_r4_25);
> +DECLARE_EXPORT(__ashiftrt_r4_26);
> DECLARE_EXPORT(__ashiftrt_r4_27);
> +DECLARE_EXPORT(__ashiftrt_r4_28);
> +DECLARE_EXPORT(__ashiftrt_r4_29);
> DECLARE_EXPORT(__ashiftrt_r4_30);
> +DECLARE_EXPORT(__ashiftrt_r4_31);
> +DECLARE_EXPORT(__ashiftrt_r4_32);
> DECLARE_EXPORT(__movstr);
> DECLARE_EXPORT(__movstrSI8);
> DECLARE_EXPORT(__movstrSI12);
Wouldn't it make sense to just add all of them (__ashiftrt_r4_[0-32])?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sh: add missing DECLARE_EXPORT() for __ashiftrt_r4_2x
2019-12-12 7:49 ` Geert Uytterhoeven
@ 2019-12-13 0:02 ` Kuninori Morimoto
0 siblings, 0 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2019-12-13 0:02 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Yoshinori Sato, Rich Felker, Andrew Morton, Linux-sh list,
Linux Kernel Mailing List
Hi Geert
Thank you for your review
> > __ashiftrt_r4_2x is used from kernel module.
> > We need DECLARE_EXPORT(), otherwise we will get compile error.
> >
> > ERROR: "__ashiftrt_r4_25" [drivers/iio/pressure/bmp280.ko] undefined!
> > ERROR: "__ashiftrt_r4_26" [drivers/iio/dac/ad5764.ko] undefined!
> > ERROR: "__ashiftrt_r4_26" [drivers/iio/accel/mma7660.ko] undefined!
> > ERROR: "__ashiftrt_r4_25" [drivers/iio/accel/dmard06.ko] undefined!
> > ERROR: "__ashiftrt_r4_26" [drivers/iio/accel/bma220_spi.ko] undefined!
> > ERROR: "__ashiftrt_r4_25" [drivers/crypto/hisilicon/sec/hisi_sec.ko] undefined!
> > ERROR: "__ashiftrt_r4_26" [drivers/rtc/rtc-x1205.ko] undefined!
> > ERROR: "__ashiftrt_r4_25" [drivers/rtc/rtc-pcf85063.ko] undefined!
> > ERROR: "__ashiftrt_r4_25" [drivers/rtc/rtc-pcf2123.ko] undefined!
> > ERROR: "__ashiftrt_r4_25" [drivers/input/tablet/gtco.ko] undefined!
> > ERROR: "__ashiftrt_r4_26" [drivers/input/mouse/psmouse.ko] undefined!
> > ERROR: "__ashiftrt_r4_28" [drivers/input/mouse/psmouse.ko] undefined!
> > ERROR: "__ashiftrt_r4_28" [drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.ko] undefined!
> > ERROR: "__ashiftrt_r4_28" [fs/udf/udf.ko] undefined!
(snip)
> Wouldn't it make sense to just add all of them (__ashiftrt_r4_[0-32])?
Oops, there are more missing __ashiftrt_r4_xx
Thank you for pointing it.
will post v2
Thank you for your help !!
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-13 0:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12 2:38 [PATCH] sh: add missing DECLARE_EXPORT() for __ashiftrt_r4_2x Kuninori Morimoto
2019-12-12 7:49 ` Geert Uytterhoeven
2019-12-13 0:02 ` Kuninori Morimoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).