[PULL] modules-next

[PULL] modules-next

[Rusty Russell]

The following changes since commit ec6931b281797b69e6cf109f9cc94d5a2bf994e0:

  word-at-a-time: avoid undefined behaviour in zero_bytemask macro (2014-04-27 15:20:05 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git tags/modules-next-for-linus

for you to fetch changes up to 4982223e51e8ea9d09bb33c8323b5ec1877b2b51:

  module: set nx before marking module MODULE_STATE_COMING. (2014-05-14 10:55:47 +0930)

----------------------------------------------------------------
Most of this is cleaning up various driver sysfs permissions so we can
re-add the perm check (we unified the module param and sysfs checks, but
the module ones were stronger so we weakened them temporarily).

Param parsing gets documented, and also "--" now forces args to be
handed to init (and ignored by the kernel).

Module NX/RO protections get tightened: we now set them before calling
parse_args().

Cheers,
Rusty.

----------------------------------------------------------------
Brian W Hart (1):
      cpumask.h: silence warning with -Wsign-compare

Christian Engelmayer (1):
      modpost: Fix resource leak in read_dump()

Rusty Russell (12):
      param: hand arguments after -- straight to init
      Documentation: Update kernel-parameters.tx
      speakup: fix incorrect perms on speakup_acntsa.c
      drivers/mtd/devices/docg3.c: avoid world-writable sysfs files.
      drivers/video/fbdev/sm501fb.c: avoid world-writable sysfs files.
      drivers/hid/hid-lg4ff.c: avoid world-writable sysfs files.
      drivers/scsi/pm8001/pm8001_ctl.c: avoid world-writable sysfs files.
      drivers/regulator/virtual: avoid world-writable sysfs files.
      drivers/staging/speakup/: avoid world-writable sysfs files.
      drivers/hid/hid-picolcd_fb: avoid world-writable sysfs files.
      samples/kobject/: avoid world-writable sysfs files.
      module: set nx before marking module MODULE_STATE_COMING.

 Documentation/kernel-parameters.txt      | 40 +++++++++++++--------
 drivers/hid/hid-lg4ff.c                  |  2 +-
 drivers/hid/hid-picolcd_fb.c             |  2 +-
 drivers/mtd/devices/docg3.c              |  4 +--
 drivers/regulator/virtual.c              | 10 +++---
 drivers/scsi/pm8001/pm8001_ctl.c         |  2 +-
 drivers/staging/speakup/kobjects.c       | 62 ++++++++++++++++----------------
 drivers/staging/speakup/speakup_acntpc.c | 14 ++++----
 drivers/staging/speakup/speakup_acntsa.c | 22 ++++++------
 drivers/staging/speakup/speakup_apollo.c | 16 ++++-----
 drivers/staging/speakup/speakup_audptr.c | 16 ++++-----
 drivers/staging/speakup/speakup_bns.c    | 14 ++++----
 drivers/staging/speakup/speakup_decext.c | 16 ++++-----
 drivers/staging/speakup/speakup_decpc.c  | 16 ++++-----
 drivers/staging/speakup/speakup_dectlk.c | 16 ++++-----
 drivers/staging/speakup/speakup_dtlk.c   | 20 +++++------
 drivers/staging/speakup/speakup_dummy.c  | 14 ++++----
 drivers/staging/speakup/speakup_keypc.c  | 10 +++---
 drivers/staging/speakup/speakup_ltlk.c   | 20 +++++------
 drivers/staging/speakup/speakup_soft.c   | 22 ++++++------
 drivers/staging/speakup/speakup_spkout.c | 16 ++++-----
 drivers/staging/speakup/speakup_txprt.c  | 14 ++++----
 drivers/video/fbdev/sm501fb.c            |  2 +-
 include/linux/cpumask.h                  |  2 +-
 include/linux/moduleparam.h              |  2 +-
 init/main.c                              | 33 ++++++++++++++---
 kernel/module.c                          | 44 +++++++++++++----------
 kernel/params.c                          | 25 +++++++------
 samples/kobject/kobject-example.c        |  7 ++--
 samples/kobject/kset-example.c           |  7 ++--
 scripts/mod/modpost.c                    |  2 ++

Re: [PULL] modules-next

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

On Wed, Jun 11, 2014 at 03:03:47PM +0930, Rusty Russell wrote:

>       drivers/regulator/virtual: avoid world-writable sysfs files.

Acked-by: Mark Brown <broonie@linaro.org>

if you need to respin - please do send patches to maintainers.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PULL] modules-next

[Rusty Russell]

Mark Brown <broonie@kernel.org> writes:
> On Wed, Jun 11, 2014 at 03:03:47PM +0930, Rusty Russell wrote:
>
>>       drivers/regulator/virtual: avoid world-writable sysfs files.
>
> Acked-by: Mark Brown <broonie@linaro.org>
>
> if you need to respin - please do send patches to maintainers.

If the address in drivers/regulator/virtual.c is incorrect, please
update it:

 Subject: [PATCH 5/9] drivers/regulator/virtual: avoid world-writable sysfs files.
 To: linux-kernel@vger.kernel.org
 Cc: Rusty Russell <rusty@rustcorp.com.au>, Mark Brown <broonie@opensource.wolfsonmicro.com>
 Date: Tue, 22 Apr 2014 13:03:28 +0930

 In line with practice for module parameters, we're adding a build-time
 check that sysfs files aren't world-writable.

Thanks,
Rusty.

Re: [PULL] modules-next

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

On Thu, Jun 12, 2014 at 10:55:00AM +0930, Rusty Russell wrote:
> Mark Brown <broonie@kernel.org> writes:

> > if you need to respin - please do send patches to maintainers.

> If the address in drivers/regulator/virtual.c is incorrect, please
> update it:

>  Subject: [PATCH 5/9] drivers/regulator/virtual: avoid world-writable sysfs files.
>  To: linux-kernel@vger.kernel.org
>  Cc: Rusty Russell <rusty@rustcorp.com.au>, Mark Brown <broonie@opensource.wolfsonmicro.com>
>  Date: Tue, 22 Apr 2014 13:03:28 +0930

The main people to hit are subsystem maintainers - driver authors have
often vanished or don't really respond to upstream e-mail, though of
course they should also be included.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PULL] modules-next

[Rusty Russell]

Mark Brown <broonie@kernel.org> writes:
> On Thu, Jun 12, 2014 at 10:55:00AM +0930, Rusty Russell wrote:
>> Mark Brown <broonie@kernel.org> writes:
>
>> > if you need to respin - please do send patches to maintainers.
>
>> If the address in drivers/regulator/virtual.c is incorrect, please
>> update it:
>
>>  Subject: [PATCH 5/9] drivers/regulator/virtual: avoid world-writable sysfs files.
>>  To: linux-kernel@vger.kernel.org
>>  Cc: Rusty Russell <rusty@rustcorp.com.au>, Mark Brown <broonie@opensource.wolfsonmicro.com>
>>  Date: Tue, 22 Apr 2014 13:03:28 +0930

> The main people to hit are subsystem maintainers - driver authors have
> often vanished or don't really respond to upstream e-mail, though of
> course they should also be included.

Fair enough.  There's a limited amount of effort I go to in a sweep like
this, unless I'm really worried about a particular patch.  lkml (used to
have?) a limit on how many people you could CC so I tend to trim.

So, did you queue a patch to fix your email address in
drivers/regulator/virtual.c?

Thanks.
Rusty.

Re: [PULL] modules-next

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

On Fri, Jun 13, 2014 at 10:33:20AM +0930, Rusty Russell wrote:

> So, did you queue a patch to fix your email address in
> drivers/regulator/virtual.c?

No, that's more about giving credit to Wolfson for funding the code I
guess - it's very rare for anyone to update the author information (and
becoming more common for people to not put them in the file at all).
Everyone uses get_maintainers.pl these days, it'll do a reasonable first
pass at figuring out who's been working on the code and who the
subsystem maintainers are.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PULL] modules-next

[Geert Uytterhoeven]

Hi Mark,

On Fri, Jun 13, 2014 at 11:24 AM, Mark Brown <broonie@kernel.org> wrote:
> On Fri, Jun 13, 2014 at 10:33:20AM +0930, Rusty Russell wrote:
>> So, did you queue a patch to fix your email address in
>> drivers/regulator/virtual.c?
>
> No, that's more about giving credit to Wolfson for funding the code I
> guess - it's very rare for anyone to update the author information (and
> becoming more common for people to not put them in the file at all).
> Everyone uses get_maintainers.pl these days, it'll do a reasonable first
> pass at figuring out who's been working on the code and who the
> subsystem maintainers are.

Still, obsolete email address are regularly updated or removed.
You can give credits in the comments. The file already has

Copyright 2008 Wolfson Microelectronics PLC.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PULL] modules-next

[Rusty Russell]

Rusty Russell <rusty@rustcorp.com.au> writes:
> Linus Torvalds <torvalds@linux-foundation.org> writes:
>> So this feels wrong to me, can you guys please explain:
...
>> I didn't actually pull the tree, I just reacted to the pull request itself.
...
> I can pull them out of modules-next if you'd prefer.

OK, removed that patch.  Here's the update pullreq:

The following changes since commit 3fc9d690936fb2e20e180710965ba2cc3a0881f8:

  Merge branch 'for-4.8/drivers' of git://git.kernel.dk/linux-block (2016-07-26 15:37:51 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git tags/modules-next-for-linus

for you to fetch changes up to 49aadcf1b6f4240751921dad52e86c760d70a5f1:

  extable.h: add stddef.h so "NULL" definition is not implicit (2016-08-04 10:16:56 +0930)

----------------------------------------------------------------
Removed the MODULE_SIG_FORCE-means-no-MODULE_FORCE_LOAD patch.

Only interesting thing here is Jessica's patch to add ro_after_init support
to modules.  The rest are all trivia.

Cheers,
Rusty.

----------------------------------------------------------------
Ben Hutchings (2):
      module: Invalidate signatures on force-loaded modules
      Documentation/module-signing.txt: Note need for version info if reusing a key

Jessica Yu (1):
      modules: add ro_after_init support

Jiri Kosina (1):
      module: fix noreturn attribute for __module_put_and_exit()

Libor Pechacek (1):
      module: Issue warnings when tainting kernel

Paul Gortmaker (2):
      exceptions: fork exception table content from module.h into extable.h
      extable.h: add stddef.h so "NULL" definition is not implicit

Prarit Bhargava (1):
      modules: Add kernel parameter to blacklist modules

Rusty Russell (2):
      module: fix redundant test.
      jump_label: disable preemption around __module_text_address().

Steven Rostedt (1):
      module: Do a WARN_ON_ONCE() for assert module mutex not held

 Documentation/kernel-parameters.txt |   3 +
 Documentation/module-signing.txt    |   6 ++
 include/linux/extable.h             |  32 ++++++++++
 include/linux/module.h              |  37 +++--------
 include/uapi/linux/elf.h            |   1 +
 kernel/jump_label.c                 |   5 +-
 kernel/livepatch/core.c             |   2 +-
 kernel/module.c                     | 121 +++++++++++++++++++++++++++++-------
 8 files changed, 155 insertions(+), 52 deletions(-)
 create mode 100644 include/linux/extable.h

Re: [PULL] modules-next

[Rusty Russell]

Linus Torvalds <torvalds@linux-foundation.org> writes:
> So this feels wrong to me, can you guys please explain:
>
> On Sun, Jul 31, 2016 at 9:02 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
>>
>> Ben Hutchings (3):
>>       module: Invalidate signatures on force-loaded modules
>>       module: Disable MODULE_FORCE_LOAD when MODULE_SIG_FORCE is enabled
>
> forcing a load and SIG_FORCE are entirely independent issues, afaik. I
> think requiring signed modules is just a good idea. But that doesn't
> necessarily mean that you don't have a signed module that is signed
> with a key you trust, but you still want to force-load it for the
> wrong kernel version (ie maybe you have a binary-only module from your
> IT department (and your IT department is evil,but at least they sign
> it to show that the module is trust-worthy as coming from them, even
> if they have some dubious behavior), but you did some kernel updates
> that still allow the module to work but the version doesn't match any
> more).
>
> Am I missing something? What's the connection between
> MODULE_FORCE_LOAD and MODULE_SIG_FORCE? Because it smells like they
> are independent and that the above changes are very very dubious.
>
> I didn't actually pull the tree, I just reacted to the pull request itself.

Well, MODULE_FORCE_LOAD is really "I am a doing crazy shit", and
MODULE_SIG_FORCE is "Don't let me do crazy shit".

You have to contrive pretty hard to get a situation where the
combination makes sense, so I tend to let Ben worry about the module
signing stuff.

I can pull them out of modules-next if you'd prefer.

Cheers,
Rusty.

Re: [PULL] modules-next

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 2460 bytes --]

On Sun, 2016-07-31 at 21:44 -0400, Linus Torvalds wrote:
> So this feels wrong to me, can you guys please explain:
> 
> On Sun, Jul 31, 2016 at 9:02 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
> > 
> > Ben Hutchings (3):
> >       module: Invalidate signatures on force-loaded modules
> >       module: Disable MODULE_FORCE_LOAD when MODULE_SIG_FORCE is enabled
> 
> forcing a load and SIG_FORCE are entirely independent issues, afaik. I
> think requiring signed modules is just a good idea. But that doesn't
> necessarily mean that you don't have a signed module that is signed
> with a key you trust, but you still want to force-load it for the
> wrong kernel version (ie maybe you have a binary-only module from your
> IT department (and your IT department is evil,but at least they sign
> it to show that the module is trust-worthy as coming from them, even
> if they have some dubious behavior), but you did some kernel updates
> that still allow the module to work but the version doesn't match any
> more).

We discussed this before and I thought you were happy with this
version.  If the use case you describe is at all common, it could
perhaps be handled by having a tool that patches the version
information and re-signs the module with a different trusted key.

> Am I missing something? What's the connection between
> MODULE_FORCE_LOAD and MODULE_SIG_FORCE? Because it smells like they
> are independent and that the above changes are very very dubious.

As I understand it:
- module signature enforcement means that root is not trusted to load
  arbitrary code into the kernel; instead the code has to be approved
  by one of the signing key holders
- force-loading a module means "I promise that this module is ABI
  compatible, even though it doesn't appear to be"

No-one signs that promise, and if it's false, the ABI differences could
mean that an otherwise benign module would compromise the kernel.  So
as I see it, the kernel should not trust a force-loaded signed module
any more than an unsigned module.

If you still think that module signature enforcement is compatible with
force-loading, I would like to know what you consider the purpose of
enforcement to be.

Ben.

> I didn't actually pull the tree, I just reacted to the pull request itself.
> 
>              Linus
-- 

Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PULL] modules-next

[Linus Torvalds]

So this feels wrong to me, can you guys please explain:

On Sun, Jul 31, 2016 at 9:02 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> Ben Hutchings (3):
>       module: Invalidate signatures on force-loaded modules
>       module: Disable MODULE_FORCE_LOAD when MODULE_SIG_FORCE is enabled

forcing a load and SIG_FORCE are entirely independent issues, afaik. I
think requiring signed modules is just a good idea. But that doesn't
necessarily mean that you don't have a signed module that is signed
with a key you trust, but you still want to force-load it for the
wrong kernel version (ie maybe you have a binary-only module from your
IT department (and your IT department is evil,but at least they sign
it to show that the module is trust-worthy as coming from them, even
if they have some dubious behavior), but you did some kernel updates
that still allow the module to work but the version doesn't match any
more).

Am I missing something? What's the connection between
MODULE_FORCE_LOAD and MODULE_SIG_FORCE? Because it smells like they
are independent and that the above changes are very very dubious.

I didn't actually pull the tree, I just reacted to the pull request itself.

             Linus

[PULL] modules-next

[Rusty Russell]

The following changes since commit 3fc9d690936fb2e20e180710965ba2cc3a0881f8:

  Merge branch 'for-4.8/drivers' of git://git.kernel.dk/linux-block (2016-07-26 15:37:51 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git tags/modules-next-for-linus

for you to fetch changes up to 8acc0026b0f3046c9929d1f33cf840cd190d1b12:

  extable.h: add stddef.h so "NULL" definition is not implicit (2016-07-28 15:23:47 +0930)

----------------------------------------------------------------
Only interesting thing here is Jessica's patch to add ro_after_init support
to modules.  The rest are all trivia.

Cheers,
Rusty.

----------------------------------------------------------------
Ben Hutchings (3):
      module: Invalidate signatures on force-loaded modules
      Documentation/module-signing.txt: Note need for version info if reusing a key
      module: Disable MODULE_FORCE_LOAD when MODULE_SIG_FORCE is enabled

Jessica Yu (1):
      modules: add ro_after_init support

Jiri Kosina (1):
      module: fix noreturn attribute for __module_put_and_exit()

Libor Pechacek (1):
      module: Issue warnings when tainting kernel

Paul Gortmaker (2):
      exceptions: fork exception table content from module.h into extable.h
      extable.h: add stddef.h so "NULL" definition is not implicit

Prarit Bhargava (1):
      modules: Add kernel parameter to blacklist modules

Rusty Russell (2):
      module: fix redundant test.
      jump_label: disable preemption around __module_text_address().

Steven Rostedt (1):
      module: Do a WARN_ON_ONCE() for assert module mutex not held

 Documentation/kernel-parameters.txt |   3 +
 Documentation/module-signing.txt    |   6 ++
 include/linux/extable.h             |  32 ++++++++++
 include/linux/module.h              |  37 +++--------
 include/uapi/linux/elf.h            |   1 +
 init/Kconfig                        |   1 +
 kernel/jump_label.c                 |   5 +-
 kernel/livepatch/core.c             |   2 +-
 kernel/module.c                     | 121 +++++++++++++++++++++++++++++-------
 9 files changed, 156 insertions(+), 52 deletions(-)
 create mode 100644 include/linux/extable.h

[PULL] modules-next

[Rusty Russell]

The following changes since commit dd2384a75d1c046faf068a6352732a204814b86d:

  Merge tag 'arc-v4.2-rc6-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc (2015-08-08 04:38:00 +0300)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git tags/modules-next-for-linus

for you to fetch changes up to d1189c63ea5e3272dc390a83e1235f142b739eb4:

  scripts: [modpost] add new sections to white list (2015-10-26 20:38:43 +1030)

----------------------------------------------------------------
Nothing exciting, minor tweaks and cleanups.

Cheers,
Rusty.

----------------------------------------------------------------
Nicolas Boichat (1):
      modpost: Add flag -E for making section mismatches fatal

Noam Camus (1):
      scripts: [modpost] add new sections to white list

Oleg Nesterov (1):
      params: don't ignore the rest of cmdline if parse_one() fails

Takashi Iwai (1):
      modpost: abort if a module symbol is too long

 kernel/params.c          | 17 +++++++++--------
 lib/Kconfig.debug        |  9 +++++++++
 scripts/Makefile.modpost |  1 +
 scripts/mod/modpost.c    | 37 ++++++++++++++++++++++++++++++-------
 4 files changed, 49 insertions(+), 15 deletions(-)

[PULL] modules-next

[Rusty Russell]

The following changes since commit a8b253b9f253c05e5e10b829b8d1fb24556f4b56:

  Merge tag 'pinctrl-v4.1-4' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl (2015-05-25 15:15:54 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git tags/modules-next-for-linus

for you to fetch changes up to 20bdc2cfdbc484777b30b96fcdbb8994038f3ce1:

  modules: only use mod->param_lock if CONFIG_MODULES (2015-06-28 14:50:12 +0930)

----------------------------------------------------------------
Minor merge needed, due to function move.

Main excitement here is Peter Zijlstra's lockless rbtree optimization to
speed module address lookup.  He found some abusers of the module lock
doing that too.

A little bit of parameter work here too; including Dan Streetman's breaking
up the big param mutex so writing a parameter can load another module (yeah,
really).  Unfortunately that broke the usual suspects, !CONFIG_MODULES and
!CONFIG_SYSFS, so those fixes were appended too.

Cheers,
Rusty.

----------------------------------------------------------------
Dan Streetman (2):
      module: make perm const
      module: add per-module param_lock

Gobinda Charan Maji (1):
      sysfs: tightened sysfs permission checks

Luis R. Rodriguez (6):
      kernel/params: constify struct kernel_param_ops uses
      kernel/module.c: use generic module param operaters for sig_enforce
      kernel/params.c: generalize bool_enable_only
      kernel/params.c: export param_ops_bool_enable_only
      kernel/workqueue.c: remove ifdefs over wq_power_efficient
      kernel/module.c: avoid ifdefs for sig_enforce declaration

Peter Zijlstra (12):
      module: Annotate module version magic
      module, jump_label: Fix module locking
      module: Sanitize RCU usage and locking
      rbtree: Make lockless searches non-fatal
      seqlock: Better document raw_write_seqcount_latch()
      rcu: Move lockless_dereference() out of rcupdate.h
      seqlock: Introduce raw_read_seqcount_latch()
      rbtree: Implement generic latch_tree
      module: Optimize __module_address() using a latched RB-tree
      module: Make the mod_tree stuff conditional on PERF_EVENTS || TRACING
      module: Use __module_address() for module_address_lookup()
      module: Rework module_addr_{min,max}

Rusty Russell (3):
      modules: clarify CONFIG_MODULE_COMPRESS help, suggest 'N'.
      params: suppress unused variable error, warn once just in case code changes.
      param: fix module param locks when !CONFIG_SYSFS.

Stephen Rothwell (2):
      rcu: merge fix for Convert ACCESS_ONCE() to READ_ONCE() and WRITE_ONCE()
      modules: only use mod->param_lock if CONFIG_MODULES

 arch/s390/kernel/perf_cpum_sf.c                  |   2 +-
 arch/um/drivers/hostaudio_kern.c                 |  20 +-
 arch/x86/kvm/mmu_audit.c                         |   2 +-
 arch/x86/platform/uv/uv_nmi.c                    |   2 +-
 drivers/block/null_blk.c                         |   4 +-
 drivers/char/ipmi/ipmi_watchdog.c                |   6 +-
 drivers/dma/dmatest.c                            |   4 +-
 drivers/ide/ide.c                                |   2 +-
 drivers/infiniband/ulp/srp/ib_srp.c              |   4 +-
 drivers/input/misc/ati_remote2.c                 |   4 +-
 drivers/input/mouse/psmouse-base.c               |   2 +-
 drivers/misc/lis3lv02d/lis3lv02d.c               |   2 +-
 drivers/mtd/ubi/block.c                          |   2 +-
 drivers/net/ethernet/myricom/myri10ge/myri10ge.c |   6 +-
 drivers/net/wireless/ath/wil6210/main.c          |   4 +-
 drivers/net/wireless/libertas_tf/if_usb.c        |   6 +-
 drivers/power/test_power.c                       |  16 +-
 drivers/thermal/intel_powerclamp.c               |   4 +-
 drivers/tty/hvc/hvc_iucv.c                       |   2 +-
 drivers/tty/sysrq.c                              |   2 +-
 drivers/usb/atm/ueagle-atm.c                     |   4 +-
 drivers/video/fbdev/uvesafb.c                    |   2 +-
 drivers/video/fbdev/vt8623fb.c                   |   4 +-
 drivers/virtio/virtio_mmio.c                     |   2 +-
 fs/nfs/super.c                                   |   2 +-
 include/linux/compiler.h                         |  15 ++
 include/linux/kernel.h                           |  18 +-
 include/linux/module.h                           |  46 +++-
 include/linux/moduleparam.h                      |  99 +++-----
 include/linux/rbtree.h                           |  16 +-
 include/linux/rbtree_augmented.h                 |  21 +-
 include/linux/rbtree_latch.h                     | 212 ++++++++++++++++
 include/linux/rcupdate.h                         |  15 --
 include/linux/seqlock.h                          |  81 +++++-
 init/Kconfig                                     |  29 +--
 kernel/jump_label.c                              |  10 +-
 kernel/module.c                                  | 309 +++++++++++++++++------
 kernel/params.c                                  | 116 ++++++---
 kernel/time/timekeeping.c                        |  29 +--
 kernel/workqueue.c                               |   7 +-
 lib/bug.c                                        |   7 +-
 lib/rbtree.c                                     |  76 ++++--
 net/mac80211/rate.c                              |   4 +-
 net/sunrpc/auth.c                                |   2 +-
 net/sunrpc/xprtsock.c                            |   6 +-
 security/apparmor/lsm.c                          |   6 +-
 security/integrity/ima/ima_crypto.c              |   2 +-
 sound/pci/hda/hda_intel.c                        |   2 +-
 48 files changed, 883 insertions(+), 355 deletions(-)
 create mode 100644 include/linux/rbtree_latch.h

[PULL] modules-next

[Rusty Russell]

The following changes since commit f8de05ca38b7bce4079b52002a6817e9582e3e01:

  Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux (2015-01-23 06:53:06 +1200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git tags/modules-next-for-linus

for you to fetch changes up to 9cc019b8c94fa59e02fd82f15f7b7d689e35c190:

  module: Replace over-engineered nested sleep (2015-02-11 15:02:04 +1030)

----------------------------------------------------------------
Trivial cleanups, mainly.

Cheers,
Rusty.

----------------------------------------------------------------
Andrey Tsyvarev (1):
      kernel/module.c: Free lock-classes if parse_args failed

Marcel Holtmann (1):
      module: Remove double spaces in module verification taint message

Peter Zijlstra (2):
      module: Annotate nested sleep in resolve_symbol()
      module: Replace over-engineered nested sleep

Rabin Vincent (1):
      module: set ksymtab/kcrctab* section addresses to 0x0

 kernel/module.c           | 47 ++++++++++++++++++-----------------------------
 scripts/module-common.lds | 20 ++++++++++----------
 2 files changed, 28 insertions(+), 39 deletions(-)

Re: [PULL] modules-next

[Rusty Russell]

Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Thu, Dec 18, 2014 at 4:55 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
>>
>> The exciting thing here is the getting rid of stop_machine on module
>> removal.  This is possible by using a simple atomic_t for the counter,
>> rather than our fancy per-cpu counter: it turns out that no one is doing
>> a module increment per net packet, so the slowdown should be in the noise.
>
> Famous last words. It may not happen per-packet, but I see
> module_get() in various block drivers and in netfilter code etc, and
> some of them may be pretty bad.
>
> Let's see how it all works out.

Indeed.  The general pattern is "get on open/init"; get-on-every-use was
most useful combined with blocking rmmod, which we removed a few kernels
ago (because no one used it).

I did a random audit until I got bored, and I put a printk-on-module-get
in my kernels for a while, and none of my usecases flood my logs.  But
it's definitely a risk...

Cheers,
Rusty.

Re: [PULL] modules-next

[Linus Torvalds]

On Thu, Dec 18, 2014 at 4:55 PM, Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> The exciting thing here is the getting rid of stop_machine on module
> removal.  This is possible by using a simple atomic_t for the counter,
> rather than our fancy per-cpu counter: it turns out that no one is doing
> a module increment per net packet, so the slowdown should be in the noise.

Famous last words. It may not happen per-packet, but I see
module_get() in various block drivers and in netfilter code etc, and
some of them may be pretty bad.

Let's see how it all works out.

                       Linus

[PULL] modules-next

[Rusty Russell]

The following changes since commit 0df1f2487d2f0d04703f142813d53615d62a1da4:

  Linux 3.18-rc3 (2014-11-02 15:01:51 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git tags/modules-next-for-linus

for you to fetch changes up to b0a65b0cccd477b2fd8b7adad0ac39433df54829:

  param: do not set store func without write perm (2014-12-18 12:38:51 +1030)

----------------------------------------------------------------
The exciting thing here is the getting rid of stop_machine on module
removal.  This is possible by using a simple atomic_t for the counter,
rather than our fancy per-cpu counter: it turns out that no one is doing
a module increment per net packet, so the slowdown should be in the noise.

Also, script fixed for new git version.

Cheers,
Rusty.

----------------------------------------------------------------
Ionut Alexa (1):
      kernel:module Fix coding style errors and warnings.

Kees Cook (1):
      param: do not set store func without write perm

Masami Hiramatsu (5):
      module: Wait for RCU synchronizing before releasing a module
      module: Unlink module with RCU synchronizing instead of stop_machine
      lib/bug: Use RCU list ops for module_bug_list
      module: Replace module_ref with atomic_t refcnt
      module: Remove stop_machine from module unloading

Rusty Russell (1):
      params: cleanup sysfs allocation

 include/linux/module.h        |  16 +---
 include/trace/events/module.h |   2 +-
 kernel/module.c               | 170 +++++++++++++++++++-----------------------
 kernel/params.c               |  97 ++++++++++++------------
 lib/bug.c                     |  20 +++--
 5 files changed, 137 insertions(+), 168 deletions(-)

[PULL] modules-next

[Rusty Russell]

The following changes since commit 68e370289c29e3beac99d59c6d840d470af9dfcf:

  Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux (2014-08-26 13:50:23 -0700)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git tags/modules-next-for-linus

for you to fetch changes up to 184c3fc3f52fb75800deb76deffb70907d1f76ea:

  moduleparam: Resolve missing-field-initializer warning (2014-09-11 09:59:25 +0930)

----------------------------------------------------------------
Nothing major: support for compressing modules, and auto-tainting params.

Cheers,
Rusty.
PS.  My virtio-next tree is empty: DaveM took the patches I had.  There might
     be a virtio-rng starvation fix, but so far it's a bit voodoo so I will
     get to that in the next two days or it will wait.

----------------------------------------------------------------
Bertrand Jacquin (3):
      modsign: lookup lines ending in .ko in .mod files
      modinst: wrap long lines in order to enhance cmd_modules_install
      kbuild: handle module compression while running 'make modules_install'.

Jani Nikula (4):
      module: rename KERNEL_PARAM_FL_NOARG to avoid confusion
      module: make it possible to have unsafe, tainting module params
      module: add module_param_unsafe and module_param_named_unsafe
      drm/i915: taint the kernel if unsafe module parameters are set

Mark Rustad (1):
      moduleparam: Resolve missing-field-initializer warning

Mathias Krause (2):
      modpost: reduce visibility of symbols and constify r/o arrays
      modpost: simplify file name generation of *.mod.c files

Rusty Russell (1):
      param: check for tainting before calling set op.

 Makefile                            | 15 +++++++++++
 drivers/gpu/drm/i915/i915_params.c  |  8 +++---
 drivers/tty/serial/8250/8250_core.c |  2 +-
 include/linux/moduleparam.h         | 50 +++++++++++++++++++++++++++++--------
 init/Kconfig                        | 43 +++++++++++++++++++++++++++++++
 kernel/module.c                     |  2 +-
 kernel/params.c                     | 17 ++++++++++---
 scripts/Makefile.modinst            |  7 +++++-
 scripts/Makefile.modsign            |  2 +-
 scripts/mod/modpost.c               | 25 ++++++++++---------
 security/apparmor/lsm.c             |  4 +--
 11 files changed, 139 insertions(+), 36 deletions(-)

[PULL] modules-next

[Rusty Russell]

The following changes since commit 15ba2236f3556fc01b9ca91394465152b5ea74b6:

  Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2014-07-21 22:46:01 -0700)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git tags/modules-next-for-linus

for you to fetch changes up to 76215b04fd297c008b91ece732ed36e67e0181fa:

  arch/powerpc/platforms/powernv/opal-dump.c: fix world-writable sysfs files (2014-08-07 22:38:55 +0930)

----------------------------------------------------------------
This finally applies the stricter sysfs perms checking we pulled out
before last merge window.  A few stragglers are fixed (thanks linux-next!)

Cheers,
Rusty.

----------------------------------------------------------------
Michal Nazarewicz (1):
      scripts: modpost: fix compilation warning

Petr Mladek (2):
      module: add within_module() function
      module: return bool from within_module*()

Rasmus Villemoes (1):
      scripts: modpost: Remove numeric suffix pattern matching

Russell King (1):
      ARM: avoid ARM binutils leaking ELF local symbols

Rusty Russell (5):
      modules: Fix build error in moduleloader.h
      sysfs: disallow world-writable files.
      drivers/video/fbdev/s3c2410fb.c: don't make debug world-writable.
      arch/powerpc/platforms/powernv/opal-elog.c: fix world-writable sysfs files
      arch/powerpc/platforms/powernv/opal-dump.c: fix world-writable sysfs files

 arch/powerpc/platforms/powernv/opal-dump.c |  4 +--
 arch/powerpc/platforms/powernv/opal-elog.c |  4 +--
 drivers/video/fbdev/s3c2410fb.c            |  2 +-
 include/linux/kernel.h                     |  2 ++
 include/linux/module.h                     | 11 ++++--
 include/linux/moduleloader.h               |  6 ++--
 kernel/module.c                            | 14 ++++----
 scripts/mod/modpost.c                      | 58 ++++++++----------------------
 8 files changed, 40 insertions(+), 61 deletions(-)

[PULL] modules-next

[Rusty Russell]

The following changes since commit 06df44ee41442d83be061c5fd1b1de4f5fc6fbbf:

  modpost.c: Add .text.unlikely to TEXT_SECTIONS (2013-05-20 12:08:45 +0930)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git tags/modules-next-for-linus

for you to fetch changes up to 9eb76d7797b892a1dad4f2efb6f786681306dd13:

  module: cleanup call chain. (2013-07-03 10:15:10 +0930)

----------------------------------------------------------------
Nothing interesting.  Except the most embarrassing bugfix ever.  But let's
ignore that.

Cheers,
Rusty.

----------------------------------------------------------------
Jean Delvare (2):
      There is no /sys/parameters
      ABI: Clarify when /sys/module/MODULENAME is created

Mathias Krause (1):
      module: don't modify argument of module_kallsyms_lookup_name()

Rusty Russell (3):
      modules: don't fail to load on unknown parameters.
      module: do percpu allocation after uniqueness check.  No, really!
      module: cleanup call chain.

 Documentation/ABI/stable/sysfs-module | 10 +++--
 include/linux/moduleparam.h           |  2 +-
 kernel/module.c                       | 77 +++++++++++++++++++----------------
 kernel/params.c                       |  2 +-
 4 files changed, 52 insertions(+), 39 deletions(-)

[PULL] modules-next

[Rusty Russell]

The following changes since commit 9a9284153d965a57edc7162a8e57c14c97f3a935:

  Merge branch 'drm-fixes' of git://people.freedesktop.org/~airlied/linux (2013-01-20 20:55:49 -0800)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git tags/modules-next-for-linus

for you to fetch changes up to d9d8d7ed498ec65bea72dd24be7b9cd35af0c200:

  MODSIGN: Add option to not sign modules during modules_install (2013-01-25 16:55:37 +1030)

----------------------------------------------------------------
The sweeping change is to make add_taint() explicitly indicate whether to disable
lockdep, but it's a mechanical change.

Cheers,
Rusty.

----------------------------------------------------------------
Michal Marek (4):
      MODSIGN: Simplify Makefile with a Kconfig helper
      MODSIGN: Specify the hash algorithm on sign-file command line
      MODSIGN: Add -s <signature> option to sign-file
      MODSIGN: Add option to not sign modules during modules_install

Rusty Russell (3):
      module: printk message when module signature fail taints kernel.
      taint: add explicit flag to show whether lock dep is still OK.
      module: clean up load_module a little more.

Sasha Levin (1):
      module: constify within_module_*

Vineet Gupta (1):
      modpost: Ignore ARC specific non-alloc sections

 Makefile                             |    4 +-
 arch/alpha/kernel/traps.c            |    2 +-
 arch/arm/kernel/traps.c              |    2 +-
 arch/arm64/kernel/traps.c            |    2 +-
 arch/avr32/kernel/traps.c            |    2 +-
 arch/hexagon/kernel/traps.c          |    2 +-
 arch/ia64/kernel/traps.c             |    2 +-
 arch/m68k/kernel/traps.c             |    2 +-
 arch/mips/kernel/traps.c             |    2 +-
 arch/parisc/kernel/traps.c           |    2 +-
 arch/powerpc/kernel/traps.c          |    2 +-
 arch/s390/kernel/traps.c             |    2 +-
 arch/sh/kernel/traps.c               |    2 +-
 arch/sparc/kernel/setup_64.c         |    2 +-
 arch/sparc/kernel/traps_32.c         |    2 +-
 arch/sparc/kernel/traps_64.c         |    2 +-
 arch/unicore32/kernel/traps.c        |    2 +-
 arch/x86/kernel/cpu/amd.c            |    3 +-
 arch/x86/kernel/cpu/mcheck/mce.c     |    2 +-
 arch/x86/kernel/cpu/mcheck/p5.c      |    2 +-
 arch/x86/kernel/cpu/mcheck/winchip.c |    2 +-
 arch/x86/kernel/cpu/mtrr/generic.c   |    2 +-
 arch/x86/kernel/dumpstack.c          |    2 +-
 arch/xtensa/kernel/traps.c           |    2 +-
 drivers/acpi/custom_method.c         |    2 +-
 drivers/acpi/osl.c                   |    2 +-
 drivers/base/regmap/regmap-debugfs.c |    2 +-
 include/linux/kernel.h               |    6 +-
 include/linux/module.h               |    4 +-
 init/Kconfig                         |   20 +++++
 kernel/Makefile                      |   22 +-----
 kernel/module.c                      |  140 +++++++++++++++++++++-------------
 kernel/panic.c                       |   34 ++++-----
 kernel/sched/core.c                  |    2 +-
 kernel/sysctl.c                      |    2 +-
 lib/bug.c                            |    3 +-
 mm/memory.c                          |    2 +-
 mm/page_alloc.c                      |    2 +-
 mm/slab.c                            |    2 +-
 mm/slub.c                            |    2 +-
 scripts/mod/modpost.c                |    2 +
 scripts/sign-file                    |  134 +++++++++++++++-----------------
 sound/soc/soc-core.c                 |    2 +-