From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Valentin Ilie <valentin.ilie@gmail.com>
Cc: geoff@infradead.org, linuxppc-dev@lists.ozlabs.org,
cbe-oss-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers: ps3: ps3av.c: fixed checkpatch warnings
Date: Tue, 17 Apr 2012 14:53:12 +0200 [thread overview]
Message-ID: <CAMuHMdUQmTzjVfb=fwKJCmov+OuFYDHU-wW4T2kEXigpVxeGPg@mail.gmail.com> (raw)
In-Reply-To: <1334661361-3699-1-git-send-email-valentin.ilie@gmail.com>
On Tue, Apr 17, 2012 at 13:16, Valentin Ilie <valentin.ilie@gmail.com> wrote:
> diff --git a/drivers/ps3/ps3av.c b/drivers/ps3/ps3av.c
> index a409fa0..46136b0 100644
> --- a/drivers/ps3/ps3av.c
> +++ b/drivers/ps3/ps3av.c
> @@ -25,8 +25,8 @@
> #include <linux/ioctl.h>
> #include <linux/fb.h>
> #include <linux/slab.h>
> +#include <linux/firmware.h>
>
> -#include <asm/firmware.h>
NAK. It really needs <asm/firmware.h> (have you compiled the result?).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2012-04-17 12:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 11:16 [PATCH] Drivers: ps3: ps3av.c: fixed checkpatch warnings Valentin Ilie
2012-04-17 12:53 ` Geert Uytterhoeven [this message]
2012-04-25 1:19 ` [PATCH] drivers/ps3: Fix checkpatch warnings in ps3av.c Geoff Levand
2012-04-18 9:33 [PATCH] Drivers: ps3: ps3av.c: fixed checkpatch warnings Valentin Ilie
2012-04-18 23:20 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUQmTzjVfb=fwKJCmov+OuFYDHU-wW4T2kEXigpVxeGPg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=geoff@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=valentin.ilie@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).