From: Jesper Juhl <jj@chaosbits.net>
To: Valentin Ilie <valentin.ilie@gmail.com>
Cc: geoff@infradead.org, linuxppc-dev@lists.ozlabs.org,
cbe-oss-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers: ps3: ps3av.c: fixed checkpatch warnings
Date: Thu, 19 Apr 2012 01:20:20 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1204190115520.14916@swampdragon.chaosbits.net> (raw)
In-Reply-To: <1334741611-3296-1-git-send-email-valentin.ilie@gmail.com>
On Wed, 18 Apr 2012, Valentin Ilie wrote:
> Fixed some checkpatch warnings. (review)
> Last patch didn't compile.
>
> Signed-off-by: Valentin Ilie <valentin.ilie@gmail.com>
I'm wondering why you don't address the last 4 warnings and 2 errors from
checkpatch while you are at it...
But, the changes you make here look fine to me in any case.
Reviewed-by: Jesper Juhl <jj@chaosbits.net>
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
next prev parent reply other threads:[~2012-04-18 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 9:33 [PATCH] Drivers: ps3: ps3av.c: fixed checkpatch warnings Valentin Ilie
2012-04-18 23:20 ` Jesper Juhl [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-17 11:16 Valentin Ilie
2012-04-17 12:53 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1204190115520.14916@swampdragon.chaosbits.net \
--to=jj@chaosbits.net \
--cc=cbe-oss-dev@lists.ozlabs.org \
--cc=geoff@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=valentin.ilie@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).