[PATCH] usb: USB_FOTG210 should depend on ARCH_GEMINI

[PATCH] usb: USB_FOTG210 should depend on ARCH_GEMINI

[Geert Uytterhoeven]

The Faraday Technology FOTG210 USB2 Dual Role Controller is only present
on Cortina Systems Gemini SoCs.  Hence add a dependency on ARCH_GEMINI,
to prevent asking the user about its drivers when configuring a kernel
without Cortina Systems Gemini SoC support.

Fixes: 1dd33a9f1b95ab59 ("usb: fotg210: Collect pieces of dual mode controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/usb/fotg210/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/fotg210/Kconfig b/drivers/usb/fotg210/Kconfig
index 534206ee0d1db74f..dad1b088aba59217 100644
--- a/drivers/usb/fotg210/Kconfig
+++ b/drivers/usb/fotg210/Kconfig
@@ -4,6 +4,7 @@ config USB_FOTG210
 	tristate "Faraday FOTG210 USB2 Dual Role controller"
 	depends on USB || USB_GADGET
 	depends on HAS_DMA && HAS_IOMEM
+	depends on ARCH_GEMINI || COMPILE_TEST
 	default ARCH_GEMINI
 	select MFD_SYSCON
 	help
-- 
2.25.1

Re: [PATCH] usb: USB_FOTG210 should depend on ARCH_GEMINI

[Linus Walleij]

On Mon, Nov 21, 2022 at 4:22 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:

> The Faraday Technology FOTG210 USB2 Dual Role Controller is only present
> on Cortina Systems Gemini SoCs.  Hence add a dependency on ARCH_GEMINI,
> to prevent asking the user about its drivers when configuring a kernel
> without Cortina Systems Gemini SoC support.
>
> Fixes: 1dd33a9f1b95ab59 ("usb: fotg210: Collect pieces of dual mode controller")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Ok that's fair. When Faraday merged these drivers they probably had
some other system(s) in mind, but they don't talk much recently so:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH] usb: USB_FOTG210 should depend on ARCH_GEMINI

[Linus Walleij]

On Mon, Nov 21, 2022 at 4:22 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:

> The Faraday Technology FOTG210 USB2 Dual Role Controller is only present
> on Cortina Systems Gemini SoCs.

As it turns out, this is not true. The TI nSpire uses this too, I should have
noted since the nSpire maintainer was patching the driver...
https://lore.kernel.org/linux-usb/20210324141115.9384-1-fabian@ritter-vogt.de/

Shall we revert it or just add another clause for the nSpire?

Yours,
Linus Walleij

Re: [PATCH] usb: USB_FOTG210 should depend on ARCH_GEMINI

[Geert Uytterhoeven]

Hi Linus,

On Mon, Dec 5, 2022 at 11:24 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Nov 21, 2022 at 4:22 PM Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > The Faraday Technology FOTG210 USB2 Dual Role Controller is only present
> > on Cortina Systems Gemini SoCs.
>
> As it turns out, this is not true. The TI nSpire uses this too, I should have
> noted since the nSpire maintainer was patching the driver...
> https://lore.kernel.org/linux-usb/20210324141115.9384-1-fabian@ritter-vogt.de/
>
> Shall we revert it or just add another clause for the nSpire?

Oh, but the integration is not (yet) upstream, as I didn't find any
"faraday,fotg210" outside gemini.dtsi.

I guess another clause would be the most-userfriendly solution.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] usb: USB_FOTG210 should depend on ARCH_GEMINI

[Linus Walleij]

On Tue, Dec 6, 2022 at 9:01 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Mon, Dec 5, 2022 at 11:24 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Mon, Nov 21, 2022 at 4:22 PM Geert Uytterhoeven
> > <geert+renesas@glider.be> wrote:
> > > The Faraday Technology FOTG210 USB2 Dual Role Controller is only present
> > > on Cortina Systems Gemini SoCs.
> >
> > As it turns out, this is not true. The TI nSpire uses this too, I should have
> > noted since the nSpire maintainer was patching the driver...
> > https://lore.kernel.org/linux-usb/20210324141115.9384-1-fabian@ritter-vogt.de/
> >
> > Shall we revert it or just add another clause for the nSpire?
>
> Oh, but the integration is not (yet) upstream, as I didn't find any
> "faraday,fotg210" outside gemini.dtsi.

Ah it is still brewing, sorry.

> I guess another clause would be the most-userfriendly solution.

Yeah we can just add it when adding nSpire II.

Yours,
Linus Walleij