* [PATCH] dt-bindings: soc: renesas: renesas-soc: Add pattern for gray-hawk
@ 2024-02-27 22:09 Prabhakar
2024-02-27 23:33 ` Niklas Söderlund
2024-02-28 7:54 ` Geert Uytterhoeven
0 siblings, 2 replies; 4+ messages in thread
From: Prabhakar @ 2024-02-27 22:09 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Niklas Söderlund,
devicetree
Cc: linux-renesas-soc, linux-kernel, Prabhakar, Biju Das, Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Add pattern for Renesas Gray Hawk Single board (based on R-Car V4M SoC)
to fix the below dtbs_check issue:
arch/arm64/boot/dts/renesas/r8a779h0-gray-hawk-single.dtb: /: compatible:0: 'anyOf' conditional failed, one must be fixed:
4695 'renesas,gray-hawk-single' does not match '^renesas,(emev2|r(7s|8a|9a)[a-z0-9]+|rcar|rmobile|rz[a-z0-9]*|sh(7[a-z0-9]+)?|mobile)-[a-z0-9-]+$'
4696 'renesas,gray-hawk-single' does not match '^renesas,(condor|falcon|gr-peach|salvator|sk-rz|smar(c(2)?)?|spider|white-hawk)(.*)?$'
4697 'renesas,gray-hawk-single' does not match '^renesas,(can|cpg|dmac|du|(g)?ether(avb)?|gpio|hscif|(r)?i[i2]c|imr|intc|ipmmu|irqc|jpu|mmcif|msiof|mtu2|pci(e)?|pfc|pwm|[rq]spi|rcar_sound|sata|scif[ab]*|sdhi|thermal|tmu|tpu|usb(2|hs)?|vin|xhci)-[a-z0-9-]+$'
4698 'renesas,gray-hawk-single' does not match '^renesas,(d|s)?bsc(3)?-(r8a73a4|r8a7740|sh73a0)$'
4699 'renesas,gray-hawk-single' does not match '^renesas,em-(gio|sti|uart)$'
4700 'renesas,gray-hawk-single' does not match '^renesas,fsi2-(r8a7740|sh73a0)$'
4701 'renesas,gray-hawk-single' does not match '^renesas,hspi-r8a777[89]$'
4702 'renesas,gray-hawk-single' does not match '^renesas,sysc-(r8a73a4|r8a7740|rmobile|sh73a0)$'
4703 'renesas,gray-hawk-single' is not one of ['renesas,imr-lx4', 'renesas,mtu2-r7s72100']
4704 'renesas,gray-hawk-single' is not one of ['renesas,smp-sram']
4705 'renesas,gray-hawk-single' does not match '^(?!renesas,.+-.+).+$'
4706 from schema $id: http://devicetree.org/schemas/soc/renesas/renesas-soc.yaml#
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml
index a5fcd471983d..5ddd31f30f26 100644
--- a/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml
+++ b/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml
@@ -37,7 +37,7 @@ properties:
anyOf:
# Preferred naming style for compatibles of SoC components
- pattern: "^renesas,(emev2|r(7s|8a|9a)[a-z0-9]+|rcar|rmobile|rz[a-z0-9]*|sh(7[a-z0-9]+)?|mobile)-[a-z0-9-]+$"
- - pattern: "^renesas,(condor|falcon|gr-peach|salvator|sk-rz|smar(c(2)?)?|spider|white-hawk)(.*)?$"
+ - pattern: "^renesas,(condor|falcon|gr-peach|gray-hawk|salvator|sk-rz|smar(c(2)?)?|spider|white-hawk)(.*)?$"
# Legacy compatibles
#
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: soc: renesas: renesas-soc: Add pattern for gray-hawk
2024-02-27 22:09 [PATCH] dt-bindings: soc: renesas: renesas-soc: Add pattern for gray-hawk Prabhakar
@ 2024-02-27 23:33 ` Niklas Söderlund
2024-02-27 23:36 ` Lad, Prabhakar
2024-02-28 7:54 ` Geert Uytterhoeven
1 sibling, 1 reply; 4+ messages in thread
From: Niklas Söderlund @ 2024-02-27 23:33 UTC (permalink / raw)
To: Prabhakar
Cc: Geert Uytterhoeven, Magnus Damm, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, devicetree, linux-renesas-soc,
linux-kernel, Biju Das, Lad Prabhakar
Hi Prabhakar,
Thanks for your work.
On 2024-02-27 22:09:30 +0000, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Add pattern for Renesas Gray Hawk Single board (based on R-Car V4M SoC)
> to fix the below dtbs_check issue:
>
> arch/arm64/boot/dts/renesas/r8a779h0-gray-hawk-single.dtb: /: compatible:0: 'anyOf' conditional failed, one must be fixed:
> 4695 'renesas,gray-hawk-single' does not match '^renesas,(emev2|r(7s|8a|9a)[a-z0-9]+|rcar|rmobile|rz[a-z0-9]*|sh(7[a-z0-9]+)?|mobile)-[a-z0-9-]+$'
> 4696 'renesas,gray-hawk-single' does not match '^renesas,(condor|falcon|gr-peach|salvator|sk-rz|smar(c(2)?)?|spider|white-hawk)(.*)?$'
> 4697 'renesas,gray-hawk-single' does not match '^renesas,(can|cpg|dmac|du|(g)?ether(avb)?|gpio|hscif|(r)?i[i2]c|imr|intc|ipmmu|irqc|jpu|mmcif|msiof|mtu2|pci(e)?|pfc|pwm|[rq]spi|rcar_sound|sata|scif[ab]*|sdhi|thermal|tmu|tpu|usb(2|hs)?|vin|xhci)-[a-z0-9-]+$'
> 4698 'renesas,gray-hawk-single' does not match '^renesas,(d|s)?bsc(3)?-(r8a73a4|r8a7740|sh73a0)$'
> 4699 'renesas,gray-hawk-single' does not match '^renesas,em-(gio|sti|uart)$'
> 4700 'renesas,gray-hawk-single' does not match '^renesas,fsi2-(r8a7740|sh73a0)$'
> 4701 'renesas,gray-hawk-single' does not match '^renesas,hspi-r8a777[89]$'
> 4702 'renesas,gray-hawk-single' does not match '^renesas,sysc-(r8a73a4|r8a7740|rmobile|sh73a0)$'
> 4703 'renesas,gray-hawk-single' is not one of ['renesas,imr-lx4', 'renesas,mtu2-r7s72100']
> 4704 'renesas,gray-hawk-single' is not one of ['renesas,smp-sram']
> 4705 'renesas,gray-hawk-single' does not match '^(?!renesas,.+-.+).+$'
> 4706 from schema $id: http://devicetree.org/schemas/soc/renesas/renesas-soc.yaml#
The change is correct, but I don't think you need to phrase the commit
message as fixing an error. This change extends renesas-soc.yaml with
support for gray-hawk.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml
> index a5fcd471983d..5ddd31f30f26 100644
> --- a/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml
> +++ b/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml
> @@ -37,7 +37,7 @@ properties:
> anyOf:
> # Preferred naming style for compatibles of SoC components
> - pattern: "^renesas,(emev2|r(7s|8a|9a)[a-z0-9]+|rcar|rmobile|rz[a-z0-9]*|sh(7[a-z0-9]+)?|mobile)-[a-z0-9-]+$"
> - - pattern: "^renesas,(condor|falcon|gr-peach|salvator|sk-rz|smar(c(2)?)?|spider|white-hawk)(.*)?$"
> + - pattern: "^renesas,(condor|falcon|gr-peach|gray-hawk|salvator|sk-rz|smar(c(2)?)?|spider|white-hawk)(.*)?$"
>
> # Legacy compatibles
> #
> --
> 2.34.1
>
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: soc: renesas: renesas-soc: Add pattern for gray-hawk
2024-02-27 23:33 ` Niklas Söderlund
@ 2024-02-27 23:36 ` Lad, Prabhakar
0 siblings, 0 replies; 4+ messages in thread
From: Lad, Prabhakar @ 2024-02-27 23:36 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Geert Uytterhoeven, Magnus Damm, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, devicetree, linux-renesas-soc,
linux-kernel, Biju Das, Lad Prabhakar
Hi Niklas,
Thank you for the review.
On Tue, Feb 27, 2024 at 11:33 PM Niklas Söderlund
<niklas.soderlund@ragnatech.se> wrote:
>
> Hi Prabhakar,
>
> Thanks for your work.
>
> On 2024-02-27 22:09:30 +0000, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Add pattern for Renesas Gray Hawk Single board (based on R-Car V4M SoC)
> > to fix the below dtbs_check issue:
> >
> > arch/arm64/boot/dts/renesas/r8a779h0-gray-hawk-single.dtb: /: compatible:0: 'anyOf' conditional failed, one must be fixed:
> > 4695 'renesas,gray-hawk-single' does not match '^renesas,(emev2|r(7s|8a|9a)[a-z0-9]+|rcar|rmobile|rz[a-z0-9]*|sh(7[a-z0-9]+)?|mobile)-[a-z0-9-]+$'
> > 4696 'renesas,gray-hawk-single' does not match '^renesas,(condor|falcon|gr-peach|salvator|sk-rz|smar(c(2)?)?|spider|white-hawk)(.*)?$'
> > 4697 'renesas,gray-hawk-single' does not match '^renesas,(can|cpg|dmac|du|(g)?ether(avb)?|gpio|hscif|(r)?i[i2]c|imr|intc|ipmmu|irqc|jpu|mmcif|msiof|mtu2|pci(e)?|pfc|pwm|[rq]spi|rcar_sound|sata|scif[ab]*|sdhi|thermal|tmu|tpu|usb(2|hs)?|vin|xhci)-[a-z0-9-]+$'
> > 4698 'renesas,gray-hawk-single' does not match '^renesas,(d|s)?bsc(3)?-(r8a73a4|r8a7740|sh73a0)$'
> > 4699 'renesas,gray-hawk-single' does not match '^renesas,em-(gio|sti|uart)$'
> > 4700 'renesas,gray-hawk-single' does not match '^renesas,fsi2-(r8a7740|sh73a0)$'
> > 4701 'renesas,gray-hawk-single' does not match '^renesas,hspi-r8a777[89]$'
> > 4702 'renesas,gray-hawk-single' does not match '^renesas,sysc-(r8a73a4|r8a7740|rmobile|sh73a0)$'
> > 4703 'renesas,gray-hawk-single' is not one of ['renesas,imr-lx4', 'renesas,mtu2-r7s72100']
> > 4704 'renesas,gray-hawk-single' is not one of ['renesas,smp-sram']
> > 4705 'renesas,gray-hawk-single' does not match '^(?!renesas,.+-.+).+$'
> > 4706 from schema $id: http://devicetree.org/schemas/soc/renesas/renesas-soc.yaml#
>
> The change is correct, but I don't think you need to phrase the commit
> message as fixing an error. This change extends renesas-soc.yaml with
> support for gray-hawk.
>
Aha I see, I wasn't aware gray-hawk was added after renesas-soc.yaml
was introduced. I'll reword the commit description and send a v2.
Cheers,
Prabhakar
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> > Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml
> > index a5fcd471983d..5ddd31f30f26 100644
> > --- a/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml
> > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas-soc.yaml
> > @@ -37,7 +37,7 @@ properties:
> > anyOf:
> > # Preferred naming style for compatibles of SoC components
> > - pattern: "^renesas,(emev2|r(7s|8a|9a)[a-z0-9]+|rcar|rmobile|rz[a-z0-9]*|sh(7[a-z0-9]+)?|mobile)-[a-z0-9-]+$"
> > - - pattern: "^renesas,(condor|falcon|gr-peach|salvator|sk-rz|smar(c(2)?)?|spider|white-hawk)(.*)?$"
> > + - pattern: "^renesas,(condor|falcon|gr-peach|gray-hawk|salvator|sk-rz|smar(c(2)?)?|spider|white-hawk)(.*)?$"
> >
> > # Legacy compatibles
> > #
> > --
> > 2.34.1
> >
>
> --
> Kind Regards,
> Niklas Söderlund
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: soc: renesas: renesas-soc: Add pattern for gray-hawk
2024-02-27 22:09 [PATCH] dt-bindings: soc: renesas: renesas-soc: Add pattern for gray-hawk Prabhakar
2024-02-27 23:33 ` Niklas Söderlund
@ 2024-02-28 7:54 ` Geert Uytterhoeven
1 sibling, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2024-02-28 7:54 UTC (permalink / raw)
To: Prabhakar
Cc: Magnus Damm, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Niklas Söderlund, devicetree, linux-renesas-soc,
linux-kernel, Biju Das, Lad Prabhakar
Hi Prabhakar,
On Tue, Feb 27, 2024 at 11:10 PM Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Add pattern for Renesas Gray Hawk Single board (based on R-Car V4M SoC)
> to fix the below dtbs_check issue:
>
> arch/arm64/boot/dts/renesas/r8a779h0-gray-hawk-single.dtb: /: compatible:0: 'anyOf' conditional failed, one must be fixed:
> 4695 'renesas,gray-hawk-single' does not match '^renesas,(emev2|r(7s|8a|9a)[a-z0-9]+|rcar|rmobile|rz[a-z0-9]*|sh(7[a-z0-9]+)?|mobile)-[a-z0-9-]+$'
> 4696 'renesas,gray-hawk-single' does not match '^renesas,(condor|falcon|gr-peach|salvator|sk-rz|smar(c(2)?)?|spider|white-hawk)(.*)?$'
> 4697 'renesas,gray-hawk-single' does not match '^renesas,(can|cpg|dmac|du|(g)?ether(avb)?|gpio|hscif|(r)?i[i2]c|imr|intc|ipmmu|irqc|jpu|mmcif|msiof|mtu2|pci(e)?|pfc|pwm|[rq]spi|rcar_sound|sata|scif[ab]*|sdhi|thermal|tmu|tpu|usb(2|hs)?|vin|xhci)-[a-z0-9-]+$'
> 4698 'renesas,gray-hawk-single' does not match '^renesas,(d|s)?bsc(3)?-(r8a73a4|r8a7740|sh73a0)$'
> 4699 'renesas,gray-hawk-single' does not match '^renesas,em-(gio|sti|uart)$'
> 4700 'renesas,gray-hawk-single' does not match '^renesas,fsi2-(r8a7740|sh73a0)$'
> 4701 'renesas,gray-hawk-single' does not match '^renesas,hspi-r8a777[89]$'
> 4702 'renesas,gray-hawk-single' does not match '^renesas,sysc-(r8a73a4|r8a7740|rmobile|sh73a0)$'
> 4703 'renesas,gray-hawk-single' is not one of ['renesas,imr-lx4', 'renesas,mtu2-r7s72100']
> 4704 'renesas,gray-hawk-single' is not one of ['renesas,smp-sram']
> 4705 'renesas,gray-hawk-single' does not match '^(?!renesas,.+-.+).+$'
> 4706 from schema $id: http://devicetree.org/schemas/soc/renesas/renesas-soc.yaml#
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
I wonder how I managed to miss that?
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.9.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-28 7:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-27 22:09 [PATCH] dt-bindings: soc: renesas: renesas-soc: Add pattern for gray-hawk Prabhakar
2024-02-27 23:33 ` Niklas Söderlund
2024-02-27 23:36 ` Lad, Prabhakar
2024-02-28 7:54 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).