* [PATCH RESEND] arm64: meson: select COMMON_CLK
@ 2021-04-29 8:38 Jerome Brunet
2021-04-29 20:46 ` Martin Blumenstingl
2021-05-04 0:05 ` Kevin Hilman
0 siblings, 2 replies; 6+ messages in thread
From: Jerome Brunet @ 2021-04-29 8:38 UTC (permalink / raw)
To: Kevin Hilman; +Cc: Jerome Brunet, linux-amlogic, linux-kernel, Neil Armstrong
This fix the recent removal of clock drivers selection.
While it is not necessary to select the clock drivers themselves, we need
to select a proper implementation of the clock API, which for the meson, is
CCF
Fixes: ba66a25536dd ("arm64: meson: ship only the necessary clock controllers")
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
arch/arm64/Kconfig.platforms | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index cdfd5fed457f..a3fdffcd1ce8 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -168,6 +168,7 @@ config ARCH_MEDIATEK
config ARCH_MESON
bool "Amlogic Platforms"
+ select COMMON_CLK
select MESON_IRQ_GPIO
help
This enables support for the arm64 based Amlogic SoCs
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH RESEND] arm64: meson: select COMMON_CLK 2021-04-29 8:38 [PATCH RESEND] arm64: meson: select COMMON_CLK Jerome Brunet @ 2021-04-29 20:46 ` Martin Blumenstingl 2021-05-04 0:05 ` Kevin Hilman 1 sibling, 0 replies; 6+ messages in thread From: Martin Blumenstingl @ 2021-04-29 20:46 UTC (permalink / raw) To: Jerome Brunet; +Cc: Kevin Hilman, linux-amlogic, linux-kernel, Neil Armstrong On Thu, Apr 29, 2021 at 10:39 AM Jerome Brunet <jbrunet@baylibre.com> wrote: > > This fix the recent removal of clock drivers selection. > While it is not necessary to select the clock drivers themselves, we need > to select a proper implementation of the clock API, which for the meson, is > CCF > > Fixes: ba66a25536dd ("arm64: meson: ship only the necessary clock controllers") > Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> note to self: ARCH_MULTIPLATFORM for the 32-bit SoCs also selects this ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] arm64: meson: select COMMON_CLK 2021-04-29 8:38 [PATCH RESEND] arm64: meson: select COMMON_CLK Jerome Brunet 2021-04-29 20:46 ` Martin Blumenstingl @ 2021-05-04 0:05 ` Kevin Hilman 2021-06-08 9:52 ` Geert Uytterhoeven 1 sibling, 1 reply; 6+ messages in thread From: Kevin Hilman @ 2021-05-04 0:05 UTC (permalink / raw) To: Jerome Brunet; +Cc: Neil Armstrong, linux-amlogic, linux-kernel On Thu, 29 Apr 2021 10:38:23 +0200, Jerome Brunet wrote: > This fix the recent removal of clock drivers selection. > While it is not necessary to select the clock drivers themselves, we need > to select a proper implementation of the clock API, which for the meson, is > CCF Applied, thanks! [1/1] arm64: meson: select COMMON_CLK commit: aea7a80ad5effd48f44a7a08c3903168be038a43 Best regards, -- Kevin Hilman <khilman@baylibre.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] arm64: meson: select COMMON_CLK 2021-05-04 0:05 ` Kevin Hilman @ 2021-06-08 9:52 ` Geert Uytterhoeven 2021-06-08 16:32 ` Jerome Brunet 0 siblings, 1 reply; 6+ messages in thread From: Geert Uytterhoeven @ 2021-06-08 9:52 UTC (permalink / raw) To: Jerome Brunet Cc: Neil Armstrong, open list:ARM/Amlogic Meson..., Linux Kernel Mailing List, Kevin Hilman Hi Jerome, On Tue, May 4, 2021 at 2:06 AM Kevin Hilman <khilman@baylibre.com> wrote: > On Thu, 29 Apr 2021 10:38:23 +0200, Jerome Brunet wrote: > > This fix the recent removal of clock drivers selection. > > While it is not necessary to select the clock drivers themselves, we need > > to select a proper implementation of the clock API, which for the meson, is > > CCF > > Applied, thanks! > > [1/1] arm64: meson: select COMMON_CLK > commit: aea7a80ad5effd48f44a7a08c3903168be038a43 > > Best regards, > -- > Kevin Hilman <khilman@baylibre.com> Why is this needed, and why would this make any difference? COMMON_CLK is always enabled on arm64, as the main ARM64 symbol in arch/arm64/Kconfig selects it. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] arm64: meson: select COMMON_CLK 2021-06-08 9:52 ` Geert Uytterhoeven @ 2021-06-08 16:32 ` Jerome Brunet 2021-06-08 16:38 ` Neil Armstrong 0 siblings, 1 reply; 6+ messages in thread From: Jerome Brunet @ 2021-06-08 16:32 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Neil Armstrong, open list:ARM/Amlogic Meson..., Linux Kernel Mailing List, Kevin Hilman On Tue 08 Jun 2021 at 11:52, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > Hi Jerome, > > On Tue, May 4, 2021 at 2:06 AM Kevin Hilman <khilman@baylibre.com> wrote: >> On Thu, 29 Apr 2021 10:38:23 +0200, Jerome Brunet wrote: >> > This fix the recent removal of clock drivers selection. >> > While it is not necessary to select the clock drivers themselves, we need >> > to select a proper implementation of the clock API, which for the meson, is >> > CCF >> >> Applied, thanks! >> >> [1/1] arm64: meson: select COMMON_CLK >> commit: aea7a80ad5effd48f44a7a08c3903168be038a43 >> >> Best regards, >> -- >> Kevin Hilman <khilman@baylibre.com> > > Why is this needed, and why would this make any difference? > COMMON_CLK is always enabled on arm64, as the main ARM64 symbol in > arch/arm64/Kconfig selects it. Ah indeed. Shortly after commit ba66a25536dd was merged I remember I had problem with COMMON_CLK (or any other clock implementation) being selected. TBH, I don't remember it exactly ... For sure this was a mistake. Neil, can you still drop it and do you need a revert ? > > Gr{oetje,eeting}s, > > Geert ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] arm64: meson: select COMMON_CLK 2021-06-08 16:32 ` Jerome Brunet @ 2021-06-08 16:38 ` Neil Armstrong 0 siblings, 0 replies; 6+ messages in thread From: Neil Armstrong @ 2021-06-08 16:38 UTC (permalink / raw) To: Jerome Brunet, Geert Uytterhoeven Cc: open list:ARM/Amlogic Meson..., Linux Kernel Mailing List, Kevin Hilman Hi, On 08/06/2021 18:32, Jerome Brunet wrote: > > On Tue 08 Jun 2021 at 11:52, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > >> Hi Jerome, >> >> On Tue, May 4, 2021 at 2:06 AM Kevin Hilman <khilman@baylibre.com> wrote: >>> On Thu, 29 Apr 2021 10:38:23 +0200, Jerome Brunet wrote: >>>> This fix the recent removal of clock drivers selection. >>>> While it is not necessary to select the clock drivers themselves, we need >>>> to select a proper implementation of the clock API, which for the meson, is >>>> CCF >>> >>> Applied, thanks! >>> >>> [1/1] arm64: meson: select COMMON_CLK >>> commit: aea7a80ad5effd48f44a7a08c3903168be038a43 >>> >>> Best regards, >>> -- >>> Kevin Hilman <khilman@baylibre.com> >> >> Why is this needed, and why would this make any difference? >> COMMON_CLK is always enabled on arm64, as the main ARM64 symbol in >> arch/arm64/Kconfig selects it. > > Ah indeed. Shortly after commit ba66a25536dd was merged I remember I had > problem with COMMON_CLK (or any other clock implementation) being > selected. TBH, I don't remember it exactly ... > > For sure this was a mistake. > Neil, can you still drop it and do you need a revert ? I can't drop it, it has already been merged. Please send a revert and I'll push it for 5.14-rc fixes. Neil > >> >> Gr{oetje,eeting}s, >> >> Geert > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-08 16:38 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-29 8:38 [PATCH RESEND] arm64: meson: select COMMON_CLK Jerome Brunet 2021-04-29 20:46 ` Martin Blumenstingl 2021-05-04 0:05 ` Kevin Hilman 2021-06-08 9:52 ` Geert Uytterhoeven 2021-06-08 16:32 ` Jerome Brunet 2021-06-08 16:38 ` Neil Armstrong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).