From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: Brad Boyer <flar@allandria.com>,
"Linux/m68k" <linux-m68k@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: m68k: Convert to genirq (WIP)
Date: Fri, 26 Aug 2011 13:32:28 +0200 [thread overview]
Message-ID: <CAMuHMdVz40_HyFpgttGmUO_DBM58vgOhEq3YGzJ0tUM+k9B26w@mail.gmail.com> (raw)
In-Reply-To: <alpine.OSX.2.00.1108262117070.267@ibook.local>
On Fri, Aug 26, 2011 at 13:21, Finn Thain <fthain@telegraphics.com.au> wrote:
> On Fri, 26 Aug 2011, Geert Uytterhoeven wrote:
>> On Wed, Aug 10, 2011 at 12:53, Finn Thain <fthain@telegraphics.com.au> wrote:
>> >> via1_irq
>> >> OSS_IRQLEV_VIA1 = IRQ_AUTO_6 (on oss) conflict: psc_irq
>> >>
>> >> IRQ_AUTO_1 conflict: iop_ism_irq
>>
>> >> iop_ism_irq
>> >> OSS_IRQLEV_IOPISM = 1 = IRQ_AUTO_1 (on oss) conflict: via1_irq
>> >
>> > via1_irq is remapped to IRQ_AUTO_6 on OSS.
>>
>> According to via_register_interrupts(), it requests both:
>>
>> if (via_alt_mapping) {
>> if (request_irq(IRQ_AUTO_1, via1_irq, 0, "software",
>> (void *)via1))
>> pr_err("Couldn't register %s interrupt\n", "software");
>> if (request_irq(IRQ_AUTO_6, via1_irq, 0, "via1", (void *)via1))
>> pr_err("Couldn't register %s interrupt\n", "via1");
>> } else {
>> if (request_irq(IRQ_AUTO_1, via1_irq, 0, "via1", (void *)via1))
>> pr_err("Couldn't register %s interrupt\n", "via1");
>> }
>>
>> Hence IRQ_AUTO_1 must be shared and we cannot use an optimized chain
>> handler for via1_irq()
>
> I'm pretty sure that the "software" request_irq can be removed. It has
> come up before --
> http://marc.info/?l=linux-mac68k&m=110973724208746&w=2
>
> Maybe Brad can shed some light on this (?)
>
> I've just cloned and built your m68k-genirq branch. I will run some tests.
Thanks!
>> nor iop_ism_irq().
>
> via_register_interrupts() is not called on OSS.
You're right, I missed that.
>> This is the only remaining conflict I see.
Good, I'll convert them all to chain handlers.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2011-08-26 11:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 18:32 m68k: Convert to genirq (WIP) Geert Uytterhoeven
2011-05-31 8:35 ` Geert Uytterhoeven
2011-05-31 9:50 ` Thomas Gleixner
2011-05-31 19:54 ` Geert Uytterhoeven
2011-05-31 20:10 ` Thomas Gleixner
2011-06-03 11:20 ` Finn Thain
2011-06-03 11:33 ` Geert Uytterhoeven
2011-06-05 6:27 ` Brad Boyer
2011-06-05 7:45 ` Geert Uytterhoeven
2011-08-10 9:59 ` Geert Uytterhoeven
2011-08-10 10:53 ` Finn Thain
2011-08-10 16:19 ` Brad Boyer
2011-08-26 9:52 ` Geert Uytterhoeven
2011-08-26 11:21 ` Finn Thain
2011-08-26 11:32 ` Geert Uytterhoeven [this message]
2011-08-26 16:09 ` Brad Boyer
2011-06-04 17:56 ` Geert Uytterhoeven
2011-06-15 19:44 ` Geert Uytterhoeven
2011-06-16 19:30 ` Geert Uytterhoeven
2011-06-16 20:03 ` Thomas Gleixner
2011-06-17 3:45 ` Finn Thain
2011-06-17 5:01 ` Geert Uytterhoeven
2011-08-08 13:08 ` Geert Uytterhoeven
2011-08-10 10:48 ` Finn Thain
2011-06-16 19:45 ` Geert Uytterhoeven
2011-06-16 21:10 ` Michael Schmitz
2011-06-17 17:25 ` Andreas Schwab
2011-06-17 17:22 ` Andreas Schwab
2011-06-19 10:17 ` Geert Uytterhoeven
2011-06-19 11:19 ` Andreas Schwab
2011-06-19 13:36 ` Geert Uytterhoeven
2011-06-19 13:58 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdVz40_HyFpgttGmUO_DBM58vgOhEq3YGzJ0tUM+k9B26w@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=flar@allandria.com \
--cc=fthain@telegraphics.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).