From: Andreas Schwab <schwab@linux-m68k.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Michael Schmitz <schmitzmic@googlemail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
"Linux\/m68k" <linux-m68k@vger.kernel.org>
Subject: Re: m68k: Convert to genirq (WIP)
Date: Sun, 19 Jun 2011 15:58:57 +0200 [thread overview]
Message-ID: <m2ips1kjmm.fsf@igel.home> (raw)
In-Reply-To: <BANLkTimWnDmKx2bh7T+V_x-pPj47faLJfw@mail.gmail.com> (Geert Uytterhoeven's message of "Sun, 19 Jun 2011 15:36:58 +0200")
Geert Uytterhoeven <geert@linux-m68k.org> writes:
> On Sun, Jun 19, 2011 at 13:19, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> Geert Uytterhoeven <geert@linux-m68k.org> writes:
>>
>>> BUG_ON(!irqs_disabled()) triggers as flags is 0x2619 there.
>>
>> Which is correct, since arch_local_irq_disable would set it to 2719.
>> You need to find out why arch_local_irq_disable wasn't called.
>
> I don't think we ever explicitly disable interrupts in interrupt handlers.
Then the BUG_ON is wrong.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2011-06-19 13:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 18:32 m68k: Convert to genirq (WIP) Geert Uytterhoeven
2011-05-31 8:35 ` Geert Uytterhoeven
2011-05-31 9:50 ` Thomas Gleixner
2011-05-31 19:54 ` Geert Uytterhoeven
2011-05-31 20:10 ` Thomas Gleixner
2011-06-03 11:20 ` Finn Thain
2011-06-03 11:33 ` Geert Uytterhoeven
2011-06-05 6:27 ` Brad Boyer
2011-06-05 7:45 ` Geert Uytterhoeven
2011-08-10 9:59 ` Geert Uytterhoeven
2011-08-10 10:53 ` Finn Thain
2011-08-10 16:19 ` Brad Boyer
2011-08-26 9:52 ` Geert Uytterhoeven
2011-08-26 11:21 ` Finn Thain
2011-08-26 11:32 ` Geert Uytterhoeven
2011-08-26 16:09 ` Brad Boyer
2011-06-04 17:56 ` Geert Uytterhoeven
2011-06-15 19:44 ` Geert Uytterhoeven
2011-06-16 19:30 ` Geert Uytterhoeven
2011-06-16 20:03 ` Thomas Gleixner
2011-06-17 3:45 ` Finn Thain
2011-06-17 5:01 ` Geert Uytterhoeven
2011-08-08 13:08 ` Geert Uytterhoeven
2011-08-10 10:48 ` Finn Thain
2011-06-16 19:45 ` Geert Uytterhoeven
2011-06-16 21:10 ` Michael Schmitz
2011-06-17 17:25 ` Andreas Schwab
2011-06-17 17:22 ` Andreas Schwab
2011-06-19 10:17 ` Geert Uytterhoeven
2011-06-19 11:19 ` Andreas Schwab
2011-06-19 13:36 ` Geert Uytterhoeven
2011-06-19 13:58 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ips1kjmm.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schmitzmic@googlemail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).