* [PATCH 10/62] gpio: gpio-bd9571mwv: Use new GPIO_LINE_DIRECTION
[not found] <cover.1572945734.git.matti.vaittinen@fi.rohmeurope.com>
@ 2019-11-05 10:14 ` Matti Vaittinen
2019-11-05 10:31 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Matti Vaittinen @ 2019-11-05 10:14 UTC (permalink / raw)
To: matti.vaittinen, mazziesaccount
Cc: Marek Vasut, Linus Walleij, Bartosz Golaszewski, linux-kernel,
linux-renesas-soc, linux-gpio
It's hard for occasional GPIO code reader/writer to know if values 0/1
equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and
GPIO_LINE_DIRECTION_OUT to help them out.
NOTE: This commit also changes the return value for direction get
to equal 1 for direction INPUT. Prior this commit the driver returned
different values depending on GPIO pin for the INPUT state.
Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
---
drivers/gpio/gpio-bd9571mwv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio-bd9571mwv.c
index 5224a946e8ab..c0abc9c6851b 100644
--- a/drivers/gpio/gpio-bd9571mwv.c
+++ b/drivers/gpio/gpio-bd9571mwv.c
@@ -37,8 +37,10 @@ static int bd9571mwv_gpio_get_direction(struct gpio_chip *chip,
ret = regmap_read(gpio->bd->regmap, BD9571MWV_GPIO_DIR, &val);
if (ret < 0)
return ret;
+ if (val & BIT(offset))
+ return GPIO_LINE_DIRECTION_IN;
- return val & BIT(offset);
+ return GPIO_LINE_DIRECTION_OUT;
}
static int bd9571mwv_gpio_direction_input(struct gpio_chip *chip,
--
2.21.0
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 10/62] gpio: gpio-bd9571mwv: Use new GPIO_LINE_DIRECTION
2019-11-05 10:14 ` [PATCH 10/62] gpio: gpio-bd9571mwv: Use new GPIO_LINE_DIRECTION Matti Vaittinen
@ 2019-11-05 10:31 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-11-05 10:31 UTC (permalink / raw)
To: Matti Vaittinen
Cc: Matti Vaittinen, Marek Vasut, Linus Walleij, Bartosz Golaszewski,
Linux Kernel Mailing List, Linux-Renesas,
open list:GPIO SUBSYSTEM
Hi Matti,
On Tue, Nov 5, 2019 at 11:15 AM Matti Vaittinen
<matti.vaittinen@fi.rohmeurope.com> wrote:
> It's hard for occasional GPIO code reader/writer to know if values 0/1
> equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and
> GPIO_LINE_DIRECTION_OUT to help them out.
>
> NOTE: This commit also changes the return value for direction get
> to equal 1 for direction INPUT. Prior this commit the driver returned
> different values depending on GPIO pin for the INPUT state.
Indeed. Which means you cannot assume the assembler output
before/after is identical (which it should be for most changes).
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> --- a/drivers/gpio/gpio-bd9571mwv.c
> +++ b/drivers/gpio/gpio-bd9571mwv.c
> @@ -37,8 +37,10 @@ static int bd9571mwv_gpio_get_direction(struct gpio_chip *chip,
> ret = regmap_read(gpio->bd->regmap, BD9571MWV_GPIO_DIR, &val);
> if (ret < 0)
> return ret;
Nit: I'd keep the blank line here.
> + if (val & BIT(offset))
> + return GPIO_LINE_DIRECTION_IN;
>
> - return val & BIT(offset);
> + return GPIO_LINE_DIRECTION_OUT;
> }
>
> static int bd9571mwv_gpio_direction_input(struct gpio_chip *chip,
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-05 10:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1572945734.git.matti.vaittinen@fi.rohmeurope.com>
2019-11-05 10:14 ` [PATCH 10/62] gpio: gpio-bd9571mwv: Use new GPIO_LINE_DIRECTION Matti Vaittinen
2019-11-05 10:31 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).