[PATCH] staging: emxx_udc: fix alignment issues

[PATCH] staging: emxx_udc: fix alignment issues

[Harold Mertzweiller]

Three function calls can now be properly formatted inside the 100
characters limit.

Signed-off-by: Harold Mertzweiller <harold@mrtz.fr>
---
 drivers/staging/emxx_udc/emxx_udc.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index ecc5c9da9027..b6abd3770e81 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -1073,9 +1073,8 @@ static int _nbu2ss_epn_in_pio(struct nbu2ss_udc *udc, struct nbu2ss_ep *ep,
 		i_word_length = length / sizeof(u32);
 		if (i_word_length > 0) {
 			for (i = 0; i < i_word_length; i++) {
-				_nbu2ss_writel(
-					&preg->EP_REGS[ep->epnum - 1].EP_WRITE,
-					p_buf_32->dw);
+				_nbu2ss_writel(&preg->EP_REGS[ep->epnum - 1].EP_WRITE,
+					       p_buf_32->dw);
 
 				p_buf_32++;
 			}
@@ -1225,8 +1224,7 @@ static void _nbu2ss_restert_transfer(struct nbu2ss_ep *ep)
 		return;
 
 	if (ep->epnum > 0) {
-		length = _nbu2ss_readl(
-			&ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT);
+		length = _nbu2ss_readl(&ep->udc->p_regs->EP_REGS[ep->epnum - 1].EP_LEN_DCNT);
 
 		length &= EPN_LDATA;
 		if (length < ep->ep.maxpacket)
@@ -1462,8 +1460,7 @@ static void _nbu2ss_epn_set_stall(struct nbu2ss_udc *udc,
 		for (limit_cnt = 0
 			; limit_cnt < IN_DATA_EMPTY_COUNT
 			; limit_cnt++) {
-			regdata = _nbu2ss_readl(
-				&preg->EP_REGS[ep->epnum - 1].EP_STATUS);
+			regdata = _nbu2ss_readl(&preg->EP_REGS[ep->epnum - 1].EP_STATUS);
 
 			if ((regdata & EPN_IN_DATA) == 0)
 				break;
-- 
2.20.1

Re: [PATCH] staging: emxx_udc: fix alignment issues

[Geert Uytterhoeven]

Hi Harold,

On Mon, May 24, 2021 at 6:46 PM Harold Mertzweiller <harold@mrtz.fr> wrote:
> Three function calls can now be properly formatted inside the 100
> characters limit.
>
> Signed-off-by: Harold Mertzweiller <harold@mrtz.fr>

Thanks for your patch!

>  drivers/staging/emxx_udc/emxx_udc.c | 11 ++++-------

I'm so happy people are improving this driver!
Is it working well on your hardware?
Do you think it's ready to migrate out of staging?

Thanks again!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] staging: emxx_udc: fix alignment issues

[Harold Mertzweiller]

On 27/05/2021 10:43, Geert Uytterhoeven wrote:
> Hi Harold,
> 
> On Mon, May 24, 2021 at 6:46 PM Harold Mertzweiller <harold@mrtz.fr> wrote:
>> Three function calls can now be properly formatted inside the 100
>> characters limit.
>>
>> Signed-off-by: Harold Mertzweiller <harold@mrtz.fr>
> 
> Thanks for your patch!
> 
>>  drivers/staging/emxx_udc/emxx_udc.c | 11 ++++-------
> 
> I'm so happy people are improving this driver!
> Is it working well on your hardware?
> Do you think it's ready to migrate out of staging?
> 
> Thanks again!
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 

Hi Geert,

I sent this patch as part of the Eudyptula challenge. I just wanted to improve the coding style of any driver and unfortunately I don't use it.

Have a great day,
Harold