* [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA
@ 2016-10-06 13:57 Geert Uytterhoeven
2016-10-06 14:06 ` Timur Tabi
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2016-10-06 13:57 UTC (permalink / raw)
To: David S. Miller, Timur Tabi; +Cc: netdev, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
drivers/built-in.o: In function `emac_probe':
emac.c:(.text+0x3780b8): undefined reference to `bad_dma_ops'
emac.c:(.text+0x3780e2): undefined reference to `bad_dma_ops'
emac.c:(.text+0x378112): undefined reference to `bad_dma_ops'
emac.c:(.text+0x378146): undefined reference to `bad_dma_ops'
emac.c:(.text+0x37816e): undefined reference to `bad_dma_ops'
drivers/built-in.o:emac.c:(.text+0x37819a): more undefined references to `bad_dma_ops' follow
Add a dependency on HAS_DMA to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/net/ethernet/qualcomm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qualcomm/Kconfig b/drivers/net/ethernet/qualcomm/Kconfig
index 9ba568db576fb0e6..fe94d2baeaf26aa6 100644
--- a/drivers/net/ethernet/qualcomm/Kconfig
+++ b/drivers/net/ethernet/qualcomm/Kconfig
@@ -26,6 +26,7 @@ config QCA7000
config QCOM_EMAC
tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet support"
+ depends on HAS_DMA
select CRC32
select PHYLIB
---help---
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA
2016-10-06 13:57 [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA Geert Uytterhoeven
@ 2016-10-06 14:06 ` Timur Tabi
2016-10-06 14:10 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Timur Tabi @ 2016-10-06 14:06 UTC (permalink / raw)
To: Geert Uytterhoeven, David S. Miller; +Cc: netdev, linux-kernel
Geert Uytterhoeven wrote:
> config QCOM_EMAC
> tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet support"
> + depends on HAS_DMA
I think it needs to depend on HAS_IOMEM as well, to fix this error in
arch/um:
drivers/net/ethernet/qualcomm/emac/emac.c: In function 'emac_remove':
>> drivers/net/ethernet/qualcomm/emac/emac.c:727:3: error: implicit
declaration of function 'iounmap' [-Werror=implicit-function-declaration]
iounmap(adpt->phy.digital);
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA
2016-10-06 14:06 ` Timur Tabi
@ 2016-10-06 14:10 ` Geert Uytterhoeven
2016-10-06 14:12 ` Timur Tabi
0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2016-10-06 14:10 UTC (permalink / raw)
To: Timur Tabi; +Cc: David S. Miller, netdev, linux-kernel
On Thu, Oct 6, 2016 at 4:06 PM, Timur Tabi <timur@codeaurora.org> wrote:
> Geert Uytterhoeven wrote:
>>
>> config QCOM_EMAC
>> tristate "Qualcomm Technologies, Inc. EMAC Gigabit Ethernet
>> support"
>> + depends on HAS_DMA
>
>
> I think it needs to depend on HAS_IOMEM as well, to fix this error in
> arch/um:
>
> drivers/net/ethernet/qualcomm/emac/emac.c: In function 'emac_remove':
>>> drivers/net/ethernet/qualcomm/emac/emac.c:727:3: error: implicit
>>> declaration of function 'iounmap' [-Werror=implicit-function-declaration]
> iounmap(adpt->phy.digital);
Probably, I don't do UML allmodconfig builds.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA
2016-10-06 14:10 ` Geert Uytterhoeven
@ 2016-10-06 14:12 ` Timur Tabi
2016-10-06 14:45 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Timur Tabi @ 2016-10-06 14:12 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: David S. Miller, netdev, linux-kernel
Geert Uytterhoeven wrote:
> Probably, I don't do UML allmodconfig builds.
>
> Gr{oetje,eeting}s,
Would you mind submitting another version of your patch that includes
HAS_DMA and HAS_IOMEM, so that both build breaks can be fixed in one shot?
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA
2016-10-06 14:12 ` Timur Tabi
@ 2016-10-06 14:45 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2016-10-06 14:45 UTC (permalink / raw)
To: Timur Tabi; +Cc: David S. Miller, netdev, linux-kernel
On Thu, Oct 6, 2016 at 4:12 PM, Timur Tabi <timur@codeaurora.org> wrote:
> Geert Uytterhoeven wrote:
>>
>> Probably, I don't do UML allmodconfig builds.
>>
>> Gr{oetje,eeting}s,
>
>
> Would you mind submitting another version of your patch that includes
> HAS_DMA and HAS_IOMEM, so that both build breaks can be fixed in one shot?
Done.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-10-06 14:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-06 13:57 [PATCH] ethernet: qualcomm: QCOM_EMAC should depend on HAS_DMA Geert Uytterhoeven
2016-10-06 14:06 ` Timur Tabi
2016-10-06 14:10 ` Geert Uytterhoeven
2016-10-06 14:12 ` Timur Tabi
2016-10-06 14:45 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).