* [PATCH v2] sh: kernel: disassemble: Mark expected switch fall-throughs
@ 2019-08-10 5:24 Gustavo A. R. Silva
2019-08-10 6:58 ` Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2019-08-10 5:24 UTC (permalink / raw)
To: Yoshinori Sato, Rich Felker
Cc: linux-sh, linux-kernel, Gustavo A. R. Silva, Guenter Roeck, Joe Perches
Remove logically dead code and mark switch cases where we are expecting
to fall through.
Fix the following warnings (Building: defconfig sh):
arch/sh/kernel/disassemble.c:478:8: warning: this statement may fall
through [-Wimplicit-fallthrough=]
arch/sh/kernel/disassemble.c:487:8: warning: this statement may fall
through [-Wimplicit-fallthrough=]
arch/sh/kernel/disassemble.c:496:8: warning: this statement may fall
through [-Wimplicit-fallthrough=]
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
Changes in v2:
- Remove logically dead code. Pointed out by Joe Perches.
NOTE: If no one cares, I'll apply this to my tree and queue it up
for 5.3-rc4.
arch/sh/kernel/disassemble.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/sh/kernel/disassemble.c b/arch/sh/kernel/disassemble.c
index defebf1a9c8a..845543780cc5 100644
--- a/arch/sh/kernel/disassemble.c
+++ b/arch/sh/kernel/disassemble.c
@@ -475,8 +475,6 @@ static void print_sh_insn(u32 memaddr, u16 insn)
printk("dbr");
break;
case FD_REG_N:
- if (0)
- goto d_reg_n;
case F_REG_N:
printk("fr%d", rn);
break;
@@ -488,7 +486,7 @@ static void print_sh_insn(u32 memaddr, u16 insn)
printk("xd%d", rn & ~1);
break;
}
- d_reg_n:
+ /* else, fall through */
case D_REG_N:
printk("dr%d", rn);
break;
@@ -497,6 +495,7 @@ static void print_sh_insn(u32 memaddr, u16 insn)
printk("xd%d", rm & ~1);
break;
}
+ /* else, fall through */
case D_REG_M:
printk("dr%d", rm);
break;
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] sh: kernel: disassemble: Mark expected switch fall-throughs
2019-08-10 5:24 [PATCH v2] sh: kernel: disassemble: Mark expected switch fall-throughs Gustavo A. R. Silva
@ 2019-08-10 6:58 ` Geert Uytterhoeven
2019-08-10 12:54 ` Guenter Roeck
2019-08-13 8:50 ` Yoshinori Sato
2 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2019-08-10 6:58 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Yoshinori Sato, Rich Felker, Linux-sh list,
Linux Kernel Mailing List, Guenter Roeck, Joe Perches
On Sat, Aug 10, 2019 at 7:26 AM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> Remove logically dead code and mark switch cases where we are expecting
> to fall through.
>
> Fix the following warnings (Building: defconfig sh):
>
> arch/sh/kernel/disassemble.c:478:8: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
> arch/sh/kernel/disassemble.c:487:8: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
> arch/sh/kernel/disassemble.c:496:8: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] sh: kernel: disassemble: Mark expected switch fall-throughs
2019-08-10 5:24 [PATCH v2] sh: kernel: disassemble: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-08-10 6:58 ` Geert Uytterhoeven
@ 2019-08-10 12:54 ` Guenter Roeck
2019-08-13 8:50 ` Yoshinori Sato
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2019-08-10 12:54 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Yoshinori Sato, Rich Felker, linux-sh, linux-kernel, Joe Perches
On Sat, Aug 10, 2019 at 12:24:42AM -0500, Gustavo A. R. Silva wrote:
> Remove logically dead code and mark switch cases where we are expecting
> to fall through.
>
> Fix the following warnings (Building: defconfig sh):
>
> arch/sh/kernel/disassemble.c:478:8: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
> arch/sh/kernel/disassemble.c:487:8: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
> arch/sh/kernel/disassemble.c:496:8: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Changes in v2:
> - Remove logically dead code. Pointed out by Joe Perches.
>
> NOTE: If no one cares, I'll apply this to my tree and queue it up
> for 5.3-rc4.
>
> arch/sh/kernel/disassemble.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/sh/kernel/disassemble.c b/arch/sh/kernel/disassemble.c
> index defebf1a9c8a..845543780cc5 100644
> --- a/arch/sh/kernel/disassemble.c
> +++ b/arch/sh/kernel/disassemble.c
> @@ -475,8 +475,6 @@ static void print_sh_insn(u32 memaddr, u16 insn)
> printk("dbr");
> break;
> case FD_REG_N:
> - if (0)
> - goto d_reg_n;
> case F_REG_N:
> printk("fr%d", rn);
> break;
> @@ -488,7 +486,7 @@ static void print_sh_insn(u32 memaddr, u16 insn)
> printk("xd%d", rn & ~1);
> break;
> }
> - d_reg_n:
> + /* else, fall through */
> case D_REG_N:
> printk("dr%d", rn);
> break;
> @@ -497,6 +495,7 @@ static void print_sh_insn(u32 memaddr, u16 insn)
> printk("xd%d", rm & ~1);
> break;
> }
> + /* else, fall through */
> case D_REG_M:
> printk("dr%d", rm);
> break;
> --
> 2.22.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] sh: kernel: disassemble: Mark expected switch fall-throughs
2019-08-10 5:24 [PATCH v2] sh: kernel: disassemble: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-08-10 6:58 ` Geert Uytterhoeven
2019-08-10 12:54 ` Guenter Roeck
@ 2019-08-13 8:50 ` Yoshinori Sato
2 siblings, 0 replies; 4+ messages in thread
From: Yoshinori Sato @ 2019-08-13 8:50 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Rich Felker, linux-sh, linux-kernel, Guenter Roeck, Joe Perches
On Sat, 10 Aug 2019 14:24:42 +0900,
Gustavo A. R. Silva wrote:
>
> Remove logically dead code and mark switch cases where we are expecting
> to fall through.
>
> Fix the following warnings (Building: defconfig sh):
>
> arch/sh/kernel/disassemble.c:478:8: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
> arch/sh/kernel/disassemble.c:487:8: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
> arch/sh/kernel/disassemble.c:496:8: warning: this statement may fall
> through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> Changes in v2:
> - Remove logically dead code. Pointed out by Joe Perches.
>
> NOTE: If no one cares, I'll apply this to my tree and queue it up
> for 5.3-rc4.
>
> arch/sh/kernel/disassemble.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/sh/kernel/disassemble.c b/arch/sh/kernel/disassemble.c
> index defebf1a9c8a..845543780cc5 100644
> --- a/arch/sh/kernel/disassemble.c
> +++ b/arch/sh/kernel/disassemble.c
> @@ -475,8 +475,6 @@ static void print_sh_insn(u32 memaddr, u16 insn)
> printk("dbr");
> break;
> case FD_REG_N:
> - if (0)
> - goto d_reg_n;
> case F_REG_N:
> printk("fr%d", rn);
> break;
> @@ -488,7 +486,7 @@ static void print_sh_insn(u32 memaddr, u16 insn)
> printk("xd%d", rn & ~1);
> break;
> }
> - d_reg_n:
> + /* else, fall through */
> case D_REG_N:
> printk("dr%d", rn);
> break;
> @@ -497,6 +495,7 @@ static void print_sh_insn(u32 memaddr, u16 insn)
> printk("xd%d", rm & ~1);
> break;
> }
> + /* else, fall through */
> case D_REG_M:
> printk("dr%d", rm);
> break;
> --
> 2.22.0
>
Applied sh-next.
Thanks.
--
Yosinori Sato
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-13 8:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-10 5:24 [PATCH v2] sh: kernel: disassemble: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-08-10 6:58 ` Geert Uytterhoeven
2019-08-10 12:54 ` Guenter Roeck
2019-08-13 8:50 ` Yoshinori Sato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).