[PATCH] dt-bindings: clock: renesas: Make example 'clocks' parsable

[PATCH] dt-bindings: clock: renesas: Make example 'clocks' parsable

[Rob Herring]

'clocks' in the example is not parsable with the 0 phandle value
because the number of #clock-cells is unknown in the previous entry.
Solve this by adding the clock provider node. Only 'cpg_clocks' is
needed as the examples are built with fixups which can be used to
identify phandles.

This is in preparation to support schema validation on .dtb files.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 .../bindings/clock/renesas,cpg-div6-clock.yaml       | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml b/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
index c55a7c494e01..2197c952e21d 100644
--- a/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/renesas,cpg-div6-clock.yaml
@@ -51,6 +51,18 @@ additionalProperties: false
 examples:
   - |
     #include <dt-bindings/clock/r8a73a4-clock.h>
+
+    cpg_clocks: cpg_clocks@e6150000 {
+            compatible = "renesas,r8a73a4-cpg-clocks";
+            reg = <0xe6150000 0x10000>;
+            clocks = <&extal1_clk>, <&extal2_clk>;
+            #clock-cells = <1>;
+            clock-output-names = "main", "pll0", "pll1", "pll2",
+                                  "pll2s", "pll2h", "z", "z2",
+                                  "i", "m3", "b", "m1", "m2",
+                                  "zx", "zs", "hp";
+    };
+
     sdhi2_clk: sdhi2_clk@e615007c {
             compatible = "renesas,r8a73a4-div6-clock", "renesas,cpg-div6-clock";
             reg = <0xe615007c 4>;
-- 
2.32.0

Re: [PATCH] dt-bindings: clock: renesas: Make example 'clocks' parsable

[Geert Uytterhoeven]

Hi Rob,

On Tue, Mar 1, 2022 at 8:04 PM Rob Herring <robh@kernel.org> wrote:
> 'clocks' in the example is not parsable with the 0 phandle value
> because the number of #clock-cells is unknown in the previous entry.
> Solve this by adding the clock provider node. Only 'cpg_clocks' is
> needed as the examples are built with fixups which can be used to
> identify phandles.
>
> This is in preparation to support schema validation on .dtb files.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Do you want me to queue this in renesas-clk-for-v5.19, or do you
want to take it yourself, together with the validation patches?
Please let me know.

In the latter case:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dt-bindings: clock: renesas: Make example 'clocks' parsable

[Rob Herring]

On Fri, Mar 4, 2022 at 3:09 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Rob,
>
> On Tue, Mar 1, 2022 at 8:04 PM Rob Herring <robh@kernel.org> wrote:
> > 'clocks' in the example is not parsable with the 0 phandle value
> > because the number of #clock-cells is unknown in the previous entry.
> > Solve this by adding the clock provider node. Only 'cpg_clocks' is
> > needed as the examples are built with fixups which can be used to
> > identify phandles.
> >
> > This is in preparation to support schema validation on .dtb files.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Do you want me to queue this in renesas-clk-for-v5.19, or do you
> want to take it yourself, together with the validation patches?
> Please let me know.

You can take it.

Rob

Re: [PATCH] dt-bindings: clock: renesas: Make example 'clocks' parsable

[Geert Uytterhoeven]

Hi Rob,

On Fri, Mar 4, 2022 at 2:28 PM Rob Herring <robh@kernel.org> wrote:
> On Fri, Mar 4, 2022 at 3:09 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Tue, Mar 1, 2022 at 8:04 PM Rob Herring <robh@kernel.org> wrote:
> > > 'clocks' in the example is not parsable with the 0 phandle value
> > > because the number of #clock-cells is unknown in the previous entry.
> > > Solve this by adding the clock provider node. Only 'cpg_clocks' is
> > > needed as the examples are built with fixups which can be used to
> > > identify phandles.
> > >
> > > This is in preparation to support schema validation on .dtb files.
> > >
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> >
> > Thanks for your patch!
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Do you want me to queue this in renesas-clk-for-v5.19, or do you
> > want to take it yourself, together with the validation patches?
> > Please let me know.
>
> You can take it.

Thanks, queuing in renesas-clk-for-v5.19.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dt-bindings: clock: renesas: Make example 'clocks' parsable

[Rob Herring]

On Tue, Mar 8, 2022 at 3:53 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Rob,
>
> On Fri, Mar 4, 2022 at 2:28 PM Rob Herring <robh@kernel.org> wrote:
> > On Fri, Mar 4, 2022 at 3:09 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > On Tue, Mar 1, 2022 at 8:04 PM Rob Herring <robh@kernel.org> wrote:
> > > > 'clocks' in the example is not parsable with the 0 phandle value
> > > > because the number of #clock-cells is unknown in the previous entry.
> > > > Solve this by adding the clock provider node. Only 'cpg_clocks' is
> > > > needed as the examples are built with fixups which can be used to
> > > > identify phandles.
> > > >
> > > > This is in preparation to support schema validation on .dtb files.
> > > >
> > > > Signed-off-by: Rob Herring <robh@kernel.org>
> > >
> > > Thanks for your patch!
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > Do you want me to queue this in renesas-clk-for-v5.19, or do you
> > > want to take it yourself, together with the validation patches?
> > > Please let me know.
> >
> > You can take it.
>
> Thanks, queuing in renesas-clk-for-v5.19.

This needs to go in 5.18, not 5.19.

Rob

Re: [PATCH] dt-bindings: clock: renesas: Make example 'clocks' parsable

[Geert Uytterhoeven]

Hi Rob,

On Wed, Mar 23, 2022 at 3:07 PM Rob Herring <robh@kernel.org> wrote:
> On Tue, Mar 8, 2022 at 3:53 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Fri, Mar 4, 2022 at 2:28 PM Rob Herring <robh@kernel.org> wrote:
> > > On Fri, Mar 4, 2022 at 3:09 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > On Tue, Mar 1, 2022 at 8:04 PM Rob Herring <robh@kernel.org> wrote:
> > > > > 'clocks' in the example is not parsable with the 0 phandle value
> > > > > because the number of #clock-cells is unknown in the previous entry.
> > > > > Solve this by adding the clock provider node. Only 'cpg_clocks' is
> > > > > needed as the examples are built with fixups which can be used to
> > > > > identify phandles.
> > > > >
> > > > > This is in preparation to support schema validation on .dtb files.
> > > > >
> > > > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > >
> > > > Thanks for your patch!
> > > >
> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > >
> > > > Do you want me to queue this in renesas-clk-for-v5.19, or do you
> > > > want to take it yourself, together with the validation patches?
> > > > Please let me know.
> > >
> > > You can take it.
> >
> > Thanks, queuing in renesas-clk-for-v5.19.
>
> This needs to go in 5.18, not 5.19.

Mike/Stephen: can you please take this directly?
Thanks!

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] dt-bindings: clock: renesas: Make example 'clocks' parsable

[Stephen Boyd]

Quoting Rob Herring (2022-03-01 11:03:59)
> 'clocks' in the example is not parsable with the 0 phandle value
> because the number of #clock-cells is unknown in the previous entry.
> Solve this by adding the clock provider node. Only 'cpg_clocks' is
> needed as the examples are built with fixups which can be used to
> identify phandles.
> 
> This is in preparation to support schema validation on .dtb files.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---

Applied to clk-next