* [PATCH] vc04_services: Fixing coding and logical guidelines
@ 2017-03-14 13:09 Pushkar Jambhlekar
2017-03-15 4:52 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Pushkar Jambhlekar @ 2017-03-14 13:09 UTC (permalink / raw)
To: Stephen Warren, Lee Jones, Eric Anholt, Greg Kroah-Hartman,
Michael Zoran, Daniel Stone, Stefan Wahren, Noralf Trønnes,
Stafford Horne, Pushkar Jambhlekar, popcornmix
Cc: moderated list:BROADCOM BCM2835 ARM ARCHITECTURE,
moderated list:BROADCOM BCM2835 ARM ARCHITECTURE,
open list:STAGING SUBSYSTEM, open list
Description:
in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes to make code according to 'checkpath.pl'.
Also, fixing logical issue, i.e. removing break after goto statement.
Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
.../vc04_services/interface/vchiq_arm/vchiq_shim.c | 33 ++++++++++++++++------
1 file changed, 24 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
index 48984ab..6d8a1d8 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
@@ -52,7 +52,8 @@ typedef struct {
/* ----------------------------------------------------------------------
* return pointer to the mphi message driver function table
- * -------------------------------------------------------------------- */
+ * ----------------------------------------------------------------------
+ */
const VCHI_MESSAGE_DRIVER_T *
vchi_mphi_message_driver_func_table(void)
{
@@ -61,7 +62,8 @@ vchi_mphi_message_driver_func_table(void)
/* ----------------------------------------------------------------------
* return a pointer to the 'single' connection driver fops
- * -------------------------------------------------------------------- */
+ * ----------------------------------------------------------------------
+ */
const VCHI_CONNECTION_API_T *
single_get_func_table(void)
{
@@ -556,6 +558,7 @@ EXPORT_SYMBOL(vchi_connect);
int32_t vchi_disconnect(VCHI_INSTANCE_T instance_handle)
{
VCHIQ_INSTANCE_T instance = (VCHIQ_INSTANCE_T)instance_handle;
+
return vchiq_status_to_vchi(vchiq_shutdown(instance));
}
EXPORT_SYMBOL(vchi_disconnect);
@@ -592,7 +595,6 @@ static VCHIQ_STATUS_T shim_callback(VCHIQ_REASON_T reason,
VCHI_CALLBACK_MSG_AVAILABLE, NULL);
goto done;
- break;
case VCHIQ_BULK_TRANSMIT_DONE:
service->callback(service->callback_param,
@@ -733,8 +735,10 @@ int32_t vchi_service_close(const VCHI_SERVICE_HANDLE_T handle)
{
int32_t ret = -1;
SHIM_SERVICE_T *service = (SHIM_SERVICE_T *)handle;
+
if (service) {
VCHIQ_STATUS_T status = vchiq_close_service(service->handle);
+
if (status == VCHIQ_SUCCESS) {
service_free(service);
service = NULL;
@@ -750,8 +754,10 @@ int32_t vchi_service_destroy(const VCHI_SERVICE_HANDLE_T handle)
{
int32_t ret = -1;
SHIM_SERVICE_T *service = (SHIM_SERVICE_T *)handle;
+
if (service) {
VCHIQ_STATUS_T status = vchiq_remove_service(service->handle);
+
if (status == VCHIQ_SUCCESS) {
service_free(service);
service = NULL;
@@ -770,6 +776,7 @@ int32_t vchi_service_set_option(const VCHI_SERVICE_HANDLE_T handle,
int32_t ret = -1;
SHIM_SERVICE_T *service = (SHIM_SERVICE_T *)handle;
VCHIQ_SERVICE_OPTION_T vchiq_option;
+
switch (option) {
case VCHI_SERVICE_OPTION_TRACE:
vchiq_option = VCHIQ_SERVICE_OPTION_TRACE;
@@ -797,8 +804,8 @@ int32_t vchi_get_peer_version(const VCHI_SERVICE_HANDLE_T handle, short *peer_ve
{
int32_t ret = -1;
SHIM_SERVICE_T *service = (SHIM_SERVICE_T *)handle;
- if (service)
- {
+
+ if (service) {
VCHIQ_STATUS_T status;
status = vchiq_get_peer_version(service->handle, peer_version);
@@ -811,7 +818,8 @@ EXPORT_SYMBOL(vchi_get_peer_version);
/* ----------------------------------------------------------------------
* read a uint32_t from buffer.
* network format is defined to be little endian
- * -------------------------------------------------------------------- */
+ * ----------------------------------------------------------------------
+ */
uint32_t
vchi_readbuf_uint32(const void *_ptr)
{
@@ -822,11 +830,13 @@ vchi_readbuf_uint32(const void *_ptr)
/* ----------------------------------------------------------------------
* write a uint32_t to buffer.
* network format is defined to be little endian
- * -------------------------------------------------------------------- */
+ * ----------------------------------------------------------------------
+ */
void
vchi_writebuf_uint32(void *_ptr, uint32_t value)
{
unsigned char *ptr = _ptr;
+
ptr[0] = (unsigned char)((value >> 0) & 0xFF);
ptr[1] = (unsigned char)((value >> 8) & 0xFF);
ptr[2] = (unsigned char)((value >> 16) & 0xFF);
@@ -836,7 +846,8 @@ vchi_writebuf_uint32(void *_ptr, uint32_t value)
/* ----------------------------------------------------------------------
* read a uint16_t from buffer.
* network format is defined to be little endian
- * -------------------------------------------------------------------- */
+ * ----------------------------------------------------------------------
+ */
uint16_t
vchi_readbuf_uint16(const void *_ptr)
{
@@ -847,11 +858,13 @@ vchi_readbuf_uint16(const void *_ptr)
/* ----------------------------------------------------------------------
* write a uint16_t into the buffer.
* network format is defined to be little endian
- * -------------------------------------------------------------------- */
+ * ----------------------------------------------------------------------
+ */
void
vchi_writebuf_uint16(void *_ptr, uint16_t value)
{
unsigned char *ptr = _ptr;
+
ptr[0] = (value >> 0) & 0xFF;
ptr[1] = (value >> 8) & 0xFF;
}
@@ -870,6 +883,7 @@ int32_t vchi_service_use(const VCHI_SERVICE_HANDLE_T handle)
{
int32_t ret = -1;
SHIM_SERVICE_T *service = (SHIM_SERVICE_T *)handle;
+
if (service)
ret = vchiq_status_to_vchi(vchiq_use_service(service->handle));
return ret;
@@ -890,6 +904,7 @@ int32_t vchi_service_release(const VCHI_SERVICE_HANDLE_T handle)
{
int32_t ret = -1;
SHIM_SERVICE_T *service = (SHIM_SERVICE_T *)handle;
+
if (service)
ret = vchiq_status_to_vchi(
vchiq_release_service(service->handle));
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] vc04_services: Fixing coding and logical guidelines
2017-03-14 13:09 [PATCH] vc04_services: Fixing coding and logical guidelines Pushkar Jambhlekar
@ 2017-03-15 4:52 ` Greg Kroah-Hartman
2017-03-15 5:02 ` Pushkar Jambhlekar
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2017-03-15 4:52 UTC (permalink / raw)
To: Pushkar Jambhlekar
Cc: Stephen Warren, Lee Jones, Eric Anholt, Michael Zoran,
Daniel Stone, Stefan Wahren, Noralf Trønnes, Stafford Horne,
popcornmix, moderated list:BROADCOM BCM2835 ARM ARCHITECTURE,
moderated list:BROADCOM BCM2835 ARM ARCHITECTURE,
open list:STAGING SUBSYSTEM, open list
On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote:
> Description:
No need for that line.
> in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes to make code according to 'checkpath.pl'.
Why indent? Also, you need to be specific as to what type of changes
you made.
> Also, fixing logical issue, i.e. removing break after goto statement.
Don't do multiple things in the same patch, break it up into
one-patch-per-thing, and no, "checkpatch.pl cleanups" is not "one
thing" :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vc04_services: Fixing coding and logical guidelines
2017-03-15 4:52 ` Greg Kroah-Hartman
@ 2017-03-15 5:02 ` Pushkar Jambhlekar
0 siblings, 0 replies; 3+ messages in thread
From: Pushkar Jambhlekar @ 2017-03-15 5:02 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Stephen Warren, Lee Jones, Eric Anholt, Michael Zoran,
Daniel Stone, Stefan Wahren, Noralf Trønnes, Stafford Horne,
popcornmix, moderated list:BROADCOM BCM2835 ARM ARCHITECTURE,
moderated list:BROADCOM BCM2835 ARM ARCHITECTURE,
open list:STAGING SUBSYSTEM, open list
Thanks. I will rewrite patch according to the suggestions.
On Tue, Mar 14, 2017 at 9:52 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Mar 14, 2017 at 06:39:04PM +0530, Pushkar Jambhlekar wrote:
>> Description:
>
> No need for that line.
>
>> in file 'vc04_services/interface/vchiq_arm/vchiq_shim.c', making changes to make code according to 'checkpath.pl'.
>
> Why indent? Also, you need to be specific as to what type of changes
> you made.
>
>> Also, fixing logical issue, i.e. removing break after goto statement.
>
> Don't do multiple things in the same patch, break it up into
> one-patch-per-thing, and no, "checkpatch.pl cleanups" is not "one
> thing" :)
>
> thanks,
>
> greg k-h
--
Jambhlekar Pushkar Arun
M.Tech IIT Roorkee
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-15 5:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-14 13:09 [PATCH] vc04_services: Fixing coding and logical guidelines Pushkar Jambhlekar
2017-03-15 4:52 ` Greg Kroah-Hartman
2017-03-15 5:02 ` Pushkar Jambhlekar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).