linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Ohad Ben Cohen <ohad@wizery.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	"Anna, Suman" <s-anna@ti.com>,
	linux-remoteproc@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Bajjuri, Praneeth" <praneeth@ti.com>,
	Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH v3 3/6] remoteproc: pru: Add support for PRU specific interrupt configuration
Date: Tue, 8 Dec 2020 15:03:32 +0100	[thread overview]
Message-ID: <CAMxfBF6UVBkM_oV=oO0H+2VXxRjwp9ggLLrxQvSyg+VVOzPwTQ@mail.gmail.com> (raw)
In-Reply-To: <20201207173731.GA1509079@xps15>

Hi Mathieu

On Mon, 7 Dec 2020 at 18:37, Mathieu Poirier <mathieu.poirier@linaro.org> wrote:

[...]

> > +static int pru_handle_intrmap(struct rproc *rproc)
> > +{
> > +     struct device *dev = rproc->dev.parent;
> > +     struct pru_rproc *pru = rproc->priv;
> > +     struct pru_irq_rsc *rsc = pru->pru_interrupt_map;
> > +     struct irq_fwspec fwspec;
> > +     struct device_node *irq_parent;
> > +     int i, ret = 0;
> > +
> > +     /* not having pru_interrupt_map is not an error */
> > +     if (!rsc)
> > +             return 0;
> > +
> > +     /* currently supporting only type 0 */
> > +     if (rsc->type != 0) {
> > +             dev_err(dev, "unsupported rsc type: %d\n", rsc->type);
> > +             return -EINVAL;
> > +     }
> > +
> > +     if (rsc->num_evts > MAX_PRU_SYS_EVENTS)
> > +             return -EINVAL;
> > +
> > +     if (sizeof(*rsc) + rsc->num_evts * sizeof(struct pruss_int_map) !=
> > +         pru->pru_interrupt_map_sz)
> > +             return -EINVAL;
> > +
> > +     pru->evt_count = rsc->num_evts;
> > +     pru->mapped_irq = kcalloc(pru->evt_count, sizeof(int), GFP_KERNEL);
>
> sizeof(unsigned int)

Sure, I will post v4 addressing this comment and sorry for missing that.

Thank you,
Grzegorz

  parent reply	other threads:[~2020-12-08 14:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-04 20:18 [PATCH v3 0/6] Add a PRU remoteproc driver Grzegorz Jaszczyk
2020-12-04 20:18 ` [PATCH v3 1/6] dt-bindings: remoteproc: Add binding doc for PRU cores in the PRU-ICSS Grzegorz Jaszczyk
2020-12-04 20:18 ` [PATCH v3 2/6] remoteproc: pru: Add a PRU remoteproc driver Grzegorz Jaszczyk
2020-12-04 20:18 ` [PATCH v3 3/6] remoteproc: pru: Add support for PRU specific interrupt configuration Grzegorz Jaszczyk
2020-12-07 17:37   ` Mathieu Poirier
2020-12-08 11:04     ` Lee Jones
2020-12-08 14:03     ` Grzegorz Jaszczyk [this message]
2020-12-04 20:18 ` [PATCH v3 4/6] remoteproc: pru: Add pru-specific debugfs support Grzegorz Jaszczyk
2020-12-04 20:18 ` [PATCH v3 5/6] remoteproc: pru: Add support for various PRU cores on K3 AM65x SoCs Grzegorz Jaszczyk
2020-12-04 20:18 ` [PATCH v3 6/6] remoteproc: pru: Add support for various PRU cores on K3 J721E SoCs Grzegorz Jaszczyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMxfBF6UVBkM_oV=oO0H+2VXxRjwp9ggLLrxQvSyg+VVOzPwTQ@mail.gmail.com' \
    --to=grzegorz.jaszczyk@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=ohad@wizery.com \
    --cc=praneeth@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=rogerq@ti.com \
    --cc=s-anna@ti.com \
    --subject='Re: [PATCH v3 3/6] remoteproc: pru: Add support for PRU specific interrupt configuration' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).