From: Baolin Wang <baolin.wang@linaro.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Felipe Balbi <balbi@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
USB <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linaro Kernel Mailman List <linaro-kernel@lists.linaro.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler
Date: Tue, 27 Dec 2016 10:58:22 +0800 [thread overview]
Message-ID: <CAMz4kuJEdBxcZPRrv7-YV7jpZFtajY9j9G24iWDmiMp-t0+fAw@mail.gmail.com> (raw)
In-Reply-To: <5861D477.7070407@linux.intel.com>
Hi,
On 27 December 2016 at 10:39, Lu Baolu <baolu.lu@linux.intel.com> wrote:
> Hi,
>
> On 12/26/2016 04:01 PM, Baolin Wang wrote:
>> On some platfroms(like x86 platform), when one core is running the USB gadget
>> irq thread handler by dwc3_thread_interrupt(), meanwhile another core also can
>> respond other interrupts from dwc3 controller and modify the event buffer by
>> dwc3_interrupt() function, that will cause getting the wrong event count in
>> irq thread handler to make the USB function abnormal.
>>
>> We should add spin_lock/unlock() in dwc3_check_event_buf() to avoid this race.
>
> Why not spin_lock_irq ones? This lock seems to be used in both
> normal and interrupt threads. Or, I missed anything?
I assumed there are no nested interrupts, when one core is running at
interrupt context, then it can not respond any other interrupts, which
means we don't need to disable local IRQ now, right?
--
Baolin.wang
Best Regards
next prev parent reply other threads:[~2016-12-27 2:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-26 8:01 [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler Baolin Wang
2016-12-27 2:39 ` Lu Baolu
2016-12-27 2:58 ` Baolin Wang [this message]
2016-12-27 4:45 ` Lu Baolu
2016-12-27 11:05 ` Felipe Balbi
2016-12-28 15:27 ` Janusz Dziedzic
2016-12-28 16:19 ` Felipe Balbi
2016-12-29 1:29 ` John Youn
2017-01-05 19:08 ` John Youn
2017-01-06 2:44 ` Baolin Wang
2016-12-27 10:52 ` Janusz Dziedzic
2016-12-27 11:06 ` Baolin Wang
2016-12-27 11:11 ` Felipe Balbi
2016-12-27 12:16 ` Baolin Wang
2016-12-28 12:30 ` Janusz Dziedzic
2017-01-03 12:21 ` Baolin Wang
2017-01-03 12:33 ` Felipe Balbi
2017-01-05 2:07 ` Baolin Wang
2017-01-05 9:26 ` Felipe Balbi
2017-01-05 9:43 ` Baolin Wang
2017-01-05 11:19 ` Felipe Balbi
2017-01-05 12:03 ` Baolin Wang
2016-12-27 11:07 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMz4kuJEdBxcZPRrv7-YV7jpZFtajY9j9G24iWDmiMp-t0+fAw@mail.gmail.com \
--to=baolin.wang@linaro.org \
--cc=balbi@kernel.org \
--cc=baolu.lu@linux.intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).